Skip to content

Commit 25c13c3

Browse files
committed
chore: simplify if stmt / placate SQ
1 parent 3d39357 commit 25c13c3

1 file changed

Lines changed: 12 additions & 6 deletions

File tree

packages/gsul/src/getStatusUpdates.ts

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,16 +61,22 @@ export const filterOutFutureReduceToLatestUpdates = (
6161
}
6262
const group = itemGroups[item.itemId]
6363

64-
if (item.postDatedLastModifiedSetAt) { // this is a post-dated update
64+
if (item.postDatedLastModifiedSetAt && !group.postDated) { // this is a post-dated update
65+
group.postDated = item
66+
} else if (item.postDatedLastModifiedSetAt && group.postDated) { // also a post-dated update
6567
const existingTime = Date.parse(group.postDated.postDatedLastModifiedSetAt)
6668
const newTime = Date.parse(item.postDatedLastModifiedSetAt)
67-
group.postDated = !group.postDated || newTime > existingTime
68-
? item
69-
: group.postDated
70-
} else { // this is a regular update
69+
if (newTime > existingTime) {
70+
group.postDated = item
71+
}
72+
} else if (!group.regular) { // this is a regular update
73+
group.regular = item
74+
} else if (group.regular) { // also a regular update
7175
const existingTime = Date.parse(group.regular.lastUpdateDateTime)
7276
const newTime = Date.parse(item.lastUpdateDateTime)
73-
group.regular = !group.regular || newTime > existingTime ? item : group.regular
77+
if (newTime > existingTime) {
78+
group.regular = item
79+
}
7480
}
7581
})
7682

0 commit comments

Comments
 (0)