Skip to content

Commit 67de8c0

Browse files
authored
Fix: [AEA-0000] - Delete old notification state table (#1655)
## Summary - ⚠️ Potential issues that might be caused by this change ### Details The table schema was updated, which broke the merge flow. There are to be two PRs, one to delete the old table (this is fine, since notifications isn't live yet), followed by one to create the new one with the new schema. This PR is the former.
1 parent 3b47de6 commit 67de8c0

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

SAMtemplates/functions/main.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ Parameters:
2525
Type: String
2626
Default: none
2727

28-
PrescriptionNotificationStateTableName:
29-
Type: String
30-
Default: none
28+
# PrescriptionNotificationStateTableName:
29+
# Type: String
30+
# Default: none
3131

3232
NHSNotifyPrescriptionsSQSQueueUrl:
3333
Type: String
@@ -393,7 +393,7 @@ Resources:
393393
Variables:
394394
LOG_LEVEL: !Ref LogLevel
395395
NHS_NOTIFY_PRESCRIPTIONS_SQS_QUEUE_URL: !Ref NHSNotifyPrescriptionsSQSQueueUrl
396-
TABLE_NAME: !Ref PrescriptionNotificationStateTableName
396+
# TABLE_NAME: !Ref PrescriptionNotificationStateTableName
397397
Events:
398398
ScheduleEvent:
399399
Type: ScheduleV2
@@ -436,9 +436,9 @@ Resources:
436436
- - Fn::ImportValue: !Sub ${StackName}-WriteNHSNotifyPrescriptionsSQSQueuePolicyArn
437437
- Fn::ImportValue: !Sub ${StackName}-ReadNHSNotifyPrescriptionsSQSQueuePolicyArn
438438
- Fn::ImportValue: !Sub ${StackName}-UseNotificationSQSQueueKMSKeyPolicyArn
439-
- Fn::ImportValue: !Sub ${StackName}:tables:${PrescriptionNotificationStateTableName}:TableReadPolicyArn
440-
- Fn::ImportValue: !Sub ${StackName}:tables:${PrescriptionNotificationStateTableName}:TableWritePolicyArn
441-
- Fn::ImportValue: !Sub ${StackName}:tables:UsePrescriptionNotificationStateKMSKeyPolicyArn
439+
# - Fn::ImportValue: !Sub ${StackName}:tables:${PrescriptionNotificationStateTableName}:TableReadPolicyArn
440+
# - Fn::ImportValue: !Sub ${StackName}:tables:${PrescriptionNotificationStateTableName}:TableWritePolicyArn
441+
# - Fn::ImportValue: !Sub ${StackName}:tables:UsePrescriptionNotificationStateKMSKeyPolicyArn
442442

443443
Outputs:
444444
UpdatePrescriptionStatusFunctionName:

SAMtemplates/main_template.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ Resources:
142142
Parameters:
143143
StackName: !Ref AWS::StackName
144144
PrescriptionStatusUpdatesTableName: !GetAtt Tables.Outputs.PrescriptionStatusUpdatesTableName
145-
PrescriptionNotificationStateTableName: !GetAtt Tables.Outputs.PrescriptionNotificationStateTableName
145+
# PrescriptionNotificationStateTableName: !GetAtt Tables.Outputs.PrescriptionNotificationStateTableName
146146
NHSNotifyPrescriptionsSQSQueueUrl: !GetAtt Messaging.Outputs.NHSNotifyPrescriptionsSQSQueueUrl
147147
EnabledSiteODSCodesParam: !GetAtt Parameters.Outputs.EnabledSiteODSCodesParameterName
148148
EnabledSystemsParam: !GetAtt Parameters.Outputs.EnabledSystemsParameterName

0 commit comments

Comments
 (0)