Skip to content

Commit bbbcb5f

Browse files
committed
Remove application name from unit tests
1 parent 2d9c078 commit bbbcb5f

1 file changed

Lines changed: 10 additions & 13 deletions

File tree

packages/updatePrescriptionStatus/tests/testSqsClient.test.ts

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -458,42 +458,41 @@ describe("Unit tests for checkSiteOrSystemIsNotifyEnabled", () => {
458458
it("includes an item with an enabled ODS code", async () => {
459459
const previous = createMockDataItem({
460460
PharmacyODSCode: "FA565",
461-
ApplicationName: "not a real test supplier",
461+
ApplicationID: "00000000-0000-0000-0000-000000000000",
462462
Status: "previous"
463463
})
464464
const current = createMockDataItem({
465465
PharmacyODSCode: "FA565",
466-
ApplicationName: "not a real test supplier"
466+
ApplicationID: "00000000-0000-0000-0000-000000000000"
467467
})
468468
const result = await checkSiteOrSystemIsNotifyEnabled([{previous, current}], logger)
469469
expect(result).toStrictEqual([{previous, current}])
470470
expectLogReceivedAndAllowed(infoSpy, 1, 1)
471471
})
472472

473-
it("includes an item with an enabled ApplicationName", async () => {
473+
it("includes an item with an enabled ApplicationID", async () => {
474474
const previous = createMockDataItem({
475475
PharmacyODSCode: "ZZZ999",
476-
ApplicationName: "Internal Test System",
476+
ApplicationID: "550e8400-e29b-41d4-a716-446655440000",
477477
Status: "previous"
478478
})
479479
const current = createMockDataItem({
480480
PharmacyODSCode: "ZZZ999",
481-
ApplicationName: "Internal Test System"
481+
ApplicationID: "550e8400-e29b-41d4-a716-446655440000"
482482
})
483483
const result = await checkSiteOrSystemIsNotifyEnabled([{previous, current}], logger)
484484
expect(result).toEqual([{previous, current}])
485485
expectLogReceivedAndAllowed(infoSpy, 1, 1)
486486
})
487487

488-
it("is case insensitive for both ODS code and ApplicationName", async () => {
488+
it("is case insensitive for both ODS code and ApplicationID", async () => {
489489
const item1 = createMockDataItem({
490490
PharmacyODSCode: "fa565",
491-
ApplicationName: "not a real test supplier"
491+
ApplicationID: "00000000-0000-0000-0000-000000000000"
492492
})
493493
const item2 = createMockDataItem({
494494
PharmacyODSCode: "zzz999",
495-
ApplicationName: "internal test SYSTEM",
496-
ApplicationID: "550e8400-e29b-41d4-a716-446655440000"
495+
ApplicationID: "550E8400-E29B-41D4-A716-446655440000"
497496
})
498497
const result = await checkSiteOrSystemIsNotifyEnabled([
499498
{
@@ -520,12 +519,12 @@ describe("Unit tests for checkSiteOrSystemIsNotifyEnabled", () => {
520519
it("excludes an item when its ODS code is blocked, even if otherwise enabled", async () => {
521520
const previous = createMockDataItem({
522521
PharmacyODSCode: "b3j1z",
523-
ApplicationName: "Internal Test System",
522+
ApplicationID: "550e8400-e29b-41d4-a716-446655440000",
524523
Status: "previous"
525524
})
526525
const current = createMockDataItem({
527526
PharmacyODSCode: "b3j1z",
528-
ApplicationName: "Internal Test System"
527+
ApplicationID: "550e8400-e29b-41d4-a716-446655440000"
529528
})
530529
const result = await checkSiteOrSystemIsNotifyEnabled([{previous, current}], logger)
531530
expect(result).toEqual([])
@@ -535,13 +534,11 @@ describe("Unit tests for checkSiteOrSystemIsNotifyEnabled", () => {
535534
it("excludes items that are neither enabled nor blocked", async () => {
536535
const previous = createMockDataItem({
537536
PharmacyODSCode: "NOTINLIST",
538-
ApplicationName: "Some Other System",
539537
ApplicationID: "550e8400-e29b-41d4-a716-446655441234",
540538
Status: "previous"
541539
})
542540
const current = createMockDataItem({
543541
PharmacyODSCode: "NOTINLIST",
544-
ApplicationName: "Some Other System",
545542
ApplicationID: "550e8400-e29b-41d4-a716-446655441234"
546543
})
547544
const result = await checkSiteOrSystemIsNotifyEnabled([{previous, current}], logger)

0 commit comments

Comments
 (0)