Make attribute name optional. Deploy to int environment. Add manual check for attribute name in PSU lambda

Author: wildjames

.github/workflows/ci.yml

@@ -186,3 +186,41 @@ jobs:
       REGRESSION_TESTS_PEM: ${{ secrets.REGRESSION_TESTS_PEM }}
       CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.QA_CLOUD_FORMATION_DEPLOY_ROLE }}
       PROXYGEN_ROLE: ${{ secrets.PROXYGEN_PTL_ROLE }}
+
+  # TODO: DELETEME
+  release_int:
+    needs: [tag_release, package_code, get_commit_id]
+    uses: ./.github/workflows/run_release_code_and_api.yml
+    with:
+      ARTIFACT_BUCKET_PREFIX: ${{needs.tag_release.outputs.version_tag}}
+      STACK_NAME: psu
+      AWS_ENVIRONMENT: int
+      APIGEE_ENVIRONMENT: int
+      ENABLE_MUTUAL_TLS: true
+      BUILD_ARTIFACT: packaged_code
+      TRUSTSTORE_FILE: psu-truststore.pem
+      VERSION_NUMBER: ${{needs.tag_release.outputs.version_tag}}
+      COMMIT_ID: ${{needs.get_commit_id.outputs.commit_id}}
+      LOG_LEVEL: DEBUG
+      LOG_RETENTION_DAYS: 30
+      CREATE_INT_RELEASE_NOTES: true
+      CREATE_INT_RC_RELEASE_NOTES: true
+      DEPLOY_APIGEE: true
+      DYNAMODB_AUTOSCALE: false
+      DEPLOY_APIGEE_CPSU: true
+      DEPLOY_CHECK_PRESCRIPTION_STATUS_UPDATE: true
+      ENABLE_ALERTS: true
+      RUN_REGRESSION_TEST: true
+      STATE_MACHINE_LOG_LEVEL: ALL
+      ENABLE_NOTIFICATIONS_INTERNAL: true
+      ENABLE_NOTIFICATIONS_EXTERNAL: false
+      MTLS_KEY: psu-mtls-1
+      IS_PULL_REQUEST: false
+    secrets:
+      CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.INT_CLOUD_FORMATION_DEPLOY_ROLE }}
+      DEV_CLOUD_FORMATION_CHECK_VERSION_ROLE: ${{ secrets.DEV_CLOUD_FORMATION_CHECK_VERSION_ROLE }}
+      INT_CLOUD_FORMATION_CHECK_VERSION_ROLE: ${{ secrets.INT_CLOUD_FORMATION_CHECK_VERSION_ROLE }}
+      PROD_CLOUD_FORMATION_CHECK_VERSION_ROLE: ${{ secrets.PROD_CLOUD_FORMATION_CHECK_VERSION_ROLE }}
+      DEV_CLOUD_FORMATION_EXECUTE_LAMBDA_ROLE: ${{ secrets.DEV_CLOUD_FORMATION_EXECUTE_LAMBDA_ROLE }}
+      PROXYGEN_ROLE: ${{ secrets.PROXYGEN_PROD_ROLE }}
+      REGRESSION_TESTS_PEM: ${{ secrets.REGRESSION_TESTS_PEM }}

packages/specification/eps-prescription-status-update-api.yaml

@@ -239,7 +239,7 @@ paths:
           description: |
             Please ensure that any non-ASCII characters, including symbols like '+', in URL query string parameters are properly URL encoded.
 
-            URL encoding replaces unsafe characters with a "%" followed by two hexadecimal digits, and spaces are typically replaced with a plus (+) sign or "%20".  
+            URL encoding replaces unsafe characters with a "%" followed by two hexadecimal digits, and spaces are typically replaced with a plus (+) sign or "%20".
 
             The prescription id to return prescription status updates for
         - in: header
@@ -301,7 +301,7 @@ paths:
         ## Overview
         This endpoint provides a callback for the NHS notifications service to update the
         Prescription Status Update API on the delivery status of requested notifications.
-        
+
         Please refer to [their documentation](https://digital.nhs.uk/developer/api-catalogue/nhs-notify#post-/%3Cclient-provided-message-status-URI%3E) for more detail on the request schema.
       parameters:
         - in: header
@@ -455,7 +455,7 @@ x-nhsd-apim:
       secret: psu-mtls-1
   target-attributes:
     - name: name
-      required: true
+      required: false
     - name: show-all-suppliers
       required: false
       header: show-all-suppliers

packages/updatePrescriptionStatus/src/updatePrescriptionStatus.ts

@@ -75,6 +75,12 @@ const lambdaHandler = async (event: APIGatewayProxyEvent): Promise<APIGatewayPro
   })
   let responseEntries: Array<BundleEntry> = []
 
+  // Check for target attribute name header
+  if (!event.headers["attribute-name"]) {
+    logger.error("Missing `attribute-name` in request headers")
+    return response(400, responseEntries)
+  }
+
   const xRequestID = getXRequestID(event, responseEntries)
   const applicationName = event.headers["attribute-name"] ?? "unknown"