Skip to content

Commit e934106

Browse files
kkraus14cursoragent
andcommitted
Address review comments
- Revert cuda_python dependencies and optional-dependencies back to dynamic so setup.py controls the precise version pin at wheel-build time. - Pin astral-sh/setup-uv to commit SHA d4b2f3b6 (v5) in all workflows. - Remove twine install and twine check steps (uv build validates wheel metadata). - Regenerate uv.lock. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 3505cf1 commit e934106

6 files changed

Lines changed: 6 additions & 27 deletions

File tree

.github/workflows/build-docs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ jobs:
7878
conda config --show
7979
8080
- name: Install uv
81-
uses: astral-sh/setup-uv@v5
81+
uses: astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5
8282

8383
# WAR: Building the doc currently requires CTK installed (NVIDIA/cuda-python#326,327)
8484
- name: Set up mini CTK

.github/workflows/build-wheel.yml

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -107,11 +107,7 @@ jobs:
107107
env
108108
109109
- name: Install uv
110-
uses: astral-sh/setup-uv@v5
111-
112-
- name: Install twine
113-
run: |
114-
uv pip install twine
110+
uses: astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5
115111

116112
# To keep the build workflow simple, all matrix jobs will build a wheel for later use within this workflow.
117113
- name: Build and check cuda.pathfinder wheel
@@ -132,11 +128,6 @@ jobs:
132128
133129
# We only need/want a single pure python wheel, pick linux-64 index 0.
134130
# This is what we will use for testing & releasing.
135-
- name: Check cuda.pathfinder wheel
136-
if: ${{ strategy.job-index == 0 && inputs.host-platform == 'linux-64' }}
137-
run: |
138-
twine check --strict cuda_pathfinder/dist/*.whl
139-
140131
- name: Upload cuda.pathfinder build artifacts
141132
if: ${{ strategy.job-index == 0 && inputs.host-platform == 'linux-64' }}
142133
uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
@@ -195,9 +186,6 @@ jobs:
195186
$CHOWN -R $(whoami) ${{ env.CUDA_BINDINGS_ARTIFACTS_DIR }}
196187
ls -lahR ${{ env.CUDA_BINDINGS_ARTIFACTS_DIR }}
197188
198-
- name: Check cuda.bindings wheel
199-
run: |
200-
twine check --strict ${{ env.CUDA_BINDINGS_ARTIFACTS_DIR }}/*.whl
201189
202190
- name: Upload cuda.bindings build artifacts
203191
uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
@@ -271,7 +259,6 @@ jobs:
271259
run: |
272260
pushd cuda_python
273261
uv build --wheel
274-
twine check --strict dist/*.whl
275262
popd
276263
277264
- name: List the cuda-python artifacts directory
@@ -455,9 +442,6 @@ jobs:
455442
"${{ env.CUDA_CORE_ARTIFACTS_DIR }}"/cu"${BUILD_PREV_CUDA_MAJOR}"/cuda_core*.whl \
456443
--output-dir "${{ env.CUDA_CORE_ARTIFACTS_DIR }}"
457444
458-
- name: Check cuda.core wheel
459-
run: |
460-
twine check --strict ${{ env.CUDA_CORE_ARTIFACTS_DIR }}/*.whl
461445
462446
- name: Upload cuda.core build artifacts
463447
uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0

.github/workflows/coverage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ jobs:
8383
AGENT_TOOLSDIRECTORY: "/opt/hostedtoolcache"
8484

8585
- name: Install uv
86-
uses: astral-sh/setup-uv@v5
86+
uses: astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5
8787

8888
- name: Set up mini CTK
8989
if: ${{ env.LOCAL_CTK == '1' }}

.github/workflows/test-wheel-linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ jobs:
225225
AGENT_TOOLSDIRECTORY: "/opt/hostedtoolcache"
226226

227227
- name: Install uv
228-
uses: astral-sh/setup-uv@v5
228+
uses: astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5
229229

230230
- name: Set up mini CTK
231231
if: ${{ matrix.LOCAL_CTK == '1' }}

.github/workflows/test-wheel-windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ jobs:
209209
python-version: ${{ matrix.PY_VER }}
210210

211211
- name: Install uv
212-
uses: astral-sh/setup-uv@v5
212+
uses: astral-sh/setup-uv@d4b2f3b6ecc6e67c4457f6d3e41ec42d3d0fcb86 # v5
213213

214214
- name: Set up mini CTK
215215
if: ${{ matrix.LOCAL_CTK == '1' }}

cuda_python/pyproject.toml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,8 @@ classifiers = [
3232
"Environment :: GPU :: NVIDIA CUDA :: 12",
3333
"Environment :: GPU :: NVIDIA CUDA :: 13",
3434
]
35-
dynamic = ["version"]
35+
dynamic = ["version", "dependencies", "optional-dependencies"]
3636
requires-python = ">=3.10"
37-
dependencies = [
38-
"cuda-bindings",
39-
"cuda-pathfinder~=1.1",
40-
]
41-
optional-dependencies = { all = ["cuda-bindings[all]"] }
4237

4338
[project.urls]
4439
homepage = "https://nvidia.github.io/cuda-python/"

0 commit comments

Comments
 (0)