Merge remote-tracking branch 'refs/remotes/origin/main'

Author: arnaud65110

.gitignore

@@ -5,6 +5,7 @@
 /results
 /entries/entries.json
 *.sh
+*.cmd
 
 # Compiled l10n files: .mo should be ignored
 *.mo

README.md

@@ -33,7 +33,7 @@ Conakry;31.2
 Istanbul;23.0
 ```
 
-The task is to write an Object Pascal program which reads the file, calculates the min, mean, and max temperature value per weather station, and emits the results on `STDOUT` like this (i.e., sorted alphabetically by station name, and the result values per station in the format `<min>/<mean>/<max>`, rounded to one fractional digit towards positive infinity with both `17.01` and `17.05` being rounded to `17.1`, with the decimal separator being a period `.`):
+The task is to write an Object Pascal program which reads the file, calculates the min, mean, and max temperature value per weather station, and emits the results on `STDOUT` like this (i.e., sorted alphabetically by station name, and the result values per station in the format `<min>/<mean>/<max>`, rounded to one fractional digit, with the decimal separator being a period `.`, and for that you can chose one of the options presented in the [Rounding Section](#rounding) or implement your own that is consistent with the options provided.):
 
 ```
 {Abha=-23.0/18.0/59.2, Abidjan=-16.2/26.0/67.3, Abéché=-10.0/29.4/69.0, Accra=-10.1/26.4/66.4, Addis Ababa=-23.7/16.0/67.0, Adelaide=-27.8/17.3/58.5, ...}
@@ -70,45 +70,11 @@ Submit your implementation and become part of the leader board!
 
 ## Rounding
 
-In a discussion with [Mr. Packman](https://pack.ac/) themselves, we came up with a simpler solution. They even added some _Unit Testing_ :D.
-
-This will be the official way to round the output values, so pick your poison:
-```pas
-function RoundEx(x: Currency): Double; inline;
-begin
-  Result := Ceil(x * 10) / 10;
-end;
-
-function RoundExInteger(x: Currency): Integer; inline;
-begin
-  Result := Ceil(x * 10);
-end;
-
-{ Neater version by @bytebites from Lazarus forum }
-function RoundExString(x: Currency): String; inline;
-var
-  V, Q, R: Integer;
-begin
-  V := RoundExInteger(x);
-  divmod(V, 10, Q, R);
-  Result := IntToStr(Q) + '.' + chr(48 + Abs(R))
-end;
-
-procedure Test;
-var
-  F: Double;
-begin
-  for F in [10.01, 10.04, -10.01, -10.0, 0, -0, -0.01] do
-    WriteLn(RoundExInteger(F), ' ', RoundExString(F), ' ', RoundEx(F));
-  //101 10.1  1.0100000000000000E+001
-  //101 10.1  1.0100000000000000E+001
-  //-100 -10.0 -1.0000000000000000E+001
-  //-100 -10.0 -1.0000000000000000E+001
-  //0 0.0  0.0000000000000000E+000
-  //0 0.0  0.0000000000000000E+000
-  //0 0.0  0.0000000000000000E+000
-end;
-```
+With the help of this magnificent community, we were able to finally get to a rounding solution that works.
+
+This means that I'm encouraging everyone to use the code that is now in the [Baseline.Common](baseline/Common) unit.\
+I do have to make crystal clear that using that code is an **option**, one that you can always opt out of.\
+But if you do opt in, just include that unit in your entry and job's a done.
 
 ## Generating the measurements.txt
 > **NOTE**  
@@ -156,12 +122,12 @@ Expected `SHA256` hash:
 `ebad17b266ee9f5cb3d118531f197e6f68c9ab988abc5cb9506e6257e1a52ce6`
 
 ## Verify Output File
-> **NOTE**
->
-> We are still waiting for the Delphi version to be completed in order for us to have an official `SHA256` hash for the output.
->
-> Until then, this is the current one: `683bb3d247f53bab96e98983771d66bc9d7dbfb38aa3fecac4c04b8ab29e3032`
-> There's also an archived version of the [baseline output](./data/baseline.output.gz)
+
+There is now a Delphi version of the baseline. This means that we now have an official way of generating a valid output on both sides of the fence.
+
+With this, we now have the official hash: `4256d19d3e134d79cc6f160d428a1d859ce961167bd01ca528daca8705163910`
+
+There's also an archived version of the [baseline output](./data/baseline.output.gz)
 
 ## Differences From Original
 I've decided that I would want this challenge to be turned way up to 11!
@@ -188,11 +154,13 @@ These are the results from running all entries into the challenge on my personal
 
 | # | Result (m:s.ms) | Compiler | Submitter | Notes | Certificates |
 |--:|----------------:|---------:|:----------|:------|:-------------|
-| 1 | 0:1.7599   | lazarus-3.0, fpc-3.2.2 | Arnaud Bouchez    | Using `mORMot2`, 32 threads | |
-| 2 | 0:16.874   | lazarus-3.0, fpc-3.2.2 | Székely Balázs    | Using 32 threads | |
-| 3 | 0:20.0693  | lazarus-3.0, fpc-3.2.2 | Lurendrejer Aksen | Using 32 threads | |
-| 4 | 1:16.059   | lazarus-3.0, fpc-3.2.2 | Richard Lawson    | Using 1 thread   | |
-| 5 | 12:37.7864 | lazarus-3.0, fpc-3.2.2 | Iwan Kelaiah      | Using 1 thread | |
+| 1 | 0:1.971   | lazarus-3.0, fpc-3.2.2 | Arnaud Bouchez    | Using `mORMot2`, 32 threads | |
+| 2 | 0:20.960  | lazarus-3.0, fpc-3.2.2 | Székely Balázs    | Using 32 threads | |
+| 3 | 0:23.158  | lazarus-3.0, fpc-3.2.2 | Lurendrejer Aksen | Using 32 threads **(failed hash)** | |
+| 4 | 1:23.684  | lazarus-3.0, fpc-3.2.2 | Richard Lawson    | Using a single thread | |
+| 5 | 5:2.512   | lazarus-3.0, fpc-3.2.2 | Iwan Kelaiah      | Using a single thread | |
+| 6 | 7:54.606  | delphi 12.1            | David Cornelius   | Using 1 threads **(failed hash)** | |
+| 7 | 10:55.724 | delphi 12.1            | Brian Fire        | Using 1 threads | |
 
 > **NOTE**
 >
@@ -224,7 +192,8 @@ I'd like to thank [@mobius](https://github.com/mobius1qwe) for taking the time t
 I'd like to thank [@dtpfl](https://github.com/dtpfl) for his invaluable work on maintaining the `README.md` file up to date with everything.\
 I'd like to thank Székely Balázs for providing many patches to make everything compliant with the original challenge.\
 I'd like to thank [@corneliusdavid](https://github.com/corneliusdavid) for giving some of the information files a once over and making things more legible and clear.\
-I'd like to thank Mr. **Pack**man, aka O, for clearing the fog around the rounding issues.
+I'd like to thank Mr. **Pack**man, aka O, for clearing the fog around the rounding issues.\
+I'd like to thank [Georges](https://github.com/georges-hatem) for providing us with the Delphi version of baseline.
 
 ## Links
 The original repository: https://github.com/gunnarmorling/1brc \

baseline/Common/baseline.common.pas

@@ -7,219 +7,37 @@
 interface
 
 uses
-  Classes
-, SysUtils
-{$IFDEF FPC}
-  , Contnrs
-{$ELSE}
-{$ENDIF}
-
+ {$IFDEF FPC}
+ SysUtils
+ {$ELSE}
+ System.SysUtils
+ {$ENDIF}
 ;
 
-type
-{ TWeatherStation }
-PWeatherStation = ^TWeatherStation;
-TWeatherStation = record
-  FStation: String[100];
-  FMin: Int64;
-  FMax: Int64;
-  FTot: Int64;
-  FCnt: Integer;
-
-end;
-{ TBaseline }
-  TBaseline = class(TObject)
-  private
-    FInputFile: String;
-    FStationNames: TStringList;
-    FHashStationList: TFPHashList;
-    procedure AddToHashList(AStation: String; ATemp: Int64);
-    procedure BuildHashList;
-    function RoundEx(x: Currency): Double;
-  protected
-  public
-    constructor Create(AInputFile: String);
-    destructor Destroy; override;
-
-    procedure Generate;
-  published
-  end;
-
-  {$IFNDEF FPC}
-  TStringArray = array of Utf8String;
-  TWriteBufStream = TFileStream;
-  {$ENDIF}
+function RoundExDouble(const ATemp: Double): Double;
+function RoundExInteger(const ATemp: Double): Integer;
 
 implementation
 
-uses
-  Math
-{$IFDEF FPC}
-, streamex
-{$ELSE}
-, System.Diagnostics 
-{$IF defined(MSWINDOWS)}, Winapi.Windows{$ENDIF}
-{$ENDIF}
-;
-
-const
-  //lineEnding = #13#10;
-  stationsCapacity = 50000;
-
-
-function Compare(AList: TStringList; AIndex1, AIndex2: Integer): Integer;
-var
-  Pos1, Pos2: Integer;
-  Str1, Str2: String;
-begin
-  Result := 0;
-  Str1 := AList.Strings[AIndex1];
-  Str2 := AList.Strings[AIndex2];
-  Pos1 := Pos('=', Str1);
-  Pos2 := Pos('=', Str2);
-  if (Pos1 > 0) and (Pos2 > 0) then
-  begin
-    Str1 := Copy(Str1, 1, Pos1 - 1);
-    Str2 := Copy(Str2, 1, Pos2 - 1);
-    Result :=  CompareStr(Str1, Str2);
-  end;
-end;
-
-{ TBaseline }
-
-constructor TBaseline.Create(AInputFile: String);
-begin
-  FInputFile := AInputFile;
-
-  FHashStationList:= TFPHashList.Create;
-  FHashStationList.Capacity:= stationsCapacity;
-
-  FStationNames := TStringList.Create;
-  FStationNames.Capacity := stationsCapacity;
-  FStationNames.UseLocale := False;
-end;
-
-destructor TBaseline.Destroy;
-var
-  index: Integer;
-begin
-  FStationNames.Free;
-  for index:= 0 to FHashStationList.Count - 1 do
-  begin
-    Dispose(PWeatherStation(FHashStationList.Items[index]));
-  end;
-  FHashStationList.Free;
-  inherited Destroy;
-end;
-
-procedure TBaseline.AddToHashList(AStation: String; ATemp: Int64);
-var
-  weatherStation: PWeatherStation;
-  Index: Integer;
+function Ceiling(const ANumber: Double): integer; inline;
 begin
-  Index := FHashStationList.FindIndexOf(AStation);
-  if Index = -1 then
-  begin
-    New(weatherStation);
-    weatherStation^.FStation := AStation;
-    weatherStation^.FMin := ATemp;
-    weatherStation^.FMax := ATemp;
-    weatherStation^.FTot := ATemp;
-    weatherStation^.FCnt := 1;
-    FHashStationList.Add(AStation, weatherStation);
-  end
-  else
-  begin
-    weatherStation := FHashStationList.Items[Index];
-    weatherStation^.FMin := Min(weatherStation^.FMin, ATemp);
-    weatherStation^.FMax := Max(weatherStation^.FMax, ATemp);
-    weatherStation^.FTot := weatherStation^.FTot + ATemp;
-    weatherStation^.FCnt := weatherStation^.FCnt + 1;
-  end;
+  Result := Trunc(ANumber) + Ord(Frac(ANumber) > 0);
 end;
 
-procedure TBaseline.BuildHashList;
+function RoundExDouble(const ATemp: Double): Double; inline;
 var
-  inputFileStream: TFileStream;
-  streamReader: TStreamReader;
-  position, Code: Integer;
-  strLine: String;
-  strStation: String;
-  strTemp: String;
-  temparature: Int64;
-begin
-  if FileExists(FInputFile) then
-  begin
-    inputFileStream:= TFileStream.Create(FInputFile, fmOpenRead);
-    try
-      streamReader:= TStreamReader.Create(inputFileStream);
-      try
-        while not streamReader.Eof do
-        begin
-          strLine:= streamReader.ReadLine;
-          position := Pos(';', strLine);
-          if position > 0 then
-          begin
-            strStation := Copy(strLine, 1, position - 1);
-            strTemp := Copy(strLine, position + 1, Length(strLine));
-            strTemp := StringReplace(strTemp, '.', '', [rfReplaceAll]);
-            Val(strTemp, temparature, Code);
-            if Code <> 0 then
-              Continue;
-            AddToHashList(strStation, temparature);
-          end;
-        end;
-      finally
-        streamReader.Free;
-      end;
-    finally
-      inputFileStream.Free;
-    end;
-  end
-  else
-  begin
-    raise Exception.Create(Format('File "%s" not found.', [FInputFile]));
-  end;
-end;
-
-function TBaseline.RoundEx(x: Currency): Double;
+  tmp: Double;
 begin
-  Result := Ceil(x * 10) / 10;
+  tmp:= ATemp * 10;
+  Result := Ceiling(tmp) / 10;
 end;
 
-procedure TBaseline.Generate;
+function RoundExInteger(const ATemp: Double): Integer; inline;
 var
-  index: Integer;
-  strTemp: String;
-  min: Double;
-  max: Double;
-  mean: Double;
-  weatherStation: PWeatherStation;
+  tmp: Double;
 begin
-
-  BuildHashList;
-
-  FStationNames.BeginUpdate;
-  for index := 0 to FHashStationList.Count - 1 do
-  begin
-    weatherStation := FHashStationList.Items[index];
-    Min := RoundEx(weatherStation^.FMin/10);
-    Max := RoundEx(weatherStation^.FMax/10);
-    Mean := RoundEx(weatherStation^.FTot/weatherStation^.FCnt/10);
-    strTemp := weatherStation^.FStation + '=' + FormatFloat('0.0', Min) + '/' + FormatFloat('0.0', Mean) + '/' + FormatFloat('0.0', Max) + ',';
-    FStationNames.Add(strTemp);
-  end;
-  FStationNames.EndUpdate;
-  FStationNames.CustomSort(@Compare);
-
-  strTemp:= '';
-  for index:= 0 to FStationNames.Count - 1 do
-  begin
-    strTemp:= strTemp + FStationNames[index] + ' ';
-  end;
-  SetLength(strTemp, Length(strTemp) - 2);
-  WriteLn('{', strTemp, '}');
-
+  tmp:= ATemp * 10;
+  Result := Ceiling(tmp);
 end;
 
 end.