refactor: Change output sort from TStringList to using TStringComparer

Author: corneliusdavid

entries/dcornelius/src/uChallengeCommon.pas

@@ -20,7 +20,7 @@   TWeatherCity = class
     constructor Create(const NewCityName: string; const NewTemp: Integer);
     procedure AddNewTemp(const NewTemp: Integer);
     function Mean: Double;
-    function OutputSumLine: string;
+    function OutputSumLine(const FirstOutput: Boolean): string;
   end;
 
   // anonymous method type
@@ -169,13 +169,17 @@ function TWeatherCity.Mean: Double;
   Result := ChallengeCommon.PascalRound(TotalTemp / DataCount);
 end;
 
-function TWeatherCity.OutputSumLine: string;
+function TWeatherCity.OutputSumLine(const FirstOutput: Boolean): string;
 begin
-  Result := Format(' %s=%0.1f/%0.1f/%0.1f', [CityName,
-                                             MinTemp / 10,
-                                             Mean,
-                                             MaxTemp / 10]);
+  if FirstOutput then
+    Result := ''
+  else
+    Result := ', ';
 
+  Result := Result + Format('%s=%0.1f/%0.1f/%0.1f', [CityName,
+                                                     MinTemp / 10,
+                                                     Mean,
+                                                     MaxTemp / 10]);
 end;
 
 end.

entries/dcornelius/src/uChallengeWithDictionary.pas

@@ -16,7 +16,7 @@ procedure ChallengeWithDictionary;
 implementation
 
 uses
-  System.Classes, System.SysUtils, System.Generics.Collections, System.StrUtils,
+  System.Classes, System.SysUtils, System.Generics.Collections, System.StrUtils, System.Generics.Defaults,
   uChallengeCommon;
 
 type
@@ -27,8 +27,9 @@ implementation
 
 procedure ChallengeWithDictionary;
 var
-  SortedList: TStringList;
+  CityArray: TArray<string>;
   CurrWeatherCity: TWeatherCity;
+  FirstOutput: Boolean;
 begin
   WeatherCityList := TDictionary<string, TWeatherCity>.Create;
   try
@@ -41,18 +42,16 @@ procedure ChallengeWithDictionary;
       end);
 
       // create the output list
-      SortedList := TStringList.Create(TDuplicates.dupAccept, False, True);
-      try
-        for var WeatherSum in WeatherCityList do
-          SortedList.Append(WeatherSum.Value.OutputSumLine);
-
-        // sort and write out the data
-        SortedList.Sort;
-        SortedList.QuoteChar := #0;
-        Writeln('{', Trim(SortedList.DelimitedText), '}');
-      finally
-        SortedList.Free;
+      CityArray := WeatherCityList.Keys.ToArray;
+      TArray.Sort<string>(CityArray, TStringComparer.Ordinal);
+      FirstOutput := True;
+      Write('{');
+      for var City in CityArray do
+      begin
+        Write(WeatherCityList.Items[City].OutputSumLine(FirstOutput));
+        FirstOutput := False;
       end;
+      Writeln('}');
       {$IFDEF DEBUG}
       Writeln('Unique Stations: ', WeatherCityList.Count);
       {$ENDIF}

entries/dcornelius/src/uChallengeWithStringList.pas

@@ -74,9 +74,9 @@ procedure ChallengeWithStringList;
       SortedList.Sort;
 
       Write('{');
-      Write(Trim(TWeatherCity(SortedList.Objects[0]).OutputSumLine));
+      Write(Trim(TWeatherCity(SortedList.Objects[0]).OutputSumLine(True)));
       for var i := 1 to SortedList.Count - 1 do
-        Write(TWeatherCity(SortedList.Objects[i]).OutputSumLine);
+        Write(TWeatherCity(SortedList.Objects[i]).OutputSumLine(False));
       Writeln('}');
       {$IFDEF DEBUG}
       Writeln('Unique Stations: ', SortedList.Count);