Revert parseXmlAsync method back to original signature

Author: TCourtneyOwen

packages/office-addin-manifest/src/manifestInfo.ts

@@ -57,11 +57,11 @@ async function modifyManifestXml(manifestPath: string, guid?: string, displayNam
   }
 }
 
-async function parseXmlAsync(xmlString: string): Promise<Xml> {
+async function parseXmlAsync(xmlString: string, manifestPath: string): Promise<Xml> {
   return new Promise(async function(resolve, reject) {
     xml2js.parseString(xmlString, function(parseError, xml) {
       if (parseError) {
-        reject(new Error(`Unable to parse the xml for manifest file:\n${parseError}`));
+        reject(new Error(`Unable to parse the manifest file: ${manifestPath}. \n${parseError}`));
       } else {
         resolve(xml);
       }
@@ -81,7 +81,7 @@ export async function readManifestFile(manifestPath: string): Promise<ManifestIn
 
 async function readXmlFromManifestFile(manifestPath: string): Promise<Xml> {
   const fileData: string = await readFileAsync(manifestPath, {encoding: "utf8"});
-  const xml = await parseXmlAsync(fileData);
+  const xml = await parseXmlAsync(fileData, manifestPath);
   return xml;
 }
 

packages/office-addin-manifest/test/test.ts

@@ -28,7 +28,7 @@ describe("Manifest", function() {
         } catch (err) {
           result = err;
         }
-        assert.equal(result.message, "Unable to parse the xml for manifest file:\nError: Unexpected close tag\nLine: 8\nColumn: 46\nChar: >");
+        assert.equal(result.message, "Unable to parse the manifest file: test/manifests/manifest.incorrect-end-tag.xml. \nError: Unexpected close tag\nLine: 8\nColumn: 46\nChar: >");
     });
     it("should handle a missing description", async function() {
       const info = await manifestInfo.readManifestFile("test/manifests/manifest.no-description.xml");