Incorporate latest suggestions from PR

Author: TCourtneyOwen

packages/office-addin-manifest/src/manifestInfo.ts

@@ -97,7 +97,7 @@ async function writeManifestData(manifestPath: string, manifestData: any): Promi
   }
 
   try {
-    // Write modified xml back to the manifest.
+    // Write the xml back to the manifest file.
     await writeFileAsync(manifestPath, xml);
     } catch (err) {
       throw new Error(`Unable to write to file. ${manifestPath} \n${err}`);

packages/office-addin-manifest/src/xml.ts

@@ -1,8 +1,8 @@
-// reading xml values is resilient to errors but you can uncomment the next line for debugging if attributes are missing
 export function getXmlAttributeValue(xml: any, name: string): string | undefined {
     try {
       return xml.$[name];
     } catch (err) {
+      // reading xml values is resilient to errors but you can uncomment the next line for debugging if attributes are missing
       // console.error(`Unable to get xml attribute value "${name}". ${err}`);
     }
   }
@@ -14,7 +14,6 @@ export function getXmlElementAttributeValue(xml: any, elementName: string, attri
   }
 }
 
-// reading xml values is resilient to errors but you can uncomment the next line for debugging if elements are missing
 export function getXmlElementValue(xml: any, name: string): string | undefined {
   try {
     const element = xml[name];
@@ -23,29 +22,15 @@ export function getXmlElementValue(xml: any, name: string): string | undefined {
       return element[0];
     }
   } catch (err) {
-      // console.error(`Unable to get xml element value "${name}". ${err}`);
+    // reading xml values is resilient to errors but you can uncomment the next line for debugging if elements are missing
+    // console.error(`Unable to get xml element value "${name}". ${err}`);
     }
   }
 
 export function setXmlElementValue(xml: any, elementName: string, input: any) {
-  const element = getXmlElementValue(xml, elementName);
-
-  if (element) {
-  try {
-    xml[elementName] = input;
-    } catch (err) {
-      console.error(`Unable to write value to xml element: ${err}`);
-    }
-  return xml;
-  }
+  xml[elementName] = input;
 }
 
 export function setElementAttributeValue(xml: any, elementName: string, input: string | undefined, attributeName: string = "DefaultValue") {
-  const element = getXmlElementValue(xml, elementName);
-
-  if (element) {
-    try {
-      xml[elementName][0].$[attributeName] = input;
-    } catch (err) { console.error(`Unable to write value to xml attribute: ${err}`); }
-  }
+  xml[elementName][0].$[attributeName] = input;
 }

packages/office-addin-manifest/test/test.ts

@@ -84,6 +84,7 @@ describe("Manifest", function() {
 
       // verify displayName updated and guid not updated
       assert.notStrictEqual(originalInfo.displayName, updatedInfo.displayName);
+      assert.strictEqual(updatedInfo.displayName, testDisplayName);
       assert.strictEqual(originalInfo.id, updatedInfo.id);
     });
     it("should handle not specifying either a guid or displayName", async function() {