Merge branch 'bugfix/Attributes-IsDirty' into release/5.1.0

If a topic is loaded in the OnTopic Editor and immediately saved without making changes, then no updates to the database should be made. In practice, however, the `LastModified` and `LastModifiedBy` attributes were getting saved in this scenario. This was due to two bugs. The first is because of a string comparison issue in the underlying `TrackedRecordCollection<>.SetValue()` used to compare attribute values; this was fixed in OnTopic 5.1.0 RC1 (OnTopicCMS/OnTopic-Library#86, f354499). The second was an issue with CRLFs (`\r\n`) getting reduced to line feeds (`\n`) in SQL's XML column, and thus mismatching form submissions which still contained CRLFs for line breaks; this was fixed by cleaning the `AttributeBindingModel.Value` before setting it via `Topic.Attributes.SetValue()` (e10c666). Together, these resolve #48.

Author: JeremyCaney

OnTopic.Editor.AspNetCore.Attributes/OnTopic.Editor.AspNetCore.Attributes.csproj

@@ -25,7 +25,7 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="OnTopic" Version="5.1.0-beta.0" />
+    <PackageReference Include="OnTopic" Version="5.1.0-rc.1" />
   </ItemGroup>
 
   <ItemGroup>

OnTopic.Editor.AspNetCore.Host/OnTopic.Editor.AspNetCore.Host.csproj

@@ -11,8 +11,8 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="OnTopic.Data.Caching" Version="5.1.0-beta.0" />
-    <PackageReference Include="OnTopic.Data.Sql" Version="5.1.0-beta.0" />
+    <PackageReference Include="OnTopic.Data.Caching" Version="5.1.0-rc.1" />
+    <PackageReference Include="OnTopic.Data.Sql" Version="5.1.0-rc.1" />
     <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" Version="5.0.5" />
   </ItemGroup>
 

OnTopic.Editor.AspNetCore/Controllers/EditorController.cs

@@ -444,7 +444,8 @@ public async Task<IActionResult> Edit(
           topic.Attributes.SetValue(attribute.Key, attribute.DefaultValue);
         }
         else {
-          topic.Attributes.SetValue(attribute.Key, attributeValue.Value);
+          var value = attributeValue.Value?.Replace("\r\n", "\n", StringComparison.Ordinal);
+          topic.Attributes.SetValue(attribute.Key, value);
         }
 
       }

OnTopic.Editor.AspNetCore/OnTopic.Editor.AspNetCore.csproj

@@ -24,9 +24,9 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="OnTopic" Version="5.1.0-beta.0" />
+    <PackageReference Include="OnTopic" Version="5.1.0-rc.1" />
     <PackageReference Include="OnTopic.Data.Transfer" Version="2.0.0" />
-    <PackageReference Include="OnTopic.AspNetCore.Mvc" Version="5.1.0-beta.0" />
+    <PackageReference Include="OnTopic.AspNetCore.Mvc" Version="5.1.0-rc.1" />
   </ItemGroup>
 
 </Project>