Handled potential passing of null reference to Load()

JeremyCaney · JeremyCaney · commit 64afeb9fa094 · 2021-04-06T17:11:59.000-07:00
Better to check if `attribute.RootTopic` is `null` upfront.
diff --git a/OnTopic.Editor.AspNetCore.Attributes/TopicListAttribute/TopicListViewComponent.cs b/OnTopic.Editor.AspNetCore.Attributes/TopicListAttribute/TopicListViewComponent.cs
@@ -95,8 +95,8 @@ public IViewComponentResult Invoke(
           _ => baseTopic
         };
       }
-      else {
-        rootTopic = _topicRepository.Load(attribute.RootTopic?.UniqueKey);
+      else if (attribute.RootTopic is not null) {
+        rootTopic = _topicRepository.Load(attribute.RootTopic.UniqueKey);
       }
 
       if (rootTopic is not null && !String.IsNullOrEmpty(attribute.RelativeTopicPath)) {

Original file line number	Diff line number	Diff line change
`@@ -95,8 +95,8 @@ public IViewComponentResult Invoke(`
`95`	`95`	`_ => baseTopic`
`96`	`96`	`};`
`97`	`97`	`}`
`98`		`- else {`
`99`		`- rootTopic = _topicRepository.Load(attribute.RootTopic?.UniqueKey);`
	`98`	`+ else if (attribute.RootTopic is not null) {`
	`99`	`+ rootTopic = _topicRepository.Load(attribute.RootTopic.UniqueKey);`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`if (rootTopic is not null && !String.IsNullOrEmpty(attribute.RelativeTopicPath)) {`