Merge branch 'bugfix/SelectableTreeView' into develop

Previously, there was a bug where multiple instances of a `SelectableTreeView` on a single page would not work correctly. This occurred, for instance, when multiple relationship attributes were defined for a single Content Type (either directly, or via attribute inheritance). While this scenario is rare, it should be supported. In this case, only the data from the first tree would render—but it would be associated with the attribute and backing field of the last tree, which made this bug especially confusing and potentially problematic in terms of data integrity.

This was ultimately caused by the `root` node being stored as part of the `OnTopic.SelectableTreeView.defaults` object, which is shared between multiple instances. By moving the creation of a new `AsyncTreeNode` object for the root into the `OnTopic.SelectableTreeView` constructor, this is mitigated, and multiple `SelectableTreeView` instances can once again live peacefully on one topic.

This resolves Issue #6.

Author: JeremyCaney

OnTopic.Editor.AspNetCore/Areas/Editor/Views/Editor/Components/TopicReference/Default.cshtml

@@ -17,7 +17,8 @@
 }
 
 <vc:tokenized-topic-list
-  current-topic=@Model.CurrentTopic
-  html-field-prefix=@ViewData.TemplateInfo.HtmlFieldPrefix
-  attribute=@attributeDescriptor>
+  current-topic                 =@Model.CurrentTopic
+  html-field-prefix             =@ViewData.TemplateInfo.HtmlFieldPrefix
+  attribute                     =@attributeDescriptor
+  >
 </vc:tokenized-topic-list>

OnTopic.Editor.AspNetCore/Shared/Scripts/DraggableTreeView.js

@@ -50,8 +50,8 @@ OnTopic.DraggableTreeView = Ext.extend(Ext.tree.TreePanel, {
     | Move on server
     \-------------------------------------------------------------------------------------------------------------------------*/
     $.ajax({
-      method: "POST",
-      url: "/OnTopic/Move",
+      method                    : "POST",
+      url                       : "/OnTopic/Move",
       data: {
         topicId                 : node.attributes.id,
         targetTopicId           : newParent.attributes.id,

OnTopic.Editor.AspNetCore/Shared/Scripts/SelectableTreeView.js

@@ -61,6 +61,16 @@ OnTopic.SelectableTreeView = Ext.extend(Ext.tree.TreePanel, {
     \-------------------------------------------------------------------------------------------------------------------------*/
     Ext.apply(this, options, OnTopic.SelectableTreeView.defaults);
 
+    /*--------------------------------------------------------------------------------------------------------------------------
+    | Initialize root
+    \-------------------------------------------------------------------------------------------------------------------------*/
+    this.root = new Ext.tree.AsyncTreeNode({
+      checked                   : true,
+      text                      : 'Web',
+      draggable                 : false,
+      leaf                      : false
+    });
+
     /*--------------------------------------------------------------------------------------------------------------------------
     | Initialize variables
     \-------------------------------------------------------------------------------------------------------------------------*/
@@ -100,20 +110,12 @@ OnTopic.SelectableTreeView = Ext.extend(Ext.tree.TreePanel, {
 | DEFAULTS
 \-----------------------------------------------------------------------------------------------------------------------------*/
 OnTopic.SelectableTreeView.defaults = {
-  id                            : 'relatedTree',
   useArrows                     : true,
   autoScroll                    : true,
   animate                       : true,
   enableDD                      : false,
   containerScroll               : true,
   border                        : false,
   baseCls                       : 'RelationshipsTreeView',
-  root                          : new Ext.tree.AsyncTreeNode({
-    checked                     : true,
-    text                        : 'Web',
-    draggable                   : false,
-    id                          : 'related',
-    leaf                        : false
-  }),
   rootVisible                   : false
 };