Merge branch 'improvement/IsProtected-reordering' into develop

Updated the drag-and-drop validation logic within the `DraggableTreeView` JavaScript component to allow notes marked as `IsProtected` or assigned to a `ContentTypeDescriptor` marked with `DisableDelete` to be _reordered_ but not _moved_. As part of this, I renamed the property on the `QueryResultTopicViewModel` from `IsDraggable` (`draggable`) to `IsMovable` (`movable`). This completes the implementation of #45.

Author: JeremyCaney

OnTopic.Editor.AspNetCore/Models/Queryable/QueryResultTopicViewModel.cs

@@ -36,7 +36,7 @@ public QueryResultTopicViewModel(
       string                    uniqueKey,
       string                    webPath,
       bool?                     isChecked                       = null,
-      bool                      isDraggable                     = true,
+      bool                      isMovable                       = true,
       bool                      isExpanded                      = false
     ) {
 
@@ -48,7 +48,7 @@ public QueryResultTopicViewModel(
       Title                     = title;
       UniqueKey                 = uniqueKey;
       WebPath                   = webPath;
-      IsDraggable               = isDraggable;
+      IsMovable                 = isMovable;
       IsExpanded                = isExpanded;
 
       if (isChecked.HasValue) {
@@ -121,14 +121,14 @@ public bool? IsChecked {
     }
 
     /*==========================================================================================================================
-    | IS DRAGGABLE?
+    | IS MOVABLE?
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
-    ///   Determines whether the current topic is intended to be draggable or not.
+    ///   Determines whether the current topic is permitted to be movable or not.
     /// </summary>
-    [JsonPropertyName("draggable")]
+    [JsonPropertyName("isMovable")]
     [DefaultValue(true)]
-    public bool IsDraggable {
+    public bool IsMovable {
       get;
     }
 

OnTopic.Editor.AspNetCore/Shared/Scripts/DraggableTreeView.js

@@ -29,8 +29,10 @@ OnTopic.DraggableTreeView = Ext.extend(Ext.tree.TreePanel, {
   /*============================================================================================================================
   | METHOD: VALIDATE SOURCE TOPIC
   \---------------------------------------------------------------------------------------------------------------------------*/
-  validateSourceTopic           : function(tree, node, event) {
-    node.draggable              = (node.attributes.draggable == 'false');
+  validateSourceTopic: function (e) {
+    if (!e.dropNode.attributes.isMovable && e.dropNode.parentNode.attributes.path !== e.target.parentNode.attributes.path) {
+      e.cancel = true;
+    }
   },
 
   /*============================================================================================================================
@@ -124,7 +126,7 @@ OnTopic.DraggableTreeView = Ext.extend(Ext.tree.TreePanel, {
     \-------------------------------------------------------------------------------------------------------------------------*/
     var me = this;
 
-    me.on('startdrag',          me.validateSourceTopic,         this);
+    me.on('nodedragover',       me.validateSourceTopic,         this);
     me.on('movenode',           me.moveTopic,                   this);
 
   }