Skip to content

Commit be0b76c

Browse files
committed
Revert: Renamed AttributeDictionary to AttributeValueDictionary
The latest patch renamed `AttributeValueDictionary` back to `AttributeDictionary`, thus reverting a large part of the previous patch (b243853). It seems this decision was premature, though, as we can mitigate the naming conflicts without renaming the class, since the out-of-the-box `ViewFeatures` namespace is almost exclusively used in views, and the `AttributeDictionary` is almost exclusively used in view models. This effectively undoes 1ca4eb4 and OnTopicCMS/OnTopic-Library#107.
1 parent 78b0463 commit be0b76c

24 files changed

Lines changed: 50 additions & 49 deletions

File tree

OnTopic.Editor.AspNetCore.Attributes/BooleanAttribute/BooleanAttributeDescriptorViewModel.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ public record BooleanAttributeDescriptorViewModel: AttributeDescriptorViewModel
2020
/// <summary>
2121
/// Initializes a new <see cref="BooleanAttributeDescriptorViewModel"/> with an <paramref name="attributes"/> dictionary.
2222
/// </summary>
23-
/// <param name="attributes">An <see cref="AttributeValueDictionary"/> of attribute values.</param>
24-
public BooleanAttributeDescriptorViewModel(AttributeValueDictionary attributes): base(attributes) { }
23+
/// <param name="attributes">An <see cref="AttributeDictionary"/> of attribute values.</param>
24+
public BooleanAttributeDescriptorViewModel(AttributeDictionary attributes): base(attributes) { }
2525

2626
/// <summary>
2727
/// Initializes a new instance of the <see cref="BooleanAttributeDescriptorViewModel"/> class.

OnTopic.Editor.AspNetCore.Attributes/DateTimeAttribute/DateTimeAttributeDescriptorViewModel.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ public record DateTimeAttributeDescriptorViewModel: AttributeDescriptorViewModel
2020
/// <summary>
2121
/// Initializes a new <see cref="DateTimeAttributeDescriptorViewModel"/> with an <paramref name="attributes"/> dictionary.
2222
/// </summary>
23-
/// <param name="attributes">An <see cref="AttributeValueDictionary"/> of attribute values.</param>
24-
public DateTimeAttributeDescriptorViewModel(AttributeValueDictionary attributes): base(attributes) {
23+
/// <param name="attributes">An <see cref="AttributeDictionary"/> of attribute values.</param>
24+
public DateTimeAttributeDescriptorViewModel(AttributeDictionary attributes): base(attributes) {
2525
Contract.Requires(attributes, nameof(attributes));
2626
IncludeDatePicker = attributes.GetBoolean(nameof(IncludeDatePicker));
2727
IncludeTimePicker = attributes.GetBoolean(nameof(IncludeTimePicker));

OnTopic.Editor.AspNetCore.Attributes/FileListAttribute/FileListAttributeDescriptorViewModel.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ public record FileListAttributeDescriptorViewModel: AttributeDescriptorViewModel
2020
/// <summary>
2121
/// Initializes a new <see cref="FileListAttributeDescriptorViewModel"/> with an <paramref name="attributes"/> dictionary.
2222
/// </summary>
23-
/// <param name="attributes">An <see cref="AttributeValueDictionary"/> of attribute values.</param>
24-
public FileListAttributeDescriptorViewModel(AttributeValueDictionary attributes): base(attributes) {
23+
/// <param name="attributes">An <see cref="AttributeDictionary"/> of attribute values.</param>
24+
public FileListAttributeDescriptorViewModel(AttributeDictionary attributes): base(attributes) {
2525
Contract.Requires(attributes, nameof(attributes));
2626
Path = attributes.GetValue(nameof(Path));
2727
Extension = attributes.GetValue(nameof(Extension));

OnTopic.Editor.AspNetCore.Attributes/FilePathAttribute/FilePathAttributeDescriptorViewModel.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ public record FilePathAttributeDescriptorViewModel: AttributeDescriptorViewModel
2020
/// <summary>
2121
/// Initializes a new <see cref="FilePathAttributeDescriptorViewModel"/> with an <paramref name="attributes"/> dictionary.
2222
/// </summary>
23-
/// <param name="attributes">An <see cref="AttributeValueDictionary"/> of attribute values.</param>
24-
public FilePathAttributeDescriptorViewModel(AttributeValueDictionary attributes): base(attributes) {
23+
/// <param name="attributes">An <see cref="AttributeDictionary"/> of attribute values.</param>
24+
public FilePathAttributeDescriptorViewModel(AttributeDictionary attributes): base(attributes) {
2525
Contract.Requires(attributes, nameof(attributes));
2626
InheritValue = attributes.GetBoolean(nameof(InheritValue))?? InheritValue;
2727
RelativeToTopicPath = attributes.GetBoolean(nameof(RelativeToTopicPath))?? RelativeToTopicPath;

OnTopic.Editor.AspNetCore.Attributes/HtmlAttribute/HtmlAttributeDescriptorViewModel.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ public record HtmlAttributeDescriptorViewModel: TextAreaAttributeDescriptorViewM
2121
/// <summary>
2222
/// Initializes a new <see cref="HtmlAttributeDescriptorViewModel"/> with an <paramref name="attributes"/> dictionary.
2323
/// </summary>
24-
/// <param name="attributes">An <see cref="AttributeValueDictionary"/> of attribute values.</param>
25-
public HtmlAttributeDescriptorViewModel(AttributeValueDictionary attributes): base(attributes) {
24+
/// <param name="attributes">An <see cref="AttributeDictionary"/> of attribute values.</param>
25+
public HtmlAttributeDescriptorViewModel(AttributeDictionary attributes): base(attributes) {
2626
Contract.Requires(attributes, nameof(attributes));
2727
Height = attributes.GetInteger(nameof(Height));
2828
Rows = 20;

OnTopic.Editor.AspNetCore.Attributes/IncomingRelationshipAttribute/IncomingRelationshipAttributeDescriptorViewModel.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ public record IncomingRelationshipAttributeDescriptorViewModel: QueryableTopicLi
2424
/// Initializes a new <see cref="IncomingRelationshipAttributeDescriptorViewModel"/> with an <paramref name="attributes"/>
2525
/// dictionary.
2626
/// </summary>
27-
/// <param name="attributes">An <see cref="AttributeValueDictionary"/> of attribute values.</param>
28-
public IncomingRelationshipAttributeDescriptorViewModel(AttributeValueDictionary attributes): base(attributes) {
27+
/// <param name="attributes">An <see cref="AttributeDictionary"/> of attribute values.</param>
28+
public IncomingRelationshipAttributeDescriptorViewModel(AttributeDictionary attributes): base(attributes) {
2929
Contract.Requires(attributes, nameof(attributes));
3030
RelationshipKey = attributes.GetValue(nameof(RelationshipKey));
3131
}

OnTopic.Editor.AspNetCore.Attributes/InstructionAttribute/InstructionAttributeDescriptorViewModel.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ public record InstructionAttributeDescriptorViewModel: AttributeDescriptorViewMo
2121
/// Initializes a new <see cref="InstructionAttributeDescriptorViewModel"/> with an <paramref name="attributes"/>
2222
/// dictionary.
2323
/// </summary>
24-
/// <param name="attributes">An <see cref="AttributeValueDictionary"/> of attribute values.</param>
25-
public InstructionAttributeDescriptorViewModel(AttributeValueDictionary attributes): base(attributes) {
24+
/// <param name="attributes">An <see cref="AttributeDictionary"/> of attribute values.</param>
25+
public InstructionAttributeDescriptorViewModel(AttributeDictionary attributes): base(attributes) {
2626
Contract.Requires(attributes, nameof(attributes));
2727
Instructions = attributes.GetValue(nameof(Instructions));
2828
}

OnTopic.Editor.AspNetCore.Attributes/LastModifiedAttribute/LastModifiedAttributeDescriptorViewModel.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ public record LastModifiedAttributeDescriptorViewModel: AttributeDescriptorViewM
2121
/// Initializes a new <see cref="LastModifiedAttributeDescriptorViewModel"/> with an <paramref name="attributes"/>
2222
/// dictionary.
2323
/// </summary>
24-
/// <param name="attributes">An <see cref="AttributeValueDictionary"/> of attribute values.</param>
25-
public LastModifiedAttributeDescriptorViewModel(AttributeValueDictionary attributes): base(attributes) { }
24+
/// <param name="attributes">An <see cref="AttributeDictionary"/> of attribute values.</param>
25+
public LastModifiedAttributeDescriptorViewModel(AttributeDictionary attributes): base(attributes) { }
2626

2727
/// <summary>
2828
/// Initializes a new instance of the <see cref="LastModifiedAttributeDescriptorViewModel"/> class.

OnTopic.Editor.AspNetCore.Attributes/LastModifiedByAttribute/LastModifiedByAttributeDescriptorViewModel.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ public record LastModifiedByAttributeDescriptorViewModel: AttributeDescriptorVie
2121
/// Initializes a new <see cref="LastModifiedByAttributeDescriptorViewModel"/> with an <paramref name="attributes"/>
2222
/// dictionary.
2323
/// </summary>
24-
/// <param name="attributes">An <see cref="AttributeValueDictionary"/> of attribute values.</param>
25-
public LastModifiedByAttributeDescriptorViewModel(AttributeValueDictionary attributes): base(attributes) { }
24+
/// <param name="attributes">An <see cref="AttributeDictionary"/> of attribute values.</param>
25+
public LastModifiedByAttributeDescriptorViewModel(AttributeDictionary attributes): base(attributes) { }
2626

2727
/// <summary>
2828
/// Initializes a new instance of the <see cref="LastModifiedByAttributeDescriptorViewModel"/> class.

OnTopic.Editor.AspNetCore.Attributes/MetadataListAttribute/MetadataListAttributeDescriptorViewModel.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ public record MetadataListAttributeDescriptorViewModel: TopicListAttributeDescri
2121
/// <summary>
2222
/// Initializes a new <see cref="MetadataListAttributeDescriptorViewModel"/> with an <paramref name="attributes"/> dictionary.
2323
/// </summary>
24-
/// <param name="attributes">An <see cref="AttributeValueDictionary"/> of attribute values.</param>
25-
public MetadataListAttributeDescriptorViewModel(AttributeValueDictionary attributes): base(attributes) {
24+
/// <param name="attributes">An <see cref="AttributeDictionary"/> of attribute values.</param>
25+
public MetadataListAttributeDescriptorViewModel(AttributeDictionary attributes): base(attributes) {
2626
RelativeTopicPath = "LookupList";
2727
}
2828

0 commit comments

Comments
 (0)