Merge branch 'bugfix/AttributeDictionary-constructors' into develop

Picked up a few gaps from the original `AttributeDictionary` constructors (e3a1b7), such as a missing property assignment, and an attribute view model without a `AttributeDictionary` constructor. Additionally provided some minor cleanup, such as removing empty constructors where they aren't needed, removing some extraneous comment headers, and fixing some alignment issues in the code.

Author: JeremyCaney

OnTopic.Editor.AspNetCore.Attributes/MetadataListAttribute/MetadataListAttributeDescriptorViewModel.cs

@@ -30,12 +30,7 @@ public MetadataListAttributeDescriptorViewModel(AttributeDictionary attributes):
     ///   Initializes a new instance of a <see cref="MetadataListAttributeDescriptorViewModel"/>
     /// </summary>
     public MetadataListAttributeDescriptorViewModel(): base() {
-
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Customize values
-      \-----------------------------------------------------------------------------------------------------------------------*/
       RelativeTopicPath         = "LookupList";
-
     }
 
   } //Class

OnTopic.Editor.AspNetCore.Attributes/NumberAttribute/NumberAttributeDescriptorViewModel.cs

@@ -25,6 +25,7 @@ public record NumberAttributeDescriptorViewModel: AttributeDescriptorViewModel {
     public NumberAttributeDescriptorViewModel(AttributeDictionary attributes): base(attributes) {
       Contract.Requires(attributes, nameof(attributes));
       MinimumValue              = attributes.GetInteger(nameof(MinimumValue))?? MinimumValue;
+      MaximumValue              = attributes.GetInteger(nameof(MaximumValue))?? MaximumValue;
     }
 
     /// <summary>

OnTopic.Editor.AspNetCore.Attributes/RelationshipAttribute/RelationshipAttributeDescriptorViewModel.cs

@@ -18,10 +18,33 @@ public record RelationshipAttributeDescriptorViewModel: QueryableTopicListAttrib
     /*==========================================================================================================================
     | CONSTRUCTOR
     \-------------------------------------------------------------------------------------------------------------------------*/
+    /// <summary>
+    ///   Initializes a new <see cref="RelationshipAttributeDescriptorViewModel"/> with an <paramref name="attributes"/> dictionary.
+    /// </summary>
+    /// <param name="attributes">An <see cref="AttributeDictionary"/> of attribute values.</param>
+    public RelationshipAttributeDescriptorViewModel(AttributeDictionary attributes): base(attributes) {
+      Contract.Requires(attributes, nameof(attributes));
+      ShowRoot                  = attributes.GetBoolean(nameof(ShowRoot));
+      ExpandRelated             = attributes.GetBoolean(nameof(ExpandRelated));
+      CheckAscendants           = attributes.GetBoolean(nameof(CheckAscendants));
+      RegisterResources();
+    }
+
     /// <summary>
     ///   Initializes a new instance of a <see cref="RelationshipAttributeDescriptorViewModel"/>
     /// </summary>
     public RelationshipAttributeDescriptorViewModel() {
+      RegisterResources();
+    }
+
+    /*==========================================================================================================================
+    | REGISTER RESOURCES
+    \-------------------------------------------------------------------------------------------------------------------------*/
+    /// <summary>
+    ///   Derived classes may optionally override this method in order to register resources, as an alternative to setting these
+    ///   in the constructor.
+    /// </summary>
+    protected void RegisterResources() {
       Scripts.Register(GetNamespacedUri("/Shared/Scripts/SelectableTreeView.js"));
     }
 

OnTopic.Editor.AspNetCore.Attributes/TopicListAttribute/TopicListAttributeDescriptorViewModel.cs

@@ -29,7 +29,7 @@ public TopicListAttributeDescriptorViewModel(AttributeDictionary attributes): ba
       DefaultLabel              = attributes.GetValue(nameof(DefaultLabel))?? DefaultLabel;
       RelativeTopicBase         = attributes.GetValue(nameof(RelativeTopicBase));
       RelativeTopicPath         = attributes.GetValue(nameof(RelativeTopicPath));
-      ValueProperty              = attributes.GetValue(nameof(ValueProperty))?? ValueProperty;
+      ValueProperty             = attributes.GetValue(nameof(ValueProperty))?? ValueProperty;
     }
 
     /// <summary>

OnTopic.Editor.AspNetCore.Attributes/TopicReferenceAttribute/TopicReferenceAttributeDescriptorViewModel.cs

@@ -33,12 +33,7 @@ public TopicReferenceAttributeDescriptorViewModel(AttributeDictionary attributes
     ///   Initializes a new instance of a <see cref="TopicReferenceAttributeDescriptorViewModel"/>
     /// </summary>
     public TopicReferenceAttributeDescriptorViewModel(): base() {
-
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Restrict token limit
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      TokenLimit = 1;
-
+      TokenLimit                = 1;
     }
 
     /*==========================================================================================================================

OnTopic.Editor.AspNetCore/Models/Components/ContentTypeListViewModel.cs

@@ -15,14 +15,6 @@ namespace OnTopic.Editor.AspNetCore.Models.Components {
   /// </summary>
   public record ContentTypeListViewModel {
 
-    /*==========================================================================================================================
-    | CONSTRUCTOR
-    \-------------------------------------------------------------------------------------------------------------------------*/
-    /// <summary>
-    ///   Initializes a new instance of the <see cref="ContentTypeListViewModel"/> class.
-    /// </summary>
-    public ContentTypeListViewModel() { }
-
     /*==========================================================================================================================
     | PROPERTY: CURRENT TOPIC
     \-------------------------------------------------------------------------------------------------------------------------*/

OnTopic.Editor.AspNetCore/Models/Metadata/AttributeDescriptorViewModel.cs

@@ -6,6 +6,7 @@
 using System.ComponentModel.DataAnnotations;
 using OnTopic.Attributes;
 using OnTopic.Editor.AspNetCore.Models.ClientResources;
+using OnTopic.Mapping.Annotations;
 
 namespace OnTopic.Editor.AspNetCore.Models.Metadata {
 
@@ -145,6 +146,7 @@ public AttributeDescriptorViewModel(): base() { }
     ///   This is kept separate from <see cref="IsRequired"/> so that the attribute labels can still be marked as required in
     ///   the interface; this should be used to disable <c>required</c> on the associated <c>Value</c> field, however.
     /// </remarks>
+    [DisableMapping]
     public bool IsValueRequired => IsRequired && String.IsNullOrEmpty(DefaultValue);
 
     /*==========================================================================================================================
@@ -169,6 +171,7 @@ public AttributeDescriptorViewModel(): base() { }
     /// <summary>
     ///   Provides a list of client-side stylesheets associated with this <see cref="AttributeDescriptorViewModel"/>.
     /// </summary>
+    [DisableMapping]
     public StyleSheetCollection StyleSheets { get; } = new();
 
     /*==========================================================================================================================
@@ -177,6 +180,7 @@ public AttributeDescriptorViewModel(): base() { }
     /// <summary>
     ///   Provides a list of client-side scripts associated with this <see cref="AttributeDescriptorViewModel"/>.
     /// </summary>
+    [DisableMapping]
     public ScriptCollection Scripts { get; } = new();
 
     /*==========================================================================================================================

OnTopic.Editor.AspNetCore/Models/Metadata/PermittedContentTypeViewModel.cs

@@ -17,14 +17,6 @@ namespace OnTopic.Editor.AspNetCore.Models.Metadata {
   /// </summary>
   public record PermittedContentTypeViewModel {
 
-    /*==========================================================================================================================
-    | CONSTRUCTOR
-    \-------------------------------------------------------------------------------------------------------------------------*/
-    /// <summary>
-    ///   Initializes a new instance of the <see cref="PermittedContentTypeViewModel"/> class.
-    /// </summary>
-    public PermittedContentTypeViewModel(): base() {}
-
     /*==========================================================================================================================
     | PROPERTY: KEY
     \-------------------------------------------------------------------------------------------------------------------------*/