Commit dfe808f
committed
Remove unnecessary and redundant
In the `Move()` action of the `EditorController`, the `topic.Parent` was explicitly being set to the new `target` parent. Not only is this unnecessary and redundant—since the underlying `ITopicRepository.Move()` will handle that—but it also introduces room for bugs since it will appear to `ITopicRepository` that the parent has not changed. I.e., if it compares `topic.Parent` to `target`, they will be the same, thus making it appear as a reordering, not a move. By not setting this in `EditorController`, we give `ITopicRepository` more reliable information, and centralize how this value is updated.topic.Parent setting1 parent eec2f75 commit dfe808f
1 file changed
Lines changed: 0 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
491 | 491 | | |
492 | 492 | | |
493 | 493 | | |
494 | | - | |
495 | | - | |
496 | | - | |
497 | | - | |
498 | | - | |
499 | 494 | | |
500 | 495 | | |
501 | 496 | | |
| |||
0 commit comments