Alter new [dbo].[Topics] columns to be NOT NULL

These columns are initially added as nullable since they don't have a default value. But the script will immediately populate those values, and the result should remove any remaining null values. Once that's done, we can change them to not be nullable, as the final schema expects.

This will not only validate that the previous query functioned properly, but also avoid issues with the auto-generated schema comparison script, since it isn't able to update individual columns if there are existing records.

While I was at it, I cleaned up the formatting of the original script for adding these columns.

Author: JeremyCaney

OnTopic.Data.Sql.Database/Scripts/Upgrade from OnTopic 4 to OnTopic 5.sql

@@ -46,10 +46,10 @@ COLUMN	DateModified;
 -- in a way that's inconsistent with other attributes. By moving them to Topic, we better acknowledge their unique status.
 --------------------------------------------------------------------------------------------------------------------------------
 
-ALTER TABLE [dbo].[Topics]
-    ADD [TopicKey]    VARCHAR (128) NULL,
-        [ContentType] VARCHAR (128) NULL,
-        [ParentID]    INT           NULL;
+ALTER TABLE	[dbo].[Topics]
+ADD	[TopicKey]		VARCHAR(128)	NULL,
+	[ContentType]		VARCHAR(128)	NULL,
+	[ParentID]		INT	NULL;
 
 WITH KeyAttributes AS (
   SELECT	TopicID,
@@ -82,6 +82,12 @@ PIVOT (	MIN(AttributeValue)
 WHERE	RowNumber		= 1
 AND	Topics.TopicID		= Pvt.TopicID
 
+ALTER TABLE	[dbo].[Topics]
+ALTER COLUMN	TopicKey		VARCHAR(128)	NOT NULL;
+
+ALTER TABLE	[dbo].[Topics]
+ALTER COLUMN	ContentType		VARCHAR(128)	NOT NULL;
+
 DELETE
 FROM	Attributes
 WHERE	AttributeKey