Moved duplicate exception to InsertItem()

By overriding `InsertItem()` we ensure that the same `ArgumentException` error is thrown _anytime_ an item is added using e.g. `Add()`, `Insert()`, &c. without needing to add guard conditions to each instance, or worry about members being added independent of construction. The latter isn't an expected use case, but even without that, it prevents the need to duplicate the guard condition for both constructors.

Author: JeremyCaney

Ignia.Topics.Data.Caching/Properties/AssemblyInfo.cs

@@ -21,8 +21,8 @@
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 [assembly: ComVisible(false)]
-[assembly: AssemblyVersion("3.5.1745.0")]
-[assembly: AssemblyFileVersion("3.5.1777.0")]
+[assembly: AssemblyVersion("3.5.1749.0")]
+[assembly: AssemblyFileVersion("3.5.1781.0")]
 [assembly: CLSCompliant(true)]
 [assembly: Guid("206b7f91-ca25-4e9d-9576-60d2e54a2c0a")]
 

Ignia.Topics.Tests/Properties/AssemblyInfo.cs

@@ -21,7 +21,7 @@
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 [assembly: ComVisible(false)]
-[assembly: AssemblyVersion("3.5.1765.0")]
-[assembly: AssemblyFileVersion("3.5.1813.0")]
+[assembly: AssemblyVersion("3.5.1769.0")]
+[assembly: AssemblyFileVersion("3.5.1817.0")]
 [assembly: CLSCompliant(true)]
 [assembly: Guid("27632801-bfe3-41d9-8678-3c4bbe45e6c9")]

Ignia.Topics.ViewModels/Properties/AssemblyInfo.cs

@@ -21,8 +21,8 @@
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 [assembly: ComVisible(false)]
-[assembly: AssemblyVersion("3.5.1746.0")]
-[assembly: AssemblyFileVersion("3.5.1777.0")]
+[assembly: AssemblyVersion("3.5.1750.0")]
+[assembly: AssemblyFileVersion("3.5.1781.0")]
 [assembly: CLSCompliant(true)]
 [assembly: Guid("e52fc633-b4c5-4a2b-8caf-30e756d7a6a7")]
 

Ignia.Topics.Web.Mvc/Properties/AssemblyInfo.cs

@@ -21,7 +21,7 @@
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 [assembly: ComVisible(false)]
-[assembly: AssemblyVersion("3.5.1750.0")]
-[assembly: AssemblyFileVersion("3.5.1782.0")]
+[assembly: AssemblyVersion("3.5.1754.0")]
+[assembly: AssemblyFileVersion("3.5.1786.0")]
 [assembly: CLSCompliant(true)]
 [assembly: Guid("3b3ce34d-b5e5-47ca-bfef-e6740650f378")]

Ignia.Topics.Web/Properties/AssemblyInfo.cs

@@ -21,7 +21,7 @@
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 [assembly: ComVisible(false)]
-[assembly: AssemblyVersion("3.5.1744.0")]
-[assembly: AssemblyFileVersion("3.5.1768.0")]
+[assembly: AssemblyVersion("3.5.1748.0")]
+[assembly: AssemblyFileVersion("3.5.1772.0")]
 [assembly: CLSCompliant(true)]
 [assembly: Guid("c98f7b48-a085-4394-b820-c244f23868ce")]

Ignia.Topics/Properties/AssemblyInfo.cs

@@ -22,8 +22,8 @@
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 [assembly: ComVisible(false)]
-[assembly: AssemblyVersion("3.5.1745.0")]
-[assembly: AssemblyFileVersion("3.5.1777.0")]
+[assembly: AssemblyVersion("3.5.1749.0")]
+[assembly: AssemblyFileVersion("3.5.1781.0")]
 [assembly: InternalsVisibleTo("Ignia.Topics.Tests")]
 [assembly: CLSCompliant(true)]
 [assembly: GuidAttribute("3CA9F6CB-B45A-4E74-AAA4-0C87CAA2704F")]

Ignia.Topics/Reflection/MemberInfoCollection{T}.cs

@@ -40,12 +40,7 @@ in type.GetMembers(
           BindingFlags.Public
         ).Where(m => typeof(T).IsAssignableFrom(m.GetType()))
       ) {
-        if (!Contains(member.Name)) {
-          Add((T)member);
-        }
-        else {
-          throw new ArgumentException("The Type '" + type.Name + "' already contains the MemberInfo '" + member.Name + "'");
-        }
+        Add((T)member);
       }
     }
 
@@ -66,6 +61,21 @@ internal MemberInfoCollection(Type type, IEnumerable<T> members) : base(StringCo
       }
     }
 
+    /*==========================================================================================================================
+    | OVERRIDE: INSERT ITEM
+    \-------------------------------------------------------------------------------------------------------------------------*/
+    /// <summary>
+    ///   Returns the type associated with this collection.
+    /// </summary>
+    protected override void InsertItem(int index, T item) {
+      if (!Contains(item.Name)) {
+        base.InsertItem(index, item);
+      }
+      else {
+        throw new ArgumentException("The Type '" + Type.Name + "' already contains the MemberInfo '" + item.Name + "'");
+      }
+    }
+
     /*==========================================================================================================================
     | PROPERTY: TYPE
     \-------------------------------------------------------------------------------------------------------------------------*/