Skip to content

Commit 2981776

Browse files
committed
Removed all unnecessary package references
Package references that aren't marked as `<PrivateAssets />` get relayed onto implementers, obviously. And, yet, not all package references were truly necessary—not for downstream implementations, or even the local assembly in some cases. That creates a lot of downstream clutter. As a result, I've removed every package reference that isn't required, and moved any that are only required locally to ensure that they are marked with `<PrivateAssets>`. Note that this, unfortunately, wasn't practical for the **Razor Class Library**; while nearly all dependencies can be sourced to more specific **NuGet** packages, the configuration extensions' dependency on `IEndpointRouteBuilder` can only be retrieved from the full `Microsoft.AspNetCore.App` framework reference, apparently. That's unfortunate.
1 parent 11415eb commit 2981776

7 files changed

Lines changed: 5 additions & 40 deletions

File tree

OnTopic.AspNetCore.Mvc.Tests/OnTopic.AspNetCore.Mvc.Tests.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
44
<TargetFramework>netcoreapp3.0</TargetFramework>
@@ -9,7 +9,6 @@
99
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.2.0" />
1010
<PackageReference Include="MSTest.TestAdapter" Version="2.0.0" />
1111
<PackageReference Include="MSTest.TestFramework" Version="2.0.0" />
12-
<PackageReference Include="coverlet.collector" Version="1.0.1" />
1312
</ItemGroup>
1413

1514
<ItemGroup>

OnTopic.AspNetCore.Mvc/OnTopic.AspNetCore.Mvc.csproj

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,6 @@
4545
<PrivateAssets>all</PrivateAssets>
4646
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
4747
</PackageReference>
48-
<PackageReference Include="UtilPack.NuGet.MSBuild" Version="2.9.1">
49-
<PrivateAssets>all</PrivateAssets>
50-
</PackageReference>
51-
<PackageReference Include="System.Data.DataSetExtensions" Version="4.5.0" />
52-
<PackageReference Include="System.Net.Http" Version="4.3.4" />
5348
</ItemGroup>
5449
<ItemGroup>
5550
<ProjectReference Include="..\OnTopic\OnTopic.csproj" />

OnTopic.Data.Caching/OnTopic.Data.Caching.csproj

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,6 @@
4040
<PrivateAssets>all</PrivateAssets>
4141
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
4242
</PackageReference>
43-
<PackageReference Include="UtilPack.NuGet.MSBuild" Version="2.9.1">
44-
<PrivateAssets>all</PrivateAssets>
45-
</PackageReference>
46-
<PackageReference Include="System.Data.DataSetExtensions" Version="4.5.0" />
47-
<PackageReference Include="System.Net.Http" Version="4.3.4" />
48-
</ItemGroup>
49-
<ItemGroup>
50-
<Reference Include="Microsoft.CSharp" />
5143
</ItemGroup>
5244
<ItemGroup>
5345
<ProjectReference Include="..\OnTopic\OnTopic.csproj" />

OnTopic.Data.Sql/OnTopic.Data.Sql.csproj

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,8 @@
3737
<PrivateAssets>all</PrivateAssets>
3838
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
3939
</PackageReference>
40-
<PackageReference Include="UtilPack.NuGet.MSBuild" Version="2.9.1">
41-
<PrivateAssets>all</PrivateAssets>
42-
</PackageReference>
43-
<PackageReference Include="System.Data.DataSetExtensions" Version="4.5.0" />
44-
<PackageReference Include="System.Net.Http" Version="4.3.4" />
4540
<PackageReference Include="System.Data.SqlClient" Version="4.7.0" />
4641
</ItemGroup>
47-
<ItemGroup>
48-
<Reference Include="Microsoft.CSharp" />
49-
</ItemGroup>
5042
<ItemGroup>
5143
<ProjectReference Include="..\OnTopic\OnTopic.csproj" />
5244
</ItemGroup>

OnTopic.Tests/OnTopic.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.2.0" />
3131
<PackageReference Include="MSTest.TestAdapter" Version="2.0.0" />
3232
<PackageReference Include="MSTest.TestFramework" Version="2.0.0" />
33-
<PackageReference Include="coverlet.collector" Version="1.0.1" />
3433
</ItemGroup>
3534
<ItemGroup>
3635
<ProjectReference Include="..\OnTopic.Data.Caching\OnTopic.Data.Caching.csproj" />

OnTopic.ViewModels/OnTopic.ViewModels.csproj

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,6 @@
4040
<PrivateAssets>all</PrivateAssets>
4141
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
4242
</PackageReference>
43-
<PackageReference Include="UtilPack.NuGet.MSBuild" Version="2.9.1">
44-
<PrivateAssets>all</PrivateAssets>
45-
</PackageReference>
46-
<PackageReference Include="System.Data.DataSetExtensions" Version="4.5.0" />
47-
<PackageReference Include="System.Net.Http" Version="4.3.4" />
48-
</ItemGroup>
49-
<ItemGroup>
50-
<Reference Include="Microsoft.CSharp" />
5143
</ItemGroup>
5244
<ItemGroup>
5345
<ProjectReference Include="..\OnTopic\OnTopic.csproj" />

OnTopic/OnTopic.csproj

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,12 @@
4040
<PrivateAssets>all</PrivateAssets>
4141
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
4242
</PackageReference>
43-
<PackageReference Include="Microsoft.CSharp" Version="4.6.0" />
44-
<PackageReference Include="Microsoft.VisualStudio.Validation" Version="15.5.31" />
45-
<PackageReference Include="UtilPack.NuGet.MSBuild" Version="2.9.1">
43+
<PackageReference Include="System.ComponentModel.Annotations" Version="4.6.0">
44+
<PrivateAssets>all</PrivateAssets>
45+
</PackageReference>
46+
<PackageReference Include="Microsoft.VisualStudio.Validation" Version="15.5.31">
4647
<PrivateAssets>all</PrivateAssets>
4748
</PackageReference>
48-
<PackageReference Include="System.ComponentModel.Annotations" Version="4.6.0" />
49-
<PackageReference Include="System.Data.DataSetExtensions" Version="4.5.0" />
50-
</ItemGroup>
51-
<ItemGroup>
52-
<Reference Include="Microsoft.CSharp" />
5349
</ItemGroup>
5450
<ItemGroup>
5551
<None Include="Mapping\README.md" />

0 commit comments

Comments
 (0)