Migrate mapping services to use ItemMetadata.Configuration

The `TopicMappingService` and `ReverseTopicMappingService` (and, by extension, the `BindingModelValidator`) have been updated to pull the `ItemConfiguration` from `ItemMetadata` (or `PropertyMetadata`) (74cb817) instead of constructing a new version directly. This takes advantage of the caching of `TypeAccessor` and `ParameterMetadata`, thus ensuring the configuration data only needs to be assessed once per item.

This loses access to the `attributePrefix` state data, and thus temporarily breaks the `[MapToParent]` functionality. In a future commit, we'll update the `TopicMappingService` and `ReverseTopicMappingService` to relay that internally, and reference it as needed.

This may also temporarily break some references that were relying on specific properties of `PropertyConfiguration`, namely `MemberAccessor`; that will be resolved in a subsequent commit, when we begin relaying `MemberAccessor` instead of `PropertyConfiguration`.

Author: JeremyCaney

OnTopic/Mapping/Internal/PropertyConfiguration.cs

@@ -41,10 +41,7 @@ internal class PropertyConfiguration: ItemConfiguration {
     /// <param name="memberAccessor">
     ///   The <see cref="MemberAccessor"/> instance to check for <see cref="Attribute"/> values.
     /// </param>
-    /// <param name="attributePrefix">The prefix to apply to the attributes.</param>
-    internal PropertyConfiguration(MemberAccessor memberAccessor, string? attributePrefix = ""):
-      base(memberAccessor, memberAccessor.Name, attributePrefix)
-    {
+    internal PropertyConfiguration(MemberAccessor memberAccessor): base(memberAccessor) {
       MemberAccessor            = memberAccessor;
     }
 

OnTopic/Mapping/Reverse/BindingModelValidator.cs

@@ -148,8 +148,8 @@ static internal void ValidateProperty(
       /*------------------------------------------------------------------------------------------------------------------------
       | Define variables
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var configuration         = new PropertyConfiguration(propertyAccessor, attributePrefix);
       var compositeAttributeKey = configuration.AttributeKey;
+      var configuration         = propertyAccessor.Configuration;
       var attributeDescriptor   = contentTypeDescriptor.AttributeDescriptors.GetValue(compositeAttributeKey);
       var childCollections      = new[] { CollectionType.Children, CollectionType.NestedTopics };
       var relationships         = new[] { CollectionType.Relationship, CollectionType.IncomingRelationship };

OnTopic/Mapping/Reverse/ReverseTopicMappingService.cs

@@ -240,7 +240,7 @@ private async Task SetPropertyAsync(
       /*------------------------------------------------------------------------------------------------------------------------
       | Establish per-property variables
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var configuration         = new PropertyConfiguration(propertyAccessor, attributePrefix);
+      var configuration         = memberAccessor.Configuration;
       var contentTypeDescriptor = _contentTypeDescriptors.GetValue(target.ContentType);
       var compositeAttributeKey = configuration.AttributeKey;
 

OnTopic/Mapping/TopicMappingService.cs

@@ -392,7 +392,7 @@ private async Task<object> MapAsync(
       /*------------------------------------------------------------------------------------------------------------------------
       | Establish per-property variables
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var configuration         = new ItemConfiguration(parameter, parameter.Name, attributePrefix);
+      var configuration         = parameter.Configuration;
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Bypass if mapping is disabled