Updated TopicMappingService to use new ParameterMetadata

In `TopicMappingService`, when evaluating parameters, we now pull a list of `ParameterMetadata` from the `TypeAccessor`, instead of calling `GetPrimaryConstructor()` for each instance. This should provide a slight improvement to performance. Outside of that, this doesn't buy us too much yet—though it will be get us more functionality in a bit, once we incorporate it into `ItemConfiguration` as well. That'll come in a subsequent commit.

As part of this, this required updating the parameters and member calls to work off of `ParameterMetadata` instead of `ParameterInfo`.

Author: JeremyCaney

OnTopic/Mapping/TopicMappingService.cs

@@ -182,9 +182,8 @@ public TopicMappingService(ITopicRepository topicRepository, ITypeLookupService
       | Identify parameters
       \-----------------------------------------------------------------------------------------------------------------------*/
       var typeAccessor          = TypeAccessorCache.GetTypeAccessor(type);
-      var constructorInfo       = typeAccessor.GetPrimaryConstructor();
-      var parameters            = constructorInfo?.GetParameters()?? Array.Empty<ParameterInfo>();
-      var arguments             = new object?[parameters.Length];
+      var parameters            = typeAccessor.ConstructorParameters;
+      var arguments             = new object?[parameters.Count];
       var attributeArguments    = (IDictionary<string, string?>)new Dictionary<string, string?>();
 
       /*------------------------------------------------------------------------------------------------------------------------
@@ -202,15 +201,15 @@ public TopicMappingService(ITopicRepository topicRepository, ITypeLookupService
       \-----------------------------------------------------------------------------------------------------------------------*/
       var parameterQueue        = new Dictionary<int, Task<object?>>();
 
-      if (parameters.Length == 1 && parameters[0].ParameterType == typeof(AttributeDictionary)) {
+      if (parameters.Count is 1 && parameters[0].Type == typeof(AttributeDictionary)) {
         var attributes          = topic.Attributes.AsAttributeDictionary(true);
         arguments[0]            = attributes;
         attributeArguments      = attributes;
       }
       else {
 
         foreach (var parameter in parameters) {
-          parameterQueue.Add(parameter.Position, GetParameterAsync(topic, associations, parameter, cache, attributePrefix));
+          parameterQueue.Add(parameter.ParameterInfo.Position, GetParameterAsync(topic, associations, parameter, cache, attributePrefix));
         }
 
         await Task.WhenAll(parameterQueue.Values).ConfigureAwait(false);
@@ -370,22 +369,21 @@ private async Task<object> MapAsync(
     private async Task<object?> GetParameterAsync(
       Topic source,
       AssociationTypes associations,
-      ParameterInfo parameter,
+      ParameterMetadata parameter,
       MappedTopicCache cache,
       string? attributePrefix = null
     ) {
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Establish per-property variables
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var attributes            = parameter.GetCustomAttributes(true).OfType<Attribute>();
-      var configuration         = new ItemConfiguration(attributes, parameter.Name, attributePrefix);
+      var configuration         = new ItemConfiguration(parameter.CustomAttributes, parameter.Name, attributePrefix);
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Bypass if mapping is disabled
       \-----------------------------------------------------------------------------------------------------------------------*/
       if (configuration.DisableMapping) {
-        return parameter.DefaultValue;
+        return parameter.ParameterInfo.DefaultValue;
       }
 
       /*------------------------------------------------------------------------------------------------------------------------
@@ -394,7 +392,7 @@ private async Task<object> MapAsync(
       if (configuration.MapToParent) {
         return await MapAsync(
           source,
-          parameter.ParameterType,
+          parameter.Type,
           associations,
           cache,
           configuration.AttributePrefix
@@ -404,10 +402,10 @@ private async Task<object> MapAsync(
       /*------------------------------------------------------------------------------------------------------------------------
       | Determine value
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var value = await GetValue(source, parameter.ParameterType, associations, configuration, cache, false).ConfigureAwait(false);
+      var value = await GetValue(source, parameter.Type, associations, configuration, cache, false).ConfigureAwait(false);
 
-      if (value is null && IsList(parameter.ParameterType)) {
-        return await getList(parameter.ParameterType, configuration).ConfigureAwait(false);
+      if (value is null && IsList(parameter.Type)) {
+        return await getList(parameter.Type, configuration).ConfigureAwait(false);
       }
 
       return value;