Updated StubTopicRepository so all topics are "saved" by default

Generally, when querying an `ITopicRepository`, it's safe to assume that the topics retuned will be saved. If they aren't, there are a number of issues that can arise since `IsNew` topics will always return `IsDirty()`, among other factors. Most of the topics in the `StubTopicRepository` already have an `Id` assigned to them to simulate that they've been saved, but a number do not. This update ensures all of them have an identity assigned.

As suspected, this uncovers some issues with the unit tests. It appears at least two tests which were previously passing now fail. These have been logged as Issues #81 and #82. Those will be addressed in subsequent commits.

Author: JeremyCaney

OnTopic.TestDoubles/StubTopicRepository.cs

@@ -234,21 +234,21 @@ private Topic CreateFakeData() {
       /*------------------------------------------------------------------------------------------------------------------------
       | Establish root
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var rootTopic = new Topic("Root", "Container", null, 900);
       var currentAttributeId = 800;
+      var rootTopic = new Topic("Root", "Container", null, currentAttributeId++);
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Establish configuration
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var configuration = new Topic("Configuration", "Container", rootTopic);
-      var contentTypes = new ContentTypeDescriptor("ContentTypes", "ContentTypeDescriptor", configuration);
+      var configuration = new Topic("Configuration", "Container", rootTopic, currentAttributeId++);
+      var contentTypes = new ContentTypeDescriptor("ContentTypes", "ContentTypeDescriptor", configuration, currentAttributeId++);
 
       addAttribute(contentTypes, "Key", "TextAttributeDescriptor", false, true);
       addAttribute(contentTypes, "ContentType", "TextAttributeDescriptor", false, true);
       addAttribute(contentTypes, "Title", "TextAttributeDescriptor", true, true);
       addAttribute(contentTypes, "BaseTopic", "TopicReferenceAttributeDescriptor", false);
 
-      var contentTypeDescriptor = new ContentTypeDescriptor("ContentTypeDescriptor", "ContentTypeDescriptor", contentTypes);
+      var contentTypeDescriptor = new ContentTypeDescriptor("ContentTypeDescriptor", "ContentTypeDescriptor", contentTypes, currentAttributeId++);
 
       addAttribute(contentTypeDescriptor, "ContentTypes", "RelationshipAttributeDescriptor");
       addAttribute(contentTypeDescriptor, "Attributes", "NestedTopicListAttributeDescriptor");
@@ -258,7 +258,7 @@ private Topic CreateFakeData() {
       TopicFactory.Create("LookupListItem", "ContentTypeDescriptor", contentTypes);
       TopicFactory.Create("List", "ContentTypeDescriptor", contentTypes);
 
-      var attributeDescriptor = new ContentTypeDescriptor("AttributeDescriptor", "ContentTypeDescriptor", contentTypes);
+      var attributeDescriptor = new ContentTypeDescriptor("AttributeDescriptor", "ContentTypeDescriptor", contentTypes, currentAttributeId++);
 
       addAttribute(attributeDescriptor, "DefaultValue", "TextAttributeDescriptor", false, true);
       addAttribute(attributeDescriptor, "IsRequired", "TextAttributeDescriptor", false, true);
@@ -270,7 +270,7 @@ private Topic CreateFakeData() {
       TopicFactory.Create("TextAttributeDescriptor", "ContentTypeDescriptor", attributeDescriptor);
       TopicFactory.Create("TopicReferenceAttributeDescriptor", "ContentTypeDescriptor", attributeDescriptor);
 
-      var pageContentType = new ContentTypeDescriptor("Page", "ContentTypeDescriptor", contentTypes);
+      var pageContentType = new ContentTypeDescriptor("Page", "ContentTypeDescriptor", contentTypes, currentAttributeId++);
 
       addAttribute(pageContentType, "MetaTitle");
       addAttribute(pageContentType, "MetaDescription");
@@ -280,7 +280,7 @@ private Topic CreateFakeData() {
       pageContentType.Relationships.SetValue("ContentTypes", pageContentType);
       pageContentType.Relationships.SetValue("ContentTypes", contentTypeDescriptor);
 
-      var contactContentType = new ContentTypeDescriptor("Contact", "ContentTypeDescriptor", contentTypes);
+      var contactContentType = new ContentTypeDescriptor("Contact", "ContentTypeDescriptor", contentTypes, currentAttributeId++);
 
       addAttribute(contactContentType, "Name", isExtended: false);
       addAttribute(contactContentType, "AlternateEmail", isExtended: false);
@@ -310,9 +310,9 @@ AttributeDescriptor addAttribute(
       /*------------------------------------------------------------------------------------------------------------------------
       | Establish metadata
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var metadata = new Topic("Metadata", "Container", configuration);
-      var categories = new Topic("Categories", "Lookup", metadata);
-      var lookup = new Topic("LookupList", "List", categories);
+      var metadata              = new Topic("Metadata", "Container", configuration, currentAttributeId++);
+      var categories            = new Topic("Categories", "Lookup", metadata, currentAttributeId++);
+      var lookup                = new Topic("LookupList", "List", categories, currentAttributeId++);
 
       for (var i=1; i<=5; i++) {
         _ = new Topic("Category" + i, "LookupListItem", lookup);
@@ -325,10 +325,10 @@ AttributeDescriptor addAttribute(
 
       CreateFakeData(web, 2, 3);
 
-      var pageGroup             = new Topic("Web_3", "PageGroup", web);
-      _                         = new Topic("Web_3_0", "Page", pageGroup);
-      var childPage             = new Topic("Web_3_1", "Page", pageGroup);
-      var leafPage              = new Topic("Web_3_1_0", "Page", childPage);
+      var pageGroup             = new Topic("Web_3", "PageGroup", web, currentAttributeId++);
+      _                         = new Topic("Web_3_0", "Page", pageGroup, currentAttributeId++);
+      var childPage             = new Topic("Web_3_1", "Page", pageGroup, currentAttributeId++);
+      var leafPage              = new Topic("Web_3_1_0", "Page", childPage, currentAttributeId++);
 
       leafPage.Attributes.SetValue("NavigationRoot", "Configuration");