Implemented more expressive test names across AspNetCore tests

For consistency with `OnTopic.Tests`, updated the test names in `OnTopic.AspNetCore.Mvc.Tests` to be more expressive using the format `METHOD_CONDITION_RESULT` (e.g., ` Load_ByRoute_ReturnsTopic()`). In the case of the `ValidateTopicAttributeTest`, I excluded the `METHOD_` prefix due to length (e.g., `DisabledTopic_ReturnsNotFound`, instead of `OnActionExecuting_DisabledTopic_ReturnsNotFound`); the context should be implicit based on the class name.

Author: JeremyCaney

OnTopic.AspNetCore.Mvc.Tests/TopicControllerTest.cs

@@ -78,13 +78,13 @@ public TopicControllerTest() {
     }
 
     /*==========================================================================================================================
-    | TEST: TOPIC
+    | TEST: TOPIC CONTROLLER: INDEX ASYNC: RETURNS TOPIC VIEW RESULT
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Triggers the <see cref="TopicController.IndexAsync(String)" /> action.
     /// </summary>
     [TestMethod]
-    public async Task TopicController_IndexAsync() {
+    public async Task TopicController_IndexAsync_ReturnsTopicViewResult() {
 
       var controller            = new TopicController(_topicRepository, _topicMappingService) {
         ControllerContext       = _context
@@ -101,13 +101,13 @@ public async Task TopicController_IndexAsync() {
     }
 
     /*==========================================================================================================================
-    | TEST: REDIRECT
+    | TEST: REDIRECT CONTROLLER: REDIRECT: RETURNS REDIRECT RESULT
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Triggers the <see cref="FallbackController.Index()" /> action.
     /// </summary>
     [TestMethod]
-    public void RedirectController_TopicRedirect() {
+    public void RedirectController_TopicRedirect_ReturnsRedirectResult() {
 
       var controller            = new RedirectController(_topicRepository);
       var result                = controller.Redirect(11110) as RedirectResult;
@@ -121,7 +121,7 @@ public void RedirectController_TopicRedirect() {
     }
 
     /*==========================================================================================================================
-    | TEST: SITEMAP
+    | TEST: SITEMAP CONTROLLER: INDEX: RETURNS SITEMAP XML
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Triggers the index action of the <see cref="SitemapController.Index()" /> action.
@@ -133,7 +133,7 @@ public void RedirectController_TopicRedirect() {
     /// </remarks>
     [TestMethod]
     [ExpectedException(typeof(NullReferenceException), AllowDerivedTypes=false)]
-    public void SitemapController_Index() {
+    public void SitemapController_Index_ReturnsSitemapXml() {
 
       var controller            = new SitemapController(_topicRepository);
       var result                = controller.Index() as ViewResult;

OnTopic.AspNetCore.Mvc.Tests/TopicRepositoryExtensionsTest.cs

@@ -43,13 +43,13 @@ public TopicRepositoryExtensionsTest() {
     }
 
     /*==========================================================================================================================
-    | TEST: LOAD (ROUTE)
+    | TEST: LOAD: BY ROUTE: RETURNS TOPIC
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Establishes route data and ensures that a topic is correctly identified based on that route.
     /// </summary>
     [TestMethod]
-    public void LoadRoute() {
+    public void Load_ByRoute_ReturnsTopic() {
 
       var routes                = new RouteData();
       var topic                 = _topicRepository.Load("Root:Web:Web_0:Web_0_1:Web_0_1_1");

OnTopic.AspNetCore.Mvc.Tests/TopicViewComponentTest.cs

@@ -97,13 +97,13 @@ public TopicViewComponentTest() {
     }
 
     /*==========================================================================================================================
-    | TEST: MENU
+    | TEST: MENU: INVOKE: RETURNS NAVIGATION VIEW MODEL
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Loads a new <see cref="MenuViewComponent"/> and confirms the resulting values.
     /// </summary>
     [TestMethod]
-    public async Task Menu() {
+    public async Task Menu_Invoke_ReturnsNavigationViewModel() {
 
       var viewComponent         = new MenuViewComponent(_topicRepository, _hierarchicalMappingService) {
         ViewComponentContext    = _context
@@ -122,13 +122,13 @@ public async Task Menu() {
     }
 
     /*==========================================================================================================================
-    | TEST: PAGE-LEVEL NAVIGATION
+    | TEST: PAGE-LEVEL NAVIGATION: INVOKE: RETURNS NAVIGATION VIEW MODEL
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Loads a new <see cref="PageLevelNavigationViewComponent"/> and confirms the resulting values.
     /// </summary>
     [TestMethod]
-    public async Task PageLevelNavigation() {
+    public async Task PageLevelNavigation_Invoke_ReturnsNavigationViewModel() {
 
       var viewComponent         = new PageLevelNavigationViewComponent(_topicRepository, _hierarchicalMappingService) {
         ViewComponentContext    = _context

OnTopic.AspNetCore.Mvc.Tests/ValidateTopicAttributeTest.cs

@@ -87,15 +87,15 @@ public static TopicController GetTopicController(Topic topic) =>
       };
 
     /*==========================================================================================================================
-    | TEST: INVALID CONTROLLER THROWS EXCEPTION
+    | TEST: INVALID CONTROLLER TYPE THROWS EXCEPTION
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Ensures that a controller that doesn't derive from <see cref="TopicController"/> throws a <see
     ///   cref="InvalidOperationException"/>.
     /// </summary>
     [TestMethod]
     [ExpectedException(typeof(InvalidOperationException))]
-    public void InvalidController_Throws_Exception() {
+    public void InvalidControllerType_ThrowsException() {
 
       var validateFilter        = new ValidateTopicAttribute();
       var controller            = new DummyController() {
@@ -112,13 +112,13 @@ public void InvalidController_Throws_Exception() {
 
     }
     /*==========================================================================================================================
-    | TEST: NULL TOPIC RETURNS NOT FOUND
+    | TEST: NULL TOPIC: RETURNS NOT FOUND
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Ensures that a <see cref="NotFoundObjectResult"/> is thrown if the <see cref="TopicController.CurrentTopic"/> is null.
     /// </summary>
     [TestMethod]
-    public void NullTopic_Returns_NotFound() {
+    public void NullTopic_ReturnsNotFound() {
 
       var validateFilter        = new ValidateTopicAttribute();
       var controller            = GetTopicController(null);
@@ -133,13 +133,13 @@ public void NullTopic_Returns_NotFound() {
     }
 
     /*==========================================================================================================================
-    | TEST: DISABLED TOPIC RETURNS NOT AUTHORIZED
+    | TEST: DISABLED TOPIC: RETURNS NOT AUTHORIZED
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Ensures that a <see cref="NotFoundObjectResult"/> is thrown if the <see cref="TopicController.CurrentTopic"/> is null.
     /// </summary>
     [TestMethod]
-    public void DisabledTopic_Returns_NotFound() {
+    public void DisabledTopic_ReturnsNotFound() {
 
       var validateFilter        = new ValidateTopicAttribute();
       var topic                 = TopicFactory.Create("Key", "Page");
@@ -157,14 +157,14 @@ public void DisabledTopic_Returns_NotFound() {
     }
 
     /*==========================================================================================================================
-    | TEST: TOPIC WITH URL RETURNS REDIRECT
+    | TEST: TOPIC WITH URL: RETURNS REDIRECT
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Ensures that a <see cref="RedirectResult"/> is thrown if the <see cref="TopicController.CurrentTopic"/> contains
     ///   a <c>Url</c> attribute.
     /// </summary>
     [TestMethod]
-    public void TopicWithUrl_Returns_Redirect() {
+    public void TopicWithUrl_ReturnsRedirect() {
 
       var validateFilter        = new ValidateTopicAttribute();
       var topic                 = TopicFactory.Create("Key", "Page");
@@ -182,14 +182,14 @@ public void TopicWithUrl_Returns_Redirect() {
     }
 
     /*==========================================================================================================================
-    | TEST: NESTED TOPIC RETURNS 403
+    | TEST: NESTED TOPIC: RETURNS 403
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Ensures that a <see cref="StatusCodeResult"/> is thrown if the <see cref="TopicController.CurrentTopic"/> has a
     ///   <see cref="ContentTypeDescriptor"/> of <c>List</c>.
     /// </summary>
     [TestMethod]
-    public void NestedTopic_Returns_403() {
+    public void NestedTopic_Returns403() {
 
       var validateFilter        = new ValidateTopicAttribute();
       var topic                 = TopicFactory.Create("Key", "List");
@@ -208,14 +208,14 @@ public void NestedTopic_Returns_403() {
     }
 
     /*==========================================================================================================================
-    | TEST: PAGE GROUP TOPIC RETURNS REDIRECT
+    | TEST: PAGE GROUP TOPIC: RETURNS REDIRECT
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
     ///   Ensures that a <see cref="RedirectResult"/> is thrown if the <see cref="TopicController.CurrentTopic"/> has a
     ///   <see cref="ContentTypeDescriptor"/> of <c>PageGroup</c>.
     /// </summary>
     [TestMethod]
-    public void PageGroupTopic_Returns_Redirect() {
+    public void PageGroupTopic_ReturnsRedirect() {
 
       var validateFilter        = new ValidateTopicAttribute();
       var topic                 = TopicFactory.Create("Key", "PageGroup");