Consolidated logic into GetValue(), SetValue()

The `GetValue()` and `SetValue()` methods didn't get any business logic for e.g. validating parameters, and wouldn't throw an exception if called with an invalid member. This is inconsistent with other methods. In the meanwhile, the e.g. `GetPropertyValue()` and `GetMethodValue()` methods essentially shared the same logic. To mitigate both issues, the logic from the property- and method-based actions was moved into `GetValue()` and `SetValue()`.

A downside of this is that it necessitated removing the check for whether the `MemberAccessor` is a property or a method. This remains in e.g. `HasGettableProperty()`, if needed. I continue to question the need for the property- and method-based interface, however, and this helps deprioritize their priority by making them simple convenience passthroughs until a decision is made.

Author: JeremyCaney

OnTopic/Internal/Reflection/TypeAccessor.cs

@@ -177,7 +177,6 @@ internal bool HasGettableProperty(string name, Type? targetType = null, Type? at
     internal bool HasGettableProperty<T>(string name, Type? targetType = null) where T : Attribute
       => HasGettableProperty(name, targetType, typeof(T));
 
-
     /*==========================================================================================================================
     | METHOD: HAS GETTABLE METHOD
     \-------------------------------------------------------------------------------------------------------------------------*/
@@ -215,41 +214,41 @@ internal bool HasGettableMethod<T>(string name, Type? targetType = null) where T
     /// <param name="source">The <see cref="Object"/> instance from which the value should be retrieved.</param>
     /// <param name="memberName">The name of the method or property from which the value should be retrieved.</param>
     /// <returns>The value returned from the member.</returns>
-    internal object? GetValue(object source, string memberName) => GetMember(memberName)?.GetValue(source);
-
-    /*==========================================================================================================================
-    | METHOD: GET PROPERTY VALUE
-    \-------------------------------------------------------------------------------------------------------------------------*/
-    /// <summary>
-    ///   Uses reflection to call a property, assuming that it is a) readable, and b) of type <see cref="String"/>,
-    ///   <see cref="Int32"/>, or <see cref="Boolean"/>.
-    /// </summary>
-    /// <param name="target">The object instance on which the property is defined.</param>
-    /// <param name="name">The name of the property to assess.</param>
-    internal object? GetPropertyValue(object target, string name) {
+    internal object? GetValue(object source, string memberName) {
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Validate parameters
       \-----------------------------------------------------------------------------------------------------------------------*/
-      Contract.Requires(target, nameof(target));
-      Contract.Requires(name, nameof(name));
+      Contract.Requires(source, nameof(source));
+      Contract.Requires(memberName, nameof(memberName));
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Retrieve member
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var member = GetMember(name);
+      var member = GetMember(memberName);
 
-      if (member is null || member.MemberType != MemberTypes.Property) {
+      if (member is null) {
         return null;
       }
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Retrieve value
       \-----------------------------------------------------------------------------------------------------------------------*/
-      return member.GetValue(target);
+      return member.GetValue(source);
 
     }
 
+    /*==========================================================================================================================
+    | METHOD: GET PROPERTY VALUE
+    \-------------------------------------------------------------------------------------------------------------------------*/
+    /// <summary>
+    ///   Uses reflection to call a property, assuming that it is a) readable, and b) of type <see cref="String"/>,
+    ///   <see cref="Int32"/>, or <see cref="Boolean"/>.
+    /// </summary>
+    /// <param name="target">The object instance on which the property is defined.</param>
+    /// <param name="name">The name of the property to assess.</param>
+    internal object? GetPropertyValue(object target, string name) => GetValue(target, name);
+
     /*==========================================================================================================================
     | METHOD: GET METHOD VALUE
     \-------------------------------------------------------------------------------------------------------------------------*/
@@ -258,29 +257,7 @@ internal bool HasGettableMethod<T>(string name, Type? targetType = null) where T
     /// </summary>
     /// <param name="target">The object instance on which the method is defined.</param>
     /// <param name="name">The name of the method to assess.</param>
-    internal object? GetMethodValue(object target, string name) {
-
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Validate parameters
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      Contract.Requires(target, nameof(target));
-      Contract.Requires(name, nameof(name));
-
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Retrieve member
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      var member = GetMember(name);
-
-      if (member is null || member.MemberType != MemberTypes.Method) {
-        return null;
-      }
-
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Retrieve value
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      return member.GetValue(target);
-
-    }
+    internal object? GetMethodValue(object target, string name) => GetValue(target, name);
 
     /*==========================================================================================================================
     | HAS SETTER?
@@ -350,41 +327,28 @@ internal bool HasSettableMethod<T>(string name, Type? targetType = null) where T
     | SET VALUE
     \-------------------------------------------------------------------------------------------------------------------------*/
     /// <summary>
-    ///   Sets the value of a member named <paramref name="memberName"/> on the supplied <paramref name="source"/> object.
+    ///   Sets the value of a member named <paramref name="memberName"/> on the supplied <paramref name="target"/> object.
     /// </summary>
-    /// <param name="source">The <see cref="Object"/> instance on which the value should be set.</param>
+    /// <param name="target">The <see cref="Object"/> instance on which the value should be set.</param>
     /// <param name="memberName">The name of the method or property on which the value should be set.</param>
     /// <param name="value">The <see cref="Object"/> value to set the member to.</param>
-    internal void SetValue(object source, string memberName, object? value) => GetMember(memberName)?.SetValue(source, value);
-
-    /*==========================================================================================================================
-    | METHOD: SET PROPERTY VALUE
-    \-------------------------------------------------------------------------------------------------------------------------*/
-    /// <summary>
-    ///   Uses reflection to call a property, assuming that it is a) writable, and b) of type <see cref="String"/>, <see cref="
-    ///   Int32"/>, or <see cref="Boolean"/>, or is otherwise compatible with the <paramref name="value"/> type.
-    /// </summary>
-    /// <param name="target">The object on which the property is defined.</param>
-    /// <param name="name">The name of the property to assess.</param>
-    /// <param name="value">The value to set on the property.</param>
     /// <param name="allowConversion">
     ///   Determines whether a fallback to <see cref="AttributeValueConverter.Convert(String?, Type)"/> is permitted.
     /// </param>
-    internal void SetPropertyValue(object target, string name, object? value, bool allowConversion = false) {
+    internal void SetValue(object target, string memberName, object? value, bool allowConversion = false) {
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Validate parameters
       \-----------------------------------------------------------------------------------------------------------------------*/
       Contract.Requires(target, nameof(target));
-      Contract.Requires(name, nameof(name));
+      Contract.Requires(memberName, nameof(memberName));
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Validate dependencies
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var member = GetMember(name);
+      var member = GetMember(memberName);
 
-      Contract.Assume(member, $"The {name} property could not be retrieved.");
-      Contract.Assume(member.MemberType == MemberTypes.Property, $"The {name} member is not a property.");
+      Contract.Assume(member, $"The {memberName} property could not be retrieved.");
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Set value
@@ -393,6 +357,22 @@ internal void SetPropertyValue(object target, string name, object? value, bool a
 
     }
 
+    /*==========================================================================================================================
+    | METHOD: SET PROPERTY VALUE
+    \-------------------------------------------------------------------------------------------------------------------------*/
+    /// <summary>
+    ///   Uses reflection to call a property, assuming that it is a) writable, and b) of type <see cref="String"/>, <see cref="
+    ///   Int32"/>, or <see cref="Boolean"/>, or is otherwise compatible with the <paramref name="value"/> type.
+    /// </summary>
+    /// <param name="target">The object on which the property is defined.</param>
+    /// <param name="name">The name of the property to assess.</param>
+    /// <param name="value">The value to set on the property.</param>
+    /// <param name="allowConversion">
+    ///   Determines whether a fallback to <see cref="AttributeValueConverter.Convert(String?, Type)"/> is permitted.
+    /// </param>
+    internal void SetPropertyValue(object target, string name, object? value, bool allowConversion = false)
+      => SetValue(target, name, value, allowConversion);
+
     /*==========================================================================================================================
     | METHOD: SET METHOD VALUE
     \-------------------------------------------------------------------------------------------------------------------------*/
@@ -410,28 +390,8 @@ internal void SetPropertyValue(object target, string name, object? value, bool a
     /// <param name="allowConversion">
     ///   Determines whether a fallback to <see cref="AttributeValueConverter.Convert(String?, Type)"/> is permitted.
     /// </param>
-    internal void SetMethodValue(object target, string name, object? value, bool allowConversion = false) {
-
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Validate parameters
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      Contract.Requires(target, nameof(target));
-      Contract.Requires(name, nameof(name));
-
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Validate dependencies
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      var member = GetMember(name);
-
-      Contract.Assume(member, $"The {name}() method could not be retrieved.");
-      Contract.Assume(member.MemberType == MemberTypes.Method, $"The {name} member is not a method.");
-
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Set value
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      member.SetValue(target, value, allowConversion);
-
-    }
+    internal void SetMethodValue(object target, string name, object? value, bool allowConversion = false)
+      => SetValue(target, name, value, allowConversion);
 
     /*==========================================================================================================================
     | METHOD: IS SETTABLE TYPE?