Move expensive SatisfiesAttributeFilters() call to end of loop

The `SatisfiesAttributeFilters()` call should be reasonably fast, but it's expensive compared to the other validation checks in the `PopulateTargetCollectionAsync()` loop, and there's no need to call it if we can easily reject adding a topic because it violates the `ContentTypeFilter`, is a `List`, or `IsDisabled`.

In practice, the most significant impact we'd expect here would be if `[FilterByAttribute()]` is combined with `[FilterByContentType()]`. These used to be the same filter, but since the content type was moved out of attributes, a new filter attribute needed to be introduced. There's no sense in evaluating the attributes if the content type isn't valid.

Author: JeremyCaney

OnTopic/Mapping/TopicMappingService.cs

@@ -921,26 +921,27 @@ MappedTopicCache          cache
 
       foreach (var childTopic in sourceList) {
 
-        //Ensure the source topic matches any [FilterByAttribute()] settings
-        if (!configuration.SatisfiesAttributeFilters(childTopic)) {
+        //Ensure the source topic isn't disabled; disabled topics should never be returned to the presentation layer unless
+        //explicitly requested by a top-level request.
+        if (childTopic.IsDisabled) {
+          continue;
+        }
+
+        //Skip nested topics; those should be explicitly mapped to their own collection or topic reference
+        if (childTopic.ContentType.Equals("List", StringComparison.OrdinalIgnoreCase)) {
           continue;
         }
 
+        //Ensure the source topic matches any [FilterByContentType()] settings
         if (
           configuration.ContentTypeFilter is not null &&
           !childTopic.ContentType.Equals(configuration.ContentTypeFilter, StringComparison.OrdinalIgnoreCase)
         ) {
           continue;
         }
 
-        //Skip nested topics; those should be explicitly mapped to their own collection or topic reference
-        if (childTopic.ContentType.Equals("List", StringComparison.OrdinalIgnoreCase)) {
-          continue;
-        }
-
-        //Ensure the source topic isn't disabled; disabled topics should never be returned to the presentation layer unless
-        //explicitly requested by a top-level request.
-        if (childTopic.IsDisabled) {
+        //Ensure the source topic matches any [FilterByAttribute()] settings
+        if (!configuration.SatisfiesAttributeFilters(childTopic)) {
           continue;
         }