Skip to content

Commit 68d330e

Browse files
committed
Merge branch 'maintenance/XMLDoc-fixes' into develop
Fixed a couple of minor errors in the XML Doc metadata which will cause problems when compiling the XML documentation for use with e.g. DocFx, as proposed in #29.
2 parents c718adc + 8fab56b commit 68d330e

5 files changed

Lines changed: 19 additions & 19 deletions

File tree

OnTopic.AspNetCore.Mvc/TopicViewResultExecutor.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,10 @@ IModelMetadataProvider modelMetadataProvider
5050
/// Loops through potential sources for views to identify the most appropriate <see cref="RazorView"/>.
5151
/// </summary>
5252
/// <remarks>
53-
/// Will look for a view, in order, from the query string (<code>?View=</code>), <see cref="HttpRequest.Headers"/>
54-
/// collection (for matches in the <code>accepts</code> header), then the <see cref="Topic.View"/> property, if set, and
55-
/// finally falls back to the <see cref="Topic.ContentType"/>. If none of those yield any results, will default to a
56-
/// content type of "Page", which expects to find <code>~/Views/Page/Page.cshtml</code>.
53+
/// Will look for a view, in order, from the query string (<c>?View=</c>), <see cref="HttpRequest.Headers"/> collection
54+
/// (for matches in the <c>accepts</c> header), then the <see cref="Topic.View"/> property, if set, and finally falls back
55+
/// to the <see cref="Topic.ContentType"/>. If none of those yield any results, will default to a content type of "Page",
56+
/// which expects to find <c>~/Views/Page/Page.cshtml</c>.
5757
/// </remarks>
5858
/// <param name="actionContext">The <see cref="ActionContext"/> associated with the current request.</param>
5959
/// <param name="viewResult">The <see cref="TopicViewResult"/>.</param>

OnTopic.ViewModels/NavigationTopicViewModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public sealed record NavigationTopicViewModel : INavigationTopicViewModel<Naviga
4646
/*==========================================================================================================================
4747
| WEB PATH
4848
\-------------------------------------------------------------------------------------------------------------------------*/
49-
/// <inheritdoc cref="WebPath"/>
49+
/// <inheritdoc/>
5050
[Required]
5151
public string WebPath { get; init; } = default!;
5252

OnTopic/Associations/ReferenceSetterAttribute.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@ namespace OnTopic.Associations {
1818
/// <para>
1919
/// When a call is made to <see cref="TrackedRecordCollection{TItem, TValue, TAttribute}.SetValue(String, TValue,
2020
/// Boolean?, DateTime?)"/> the code will check to see if a property with the same name as the reference key exists, and
21-
/// whether that property is decorated with the <see cref="ReferenceSetterAttribute"/> (i.e., <code>[ReferenceSetter]
22-
/// </code>). If is, then the update will be routed through that property. This ensures that business logic is enforced by
23-
/// local properties, instead of allowing business logic to be potentially bypassed by writing directly to the <see cref="
24-
/// Topic.References"/> collection.
21+
/// whether that property is decorated with the <see cref="ReferenceSetterAttribute"/> (i.e., <c>[ReferenceSetter]</c>).
22+
/// If is, then the update will be routed through that property. This ensures that business logic is enforced by local
23+
/// properties, instead of allowing business logic to be potentially bypassed by writing directly to the <see cref="Topic.
24+
/// References"/> collection.
2525
/// </para>
2626
/// <para>
2727
/// As an example, the <see cref="Topic.BaseTopic"/> property is adorned with the <see cref="ReferenceSetterAttribute"/>.
28-
/// As a result, if a client calls <code>topic.References.SetValue("BaseTopic", topic)</code>, then that update will be
29-
/// routed through <see cref="Topic.BaseTopic"/>, thus enforcing any validation.
28+
/// As a result, if a client calls <c>topic.References.SetValue("BaseTopic", topic)</c>, then that update will be routed
29+
/// through <see cref="Topic.BaseTopic"/>, thus enforcing any validation.
3030
/// </para>
3131
/// <para>
3232
/// To ensure this logic, it is critical that implementers of <see cref="ReferenceSetterAttribute"/> ensure that the

OnTopic/Attributes/AttributeSetterAttribute.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ namespace OnTopic.Attributes {
1919
/// <para>
2020
/// When a call is made to <see cref="AttributeCollection.SetValue(String, String, Boolean?, DateTime?, Boolean?)"/>, the
2121
/// code will check to see if a property with the same name as the attribute key exists, and whether that property is
22-
/// decorated with the <see cref="AttributeSetterAttribute"/> (i.e., <code>[AttributeSetter]</code>). If it is, then the
23-
/// update will be routed through that property. This ensures that business logic is enforced by local properties, instead
24-
/// of allowing business logic to be potentially bypassed by writing directly to the <see cref="Topic.Attributes"/>
22+
/// decorated with the <see cref="AttributeSetterAttribute"/> (i.e., <c>[AttributeSetter]</c>). If it is, then the update
23+
/// will be routed through that property. This ensures that business logic is enforced by local properties, instead of
24+
/// allowing business logic to be potentially bypassed by writing directly to the <see cref="Topic.Attributes"/>
2525
/// collection.
2626
/// </para>
2727
/// <para>

OnTopic/Internal/Diagnostics/Contract.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@ namespace OnTopic.Internal.Diagnostics {
2424
/// <para>
2525
/// <see cref="Contract"/> is not a replacement for Microsoft's Code Contract analysis and rewrite modules. Instead, it
2626
/// aims to maintain basic synatactical and functional support for the most basic (and important) features of the rewrite
27-
/// module, such as <code>Contract.Requires()</code>, which is necessary to ensure paramater validation in many methods
27+
/// module, such as <c>Contract.Requires()</c>, which is necessary to ensure paramater validation in many methods
2828
/// throughout the OnTopic library. <see cref="Contract"/> does not seek to functionally reproduce Code Contract's
29-
/// <code>Ensures()</code>, <code>Assume()</code>, or <code>Invariant()</code>—those methods are not implemented.
29+
/// <c>Ensures()</c>, <c>Assume()</c>, or <c>Invariant()</c>—those methods are not implemented.
3030
/// </para>
3131
/// <para>
32-
/// C# 8.0 will introduce nullable reference types. This largely mitigates the need for <code>Contract.Requires()</code>.
33-
/// As such, this library can be seen as a temporary bridge to maintain parameter validation until C# 8.0 is released. At
34-
/// that point, nullable reference types should be used in preference for many of the <code>Contract.Requires()</code>
32+
/// C# 8.0 will introduce nullable reference types. This largely mitigates the need for <c>Contract.Requires()</c>. As
33+
/// such, this library can be seen as a temporary bridge to maintain parameter validation until C# 8.0 is released. At
34+
/// that point, nullable reference types should be used in preference for many of the <c>Contract.Requires()</c>
3535
/// calls—though, acknowledging, that there are some conditions that won't be satisfied by that (e.g., range checks).
3636
/// </para>
3737
/// <para>

0 commit comments

Comments
 (0)