Initialized `_cache_ as part of constructor

Whenever a `CachedTopicRepository` is called, it checked to see if the `_cache` was initialized. This should not be necessary. If a `CachedTopicRepository` is required, then it should immediately load its cache so it's ready for the first request. In most scenarios, this won't change the load time (as the `Load()` method will be called shortly after establishing the cache), but it does simplify the internal logic.

Author: JeremyCaney

Ignia.Topics.Data.Caching/CachedTopicRepository.cs

@@ -51,6 +51,11 @@ public CachedTopicRepository(ITopicRepository dataProvider) : base() {
       \-----------------------------------------------------------------------------------------------------------------------*/
       _dataProvider = dataProvider;
 
+      /*------------------------------------------------------------------------------------------------------------------------
+      | Ensure topics are loaded
+      \-----------------------------------------------------------------------------------------------------------------------*/
+      _cache = _dataProvider.Load();
+
     }
 
     /*==========================================================================================================================
@@ -72,13 +77,6 @@ public CachedTopicRepository(ITopicRepository dataProvider) : base() {
     /// <returns>A topic object.</returns>
     public override Topic Load(int topicId, bool isRecursive = true) {
 
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Ensure topics are loaded
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      if (_cache == null) {
-        _cache = _dataProvider.Load();
-      }
-
       /*------------------------------------------------------------------------------------------------------------------------
       | Handle request for entire tree
       \-----------------------------------------------------------------------------------------------------------------------*/
@@ -101,13 +99,6 @@ public override Topic Load(int topicId, bool isRecursive = true) {
     /// <returns>A topic object.</returns>
     public override Topic Load(string topicKey = null, bool isRecursive = true) {
 
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Ensure topics are loaded
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      if (_cache == null) {
-        _cache = _dataProvider.Load();
-      }
-
       /*------------------------------------------------------------------------------------------------------------------------
       | Lookup by TopicKey
       \-----------------------------------------------------------------------------------------------------------------------*/
@@ -218,8 +209,8 @@ private Topic GetTopic(Topic sourceTopic, string uniqueKey) {
     /// <param name="isDraft">Boolean indicator as to the topic's publishing status.</param>
     /// <returns>The integer return value from the execution of the <c>topics_UpdateTopic</c> stored procedure.</returns>
     /// <exception cref="Exception">
-    ///   The Content Type <c>topic.Attributes.GetValue(ContentType, Page)</c> referenced by <c>topic.Key</c> could not be found under
-    ///   Configuration:ContentTypes. There are <c>TopicRepository.ContentTypes.Count</c> ContentTypes in the Repository.
+    ///   The Content Type <c>topic.Attributes.GetValue(ContentType, Page)</c> referenced by <c>topic.Key</c> could not be found
+    ///   under Configuration:ContentTypes. There are <c>TopicRepository.ContentTypes.Count</c> ContentTypes in the Repository.
     /// </exception>
     /// <exception cref="Exception">
     ///   Failed to save Topic <c>topic.Key</c> (<c>topic.Id</c>) via