Merge branch 'maintenance/net5.0-hosts' into develop

If a .NET Standard or even a .NET 3.x library is called from an application running .NET 5, then those libraries will also be executed using the .NET 5 runtime. As such, there's no reason to upgrade or even multi-target libraries to .NET 5 unless they need to take advantage of specific .NET 5 capabilities. None of the core OnTopic libraries currently need any of these capabilities, so they can remain in .NET Standard 2.1. This allows them to remain compatible with .NET 3.x while still taking advantage of e.g. performance improvements in .NET 5.

That said, we expect most implementors will be using .NET 5, since it's usually a painless upgrade from .NET Core 3 and offers significant performance benefits. As such, it makes sense to upgrade the unit test libraries as well as the sample `Host` project to .NET 5 both to reflect real-world runtime conditions expected, but also to take advantage of those performance improvements.

This update does just that.

Author: JeremyCaney

OnTopic.AspNetCore.Mvc.Host/OnTopic.AspNetCore.Mvc.Host.csproj

@@ -1,8 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp3.1</TargetFrameworks>
-    <LangVersion>9.0</LangVersion>
+    <TargetFrameworks>net5.0</TargetFrameworks>
     <UserSecretsId>62eb85bf-f802-4afd-8bec-3d344e1cfc79</UserSecretsId>
     <IsPackable>false</IsPackable>
   </PropertyGroup>
@@ -18,4 +17,4 @@
     <ProjectReference Include="..\OnTopic.All\OnTopic.All.csproj" />
   </ItemGroup>
 
-</Project>
+</Project>

OnTopic.AspNetCore.Mvc.Tests/OnTopic.AspNetCore.Mvc.Tests.csproj

@@ -1,8 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp3.1</TargetFrameworks>
-    <LangVersion>9.0</LangVersion>
+    <TargetFrameworks>net5.0</TargetFrameworks>
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 
@@ -18,11 +17,7 @@
 
   <ItemGroup>
     <ProjectReference Include="..\OnTopic.AspNetCore.Mvc.Host\OnTopic.AspNetCore.Mvc.Host.csproj" />
-    <ProjectReference Include="..\OnTopic.AspNetCore.Mvc\OnTopic.AspNetCore.Mvc.csproj" />
-    <ProjectReference Include="..\OnTopic.Data.Caching\OnTopic.Data.Caching.csproj" />
     <ProjectReference Include="..\OnTopic.TestDoubles\OnTopic.TestDoubles.csproj" />
-    <ProjectReference Include="..\OnTopic.ViewModels\OnTopic.ViewModels.csproj" />
-    <ProjectReference Include="..\OnTopic\OnTopic.csproj" />
   </ItemGroup>
 
-</Project>
+</Project>

OnTopic.AspNetCore.Mvc.Tests/TopicViewComponentTest.cs

@@ -3,7 +3,6 @@
 | Client        Ignia, LLC
 | Project       Topics Library
 \=============================================================================================================================*/
-using System.Linq;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Mvc.Rendering;

OnTopic.AspNetCore.Mvc.Tests/ValidateTopicAttributeTest.cs

@@ -10,7 +10,6 @@
 using Microsoft.AspNetCore.Mvc.Controllers;
 using Microsoft.AspNetCore.Mvc.Filters;
 using Microsoft.AspNetCore.Mvc.ModelBinding;
-using Microsoft.AspNetCore.Routing;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using OnTopic.AspNetCore.Mvc;
 using OnTopic.AspNetCore.Mvc.Controllers;

OnTopic.AspNetCore.Mvc/Components/PageLevelNavigationViewComponentBase{T}.cs

@@ -3,7 +3,6 @@
 | Client        Ignia, LLC
 | Project       Topics Library
 \=============================================================================================================================*/
-using System;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Mvc;
 using OnTopic.AspNetCore.Mvc.Models;

OnTopic.Data.Sql/SqlDataReaderExtensions.cs

@@ -10,7 +10,6 @@
 using System.Linq;
 using System.Net;
 using Microsoft.Data.SqlClient;
-using OnTopic.Collections;
 using OnTopic.Collections.Specialized;
 using OnTopic.Internal.Diagnostics;
 using OnTopic.Querying;

OnTopic.Tests/BindingModels/ReferenceTopicBindingModel.cs

@@ -3,7 +3,6 @@
 | Client        Ignia, LLC
 | Project       Topics Library
 \=============================================================================================================================*/
-using OnTopic.Mapping.Annotations;
 using OnTopic.ViewModels.BindingModels;
 
 namespace OnTopic.Tests.BindingModels {

OnTopic.Tests/ITypeLookupServiceTest.cs

@@ -6,7 +6,6 @@
 using System;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using OnTopic.Lookup;
-using OnTopic.Metadata;
 using OnTopic.Tests.TestDoubles;
 using OnTopic.Tests.ViewModels;
 using OnTopic.ViewModels;

OnTopic.Tests/Internal/IsExternalInit.cs

@@ -0,0 +1,19 @@
+/*==============================================================================================================================
+| Author        Ignia, LLC
+| Client        Ignia, LLC
+| Project       Topics Library
+\=============================================================================================================================*/
+
+namespace System.Runtime.CompilerServices {
+
+  /*============================================================================================================================
+  | CLASS: IS EXTERNAL INIT
+  \---------------------------------------------------------------------------------------------------------------------------*/
+  /// <summary>
+  ///   The <see cref="IsExternalInit"/> class is made available as part of the .NET 5.0 CLR in order to enable init accessors.
+  ///   As this is not available in .NET Standard, however, we must maintain this separate copy until we migrate to .NET 5.0.
+  /// </summary>
+  internal static class IsExternalInit {
+
+  } //Class
+} //Namespace

OnTopic.Tests/KeyedTopicCollectionTest.cs

@@ -6,7 +6,6 @@
 using System.Collections.Generic;
 using System.Linq;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
-using OnTopic.Attributes;
 using OnTopic.Collections;
 
 namespace OnTopic.Tests {