Reorder GetValue() based on how common each condition is

Previously, `GetValue()` was ordered according to popularity (with the exception of the compatibility check, which must come first). These were recently reordered to make sure that the fastest calls were placed upfront, thus preventing lookups when they weren't needed (565fa6f). With the caching of `IsList` and `IsConvertible` (d0fb8a4), however, that is no longer a concern. As such, we can return to prioritizing based on how common each is, thus reducing the number of conditions each property (or parameter) must be considered for.

Author: JeremyCaney

OnTopic/Mapping/TopicMappingService.cs

@@ -525,20 +525,20 @@ await MapAsync(
       if (TryGetCompatibleProperty(source, targetType, configuration, out var compatibleValue)) {
         value = compatibleValue;
       }
-      else if (configuration.MapToParent) {
+      else if (configuration.Metadata.IsConvertible) {
+        if (!mapAssociationsOnly) {
+          value = GetScalarValue(source, configuration);
+        }
+      }
+      else if (configuration.Metadata.IsList) {
         return null;
       }
       else if (configuration.AttributeKey is "Parent") {
         if (associations.HasFlag(AssociationTypes.Parents) && source.Parent is not null) {
           value = await GetTopicReferenceAsync(source.Parent, targetType, configuration, cache).ConfigureAwait(false);
         }
       }
-      else if (configuration.Metadata.IsConvertible) {
-        if (!mapAssociationsOnly) {
-          value = GetScalarValue(source, configuration);
-        }
-      }
-      else if (configuration.Metadata.IsList) {
+      else if (configuration.MapToParent) {
         return null;
       }
       else if (configuration.Metadata.Type.IsClass && associations.HasFlag(AssociationTypes.References)) {