Updated version to use SqlDateTime

The `DateTime` data type in SQL has a lower precision than the `DateTime` data type in C#. As a result, when storing the `version` in `topic.VersionHistory`, a different version was getting saved than in the database. In practice, this resulted in an inability to roll back versions that had been created since the last application reset. (Previous versions worked, as they were loaded with the lower-precision value from the database.) This is mitigated by instead initializing the `version` variable as a `SqlDateTime` object, which uses the same precision as the database.

While I was at it, I move the `VersionHistory` insert into the `try/catch` block so that a `version` won't be prepended if there was an error during the `Save()` operation. (In practice, this is unlikely, and we haven't had any reports of this being a concern, but it's an easy fix to make while modifying the code.)

Author: JeremyCaney

OnTopic.Data.Sql/SqlTopicRepository.cs

@@ -5,6 +5,7 @@
 \=============================================================================================================================*/
 using System;
 using System.Data;
+using System.Data.SqlTypes;
 using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Linq;
@@ -333,7 +334,7 @@ public override int Save([NotNull]Topic topic, bool isRecursive = false, bool is
       var command               = new SqlCommand(procedureName, connection) {
         CommandType             = CommandType.StoredProcedure
       };
-      var version               = DateTime.Now;
+      var version               = new SqlDateTime(DateTime.Now);
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Establish query parameters
@@ -344,11 +345,11 @@ public override int Save([NotNull]Topic topic, bool isRecursive = false, bool is
       else if (topic.Parent != null) {
         command.AddParameter("ParentID", topic.Parent.Id);
       }
-      command.AddParameter("Version", version);
       command.Parameters.AddWithValue("@Attributes", attributes);
       if (!isNew) {
         command.AddParameter("DeleteRelationships", true);
       }
+      command.AddParameter("Version", version.Value);
       command.AddParameter("ExtendedAttributes", extendedAttributes);
       command.AddOutputParameter();
 
@@ -369,6 +370,8 @@ public override int Save([NotNull]Topic topic, bool isRecursive = false, bool is
 
         PersistRelations(topic, connection, true);
 
+        topic.VersionHistory.Insert(0, version.Value);
+
       }
 
       /*------------------------------------------------------------------------------------------------------------------------
@@ -390,11 +393,6 @@ public override int Save([NotNull]Topic topic, bool isRecursive = false, bool is
         attributes.Dispose();
       }
 
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Add version to version history
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      topic.VersionHistory.Insert(0, version);
-
       /*------------------------------------------------------------------------------------------------------------------------
       | Recurse
       \-----------------------------------------------------------------------------------------------------------------------*/