Introduced new GetTopicId() extension method

The logic for retrieving a `TopicID` is a bit different than retrieving an attribute that happens to be an integer since it doesn't require a conversion, and can be retrieved directly as an integer. By sharing `GetInteger()` for both use cases, we were requiring that the `TopicID` be converted to a string and then back to an integer for _every single topic_—and sometimes more frequently (for relationships). By introducing the `GetTopicId()` extension, we prevent this unnecessary overhead. It's a relatively trivial improvement, but it doesn't require much code, and it also provides a bit more specific semantics (i.e., `GetTopicId()` instead of `GetInteger("TopicID")`.

Author: JeremyCaney

OnTopic.Data.Sql/SqlDataReaderExtensions.cs

@@ -34,6 +34,16 @@ internal static class SqlDataReaderExtensions {
     /// <param name="columnName">The name of the column to retrieve the value from.</param>
     internal static int GetInteger(this SqlDataReader reader, string columnName) =>
       GetValue<int>(reader, columnName, Int32.TryParse, -1);
+    /*==========================================================================================================================
+    | METHOD: GET TOPIC ID
+    \-------------------------------------------------------------------------------------------------------------------------*/
+    /// <summary>
+    ///   Retrieves a <see cref="Topic.Id"/> value by column name.
+    /// </summary>
+    /// <param name="reader">The <see cref="SqlDataReader"/> object.</param>
+    /// <param name="columnName">The name of the column to retrieve the value from.</param>
+    internal static int GetTopicId(this SqlDataReader reader, string columnName = "TopicID") =>
+      reader.GetInt32(reader.GetOrdinal(columnName));
 
     /*==========================================================================================================================
     | METHOD: GET STRING

OnTopic.Data.Sql/SqlTopicRepository.cs

@@ -69,7 +69,7 @@ private static void AddTopic(SqlDataReader reader, Dictionary<int, Topic> topics
       /*------------------------------------------------------------------------------------------------------------------------
       | Identify attributes
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var id                    = reader.GetInteger("TopicID");
+      var id                    = reader.GetTopicId();
       var key                   = reader.GetString("TopicKey");
       var contentType           = reader.GetString("ContentType");
       var parentId              = reader.GetInteger("ParentID");
@@ -98,7 +98,7 @@ private static void SetIndexedAttributes(SqlDataReader reader, Dictionary<int, T
       /*------------------------------------------------------------------------------------------------------------------------
       | Identify attributes
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var id                    = reader.GetInteger("TopicID");
+      var id                    = reader.GetTopicId();
       var name                  = reader.GetString("AttributeKey");
       var value                 = reader.GetString("AttributeValue");
       var version               = DateTime.Now;
@@ -149,7 +149,7 @@ private static void SetExtendedAttributes(SqlDataReader reader, Dictionary<int,
       /*------------------------------------------------------------------------------------------------------------------------
       | Identify attributes
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var id                    = reader.GetInteger("TopicID");
+      var id                    = reader.GetTopicId();
       var version               = DateTime.Now;
 
       //Check field count to avoid breaking changes with the 4.0.0 release, which didn't include a "Version" column
@@ -225,8 +225,8 @@ private static void SetRelationships(SqlDataReader reader, Dictionary<int, Topic
       /*------------------------------------------------------------------------------------------------------------------------
       | Identify attributes
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var sourceTopicId         = reader.GetInteger("Source_TopicID");
-      var targetTopicId         = reader.GetInteger("Target_TopicID");
+      var sourceTopicId         = reader.GetTopicId("Source_TopicID");
+      var targetTopicId         = reader.GetTopicId("Target_TopicID");
       var relationshipKey       = reader.GetString("RelationshipKey");
 
       /*------------------------------------------------------------------------------------------------------------------------
@@ -296,7 +296,7 @@ private static void SetVersionHistory(SqlDataReader reader, Dictionary<int, Topi
       /*------------------------------------------------------------------------------------------------------------------------
       | Identify attributes
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var sourceTopicId         = reader.GetInteger("TopicID");
+      var sourceTopicId         = reader.GetTopicId();
       var dateTime              = reader.GetVersion();
 
       /*------------------------------------------------------------------------------------------------------------------------