Replaced Count() with either Count or Length

The built-in counting properties, such as `Count` and `Length`, are far more efficient than using LINQ's `Count()` extension method. This only affected our unit tests, but it should still be resolved. This issue was exposed by updates to the Microsoft Code Analyzers (see #865195f).

Author: JeremyCaney

OnTopic.Data.Sql/SqlTopicRepository.cs

@@ -1195,7 +1195,7 @@ private static string CreateRelationshipsXml(Topic topic) {
         attributesXml.Append("\">");
 
         // Build out string array of related items in this scope
-        var targetIds = new string[scope.Count()];
+        var targetIds = new string[scope.Count];
         var count = 0;
         foreach (var relTopic in scope) {
           targetIds[count] = relTopic.Id.ToString(CultureInfo.InvariantCulture);

OnTopic.Tests/ITopicRepositoryTest.cs

@@ -167,14 +167,14 @@ public void Move_ToNewParent_ConfirmedMove() {
       var topic                 = _topicRepository.Load("Root:Web:Web_0:Web_0_1");
 
       Assert.ReferenceEquals(topic.Parent, source);
-      Assert.AreEqual<int>(2, destination.Children.Count());
-      Assert.AreEqual<int>(2, source.Children.Count());
+      Assert.AreEqual<int>(2, destination.Children.Count);
+      Assert.AreEqual<int>(2, source.Children.Count);
 
       _topicRepository.Move(topic, destination);
 
       Assert.ReferenceEquals(topic.Parent, destination);
-      Assert.AreEqual<int>(1, source.Children.Count());
-      Assert.AreEqual<int>(3, destination.Children.Count());
+      Assert.AreEqual<int>(1, source.Children.Count);
+      Assert.AreEqual<int>(3, destination.Children.Count);
 
     }
 
@@ -193,12 +193,12 @@ public void Move_ToNewSibling_ConirmedMove() {
 
       Assert.ReferenceEquals(topic.Parent, parent);
       Assert.AreEqual<string>("Web_0_0", parent.Children.First().Key);
-      Assert.AreEqual<int>(2, parent.Children.Count());
+      Assert.AreEqual<int>(2, parent.Children.Count);
 
       _topicRepository.Move(topic, parent, sibling);
 
       Assert.ReferenceEquals(topic.Parent, parent);
-      Assert.AreEqual<int>(2, parent.Children.Count());
+      Assert.AreEqual<int>(2, parent.Children.Count);
       Assert.AreEqual<string>("Web_0_1", parent.Children.First().Key);
       Assert.AreEqual<string>("Web_0_0", parent.Children[1].Key);
 
@@ -217,11 +217,11 @@ public void Delete_Topic_Removed() {
       var topic                 = _topicRepository.Load("Root:Web:Web_1:Web_1_1");
       var child                 = _topicRepository.Load("Root:Web:Web_1:Web_1_1:Web_1_1_0");
 
-      Assert.AreEqual<int>(2, parent.Children.Count());
+      Assert.AreEqual<int>(2, parent.Children.Count);
 
       _topicRepository.Delete(topic);
 
-      Assert.AreEqual<int>(1, parent.Children.Count());
+      Assert.AreEqual<int>(1, parent.Children.Count);
 
     }
 

OnTopic.Tests/RelatedTopicCollectionTest.cs

@@ -95,7 +95,7 @@ public void GetAllTopics_ReturnsAllTopics() {
 
       Assert.AreEqual<int>(5, relationships.Count);
       Assert.AreEqual<string>("Related3", relationships.GetTopics("Relationship3").First().Key);
-      Assert.AreEqual<int>(5, relationships.GetAllTopics().Count());
+      Assert.AreEqual<int>(5, relationships.GetAllTopics().Count);
 
     }
 
@@ -117,7 +117,7 @@ public void GetAllContentTypes_ReturnsAllContentTypes() {
       }
 
       Assert.AreEqual<int>(5, relationships.Count);
-      Assert.AreEqual<int>(1, relationships.GetAllTopics("ContentType3").Count());
+      Assert.AreEqual<int>(1, relationships.GetAllTopics("ContentType3").Count);
 
     }
 

OnTopic.Tests/TopicTest.cs

@@ -204,7 +204,7 @@ public void FindAllByAttribute_ReturnsCorrectTopics() {
       grandNieceTopic.Attributes.SetValue("Foo", "Bar");
 
       Assert.ReferenceEquals(parentTopic.FindAllByAttribute("Foo", "Bar").First(), grandNieceTopic);
-      Assert.AreEqual<int>(2, parentTopic.FindAllByAttribute("Foo", "Bar").Count());
+      Assert.AreEqual<int>(2, parentTopic.FindAllByAttribute("Foo", "Bar").Count);
       Assert.ReferenceEquals(parentTopic.FindAllByAttribute("Foo", "Baz").First(), grandChildTopic);
 
     }

OnTopic/Internal/Reflection/TypeMemberInfoCollection.cs

@@ -268,7 +268,7 @@ public bool HasSettableMethod(Type type, string name) {
       var method = GetMember<MethodInfo>(type, name);
       return (
         method != null &&
-        method.GetParameters().Count().Equals(1) &&
+        method.GetParameters().Length.Equals(1) &&
         IsSettableType(method.GetParameters().First().ParameterType) &&
         (_attributeFlag == null || System.Attribute.IsDefined(method, _attributeFlag))
       );