Move variables to top of Save()

This not only makes it easier to get a sense of `Save()'s scope of responsibility, but more importantly will allow us to introduce an escape clause for `isDirty` in a future commit, thus preventing the need to do subsequent processing if `!isDirty`.

As part of this, renamed `excludeLastModified` to `areAttributesDirty`, which is more descriptive given that it's no longer being used exclusively for tracking `excludeLastModified`. This is more consistent with `areRelationshipsDirty` as well.

Author: JeremyCaney

OnTopic.Data.Sql/SqlTopicRepository.cs

@@ -332,6 +332,36 @@ List<Topic> unresolvedRelationships
       \-----------------------------------------------------------------------------------------------------------------------*/
       base.Save(topic, isRecursive, isDraft);
 
+      /*------------------------------------------------------------------------------------------------------------------------
+      | Define variables
+      \-----------------------------------------------------------------------------------------------------------------------*/
+      var isNew                 = topic.Id == -1;
+      var version               = new SqlDateTime(DateTime.Now);
+      var areReferencesResolved = true;
+      var areRelationshipsDirty = topic.Relationships.IsDirty();
+      var areAttributesDirty    = topic.Attributes.IsDirty(excludeLastModified: true);
+      var extendedAttributeList = GetAttributes(topic, isExtendedAttribute: true);
+      var indexedAttributeList  = GetAttributes(
+        topic                   : topic,
+        isExtendedAttribute     : false,
+        isDirty                 : true,
+        excludeLastModified     : !areAttributesDirty
+      );
+
+      /*------------------------------------------------------------------------------------------------------------------------
+      | Detect whether anything has changed
+      >-------------------------------------------------------------------------------------------------------------------------
+      | If no relationships have changed, and no attributes values have changed, and there aren't any mismatched attributes in
+      | their respective lists, then there isn't anything new to persist to the database, and thus no benefit to executing the
+      | current command. A more aggressive version of this would wrap much of the below logic in this, but this is just meant
+      | as a quick fix to reduce the overhead of recursive saves.
+      \-----------------------------------------------------------------------------------------------------------------------*/
+      var isDirty               =
+        areRelationshipsDirty   ||
+        areAttributesDirty      ||
+        indexedAttributeList.Any() ||
+        extendedAttributeList.Any(a => a.IsExtendedAttribute == false);
+
       /*------------------------------------------------------------------------------------------------------------------------
       | Establish attribute containers with schema
       \-----------------------------------------------------------------------------------------------------------------------*/
@@ -352,18 +382,6 @@ List<Topic> unresolvedRelationships
       /*------------------------------------------------------------------------------------------------------------------------
       | Add indexed attributes that are dirty
       \-----------------------------------------------------------------------------------------------------------------------*/
-
-      //Only include `LastModified` and/or `LastModifiedBy` if other attributes in the collection are `IsDirty`, as these are
-      //automatically generated and don't represent genuine changes to the topic.
-      var excludeLastModified   = !topic.Attributes.IsDirty(excludeLastModified: true);
-
-      var indexedAttributeList  = GetAttributes(
-        topic                   : topic,
-        isExtendedAttribute     : false,
-        isDirty                 : true,
-        excludeLastModified     : excludeLastModified
-      );
-
       foreach (var attributeValue in indexedAttributeList) {
 
         var record              = attributes.NewRow();
@@ -380,8 +398,6 @@ List<Topic> unresolvedRelationships
       \-----------------------------------------------------------------------------------------------------------------------*/
       extendedAttributes.Append("<attributes>");
 
-      var extendedAttributeList = GetAttributes(topic, isExtendedAttribute:true);
-
       foreach (var attributeValue in extendedAttributeList) {
 
         extendedAttributes.Append(
@@ -419,14 +435,10 @@ void addUnmatchedAttribute(string key) {
       /*------------------------------------------------------------------------------------------------------------------------
       | Establish database connection
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var isNew                 = topic.Id == -1;
       var procedureName         = isNew? "CreateTopic" : "UpdateTopic";
       var command               = new SqlCommand(procedureName, connection) {
         CommandType             = CommandType.StoredProcedure
       };
-      var version               = new SqlDateTime(DateTime.Now);
-      var areReferencesResolved = true;
-      var areRelationshipsDirty = topic.Relationships.IsDirty();
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Handle unresolved references
@@ -440,20 +452,6 @@ void addUnmatchedAttribute(string key) {
         areReferencesResolved = false;
       }
 
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Detect whether anything has changed
-      >-------------------------------------------------------------------------------------------------------------------------
-      | If no relationships have changed, and no attributes values have changed, and there aren't any mismatched attributes in
-      | their respective lists, then there isn't anything new to persist to the database, and thus no benefit to executing the
-      | current command. A more aggressive version of this would wrap much of the below logic in this, but this is just meant
-      | as a quick fix to reduce the overhead of recursive saves.
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      var isDirty               =
-        areRelationshipsDirty   ||
-        !excludeLastModified    ||
-        indexedAttributeList.Any() ||
-        extendedAttributeList.Any(a => a.IsExtendedAttribute == false);
-
       /*------------------------------------------------------------------------------------------------------------------------
       | Establish query parameters
       \-----------------------------------------------------------------------------------------------------------------------*/