Commit c61a3b0
committed
Introduced
The `[DisableMapping]` capability was originally introduced as part of the `ReverseTopicMappingService`, to instruct it not to map particular properties back the target `Topic` entity. There's no reason the opposite shouldn't also be supported on the `TopicMappingService`—nor is it all that difficult to add this feature. That said, while this feature was a necessity on the `ReverseTopicMappingService` (since it will throw an exception if a corresponding `AttributeDescriptor` can't be found) it provides less necessity on the `TopicMappingService` (since a missing attribute will simply skip over the property). Still, this may be useful for cases where a property should be provided which maps to a valid attribute, but the value should be set separately—perhaps as part of a hard-coded default. While a rare edge case, it's just a few lines of code to support this, and it eliminates the attributes supported on the `ReverseTopicMappingService` but not also the `TopicMappingService`, thus simplifying the documentation.[DisableMapping] functionality to TopicMappingService
1 parent 58949b1 commit c61a3b0
5 files changed
Lines changed: 51 additions & 4 deletions
File tree
- OnTopic.Tests
- TestDoubles
- ViewModels
- OnTopic/Mapping
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
106 | 125 | | |
107 | 126 | | |
108 | 127 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
107 | | - | |
108 | | - | |
109 | | - | |
| 107 | + | |
110 | 108 | | |
111 | 109 | | |
112 | 110 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
264 | 264 | | |
265 | 265 | | |
266 | 266 | | |
267 | | - | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
268 | 271 | | |
269 | 272 | | |
270 | 273 | | |
| |||
0 commit comments