Merge branch 'maintenance/code-analysis' into develop

A few unaddressed warnings from Code Analysis had crept in during the 5.0.1 updates, which have been addressed as part of this update.

Author: JeremyCaney

OnTopic.AspNetCore.Mvc.Tests/ValidateTopicAttributeTest.cs

@@ -63,6 +63,7 @@ public static ActionExecutingContext GetActionExecutingContext(Controller contro
     /// <summary>
     ///   Generates a barebones <see cref="ControllerContext"/> for testing a controller.
     /// </summary>
+    #pragma warning disable CA1024 // Use properties where appropriate
     public static ControllerContext GetControllerContext() =>
       new(
         new() {
@@ -71,6 +72,7 @@ public static ControllerContext GetControllerContext() =>
           ActionDescriptor          = new ControllerActionDescriptor()
         }
       );
+    #pragma warning restore CA1024 // Use properties where appropriate
 
     /*==========================================================================================================================
     | METHOD: GET TOPIC CONTROLLER

OnTopic.Tests/AttributeCollectionTest.cs

@@ -449,9 +449,9 @@ public void SetValue_ValueChanged_IsDirty() {
     [Fact]
     public void Clear_NonNullableValueWithBusinessLogic_ThrowsException() {
 
-      var topic = new CustomTopic("Test", "Page");
-
-      topic.NonNullableAttribute = "Test";
+      var topic                 = new CustomTopic("Test", "Page") {
+        NonNullableAttribute    = "Test"
+      };
 
       Assert.Throws<ArgumentNullException>(() =>
         topic.Attributes.Clear()

OnTopic.Tests/Fixtures/SharedRepositoryCollection.cs

@@ -6,6 +6,8 @@
 using OnTopic.TestDoubles;
 using Xunit;
 
+#pragma warning disable CA1711 // Identifiers should not have incorrect suffix
+
 namespace OnTopic.Tests.Fixtures {
 
   /*============================================================================================================================
@@ -20,3 +22,5 @@ public class SharedRepositoryCollection: ICollectionFixture<TopicInfrastructureF
 
   }
 }
+
+#pragma warning restore CA1711 // Identifiers should not have incorrect suffix

OnTopic.Tests/TopicMappingServiceTest.cs

@@ -680,7 +680,7 @@ public async Task Map_AlternateRelationship_ReturnsCorrectRelationship() {
     [Fact]
     public async Task Map_CustomCollection_ReturnsCollection() {
 
-      var topic                 = (ContentTypeDescriptor)_topicRepository.Load("Root:Configuration:ContentTypes:Page");
+      var topic                 = (ContentTypeDescriptor?)_topicRepository.Load("Root:Configuration:ContentTypes:Page");
       var target                = await _mappingService.MapAsync<ContentTypeDescriptorTopicViewModel>(topic).ConfigureAwait(false);
 
       Assert.Equal<int?>(8, target?.AttributeDescriptors.Count);

OnTopic.Tests/ViewModels/MethodBasedReferenceViewModel.cs

@@ -21,7 +21,10 @@ public class MethodBasedReferenceViewModel {
     private TopicViewModel? _methodValue;
 
     public void SetMethod(TopicViewModel? methodValue) => _methodValue = methodValue;
+
+    #pragma warning disable CA1024 // Use properties where appropriate
     public TopicViewModel? GetMethod() => _methodValue;
+    #pragma warning restore CA1024 // Use properties where appropriate
 
   } //Class
 } //Namespace