Commit d7a61cd
committed
Ensured
This is embarrassing, but it seems the basic `Move()` overload in `TopicRepositoryBase` doesn't refer to the more complete `Move()` overload, nor does it do so in any of the concrete implementations. As a result, it is effectively unimplemented, and won't persist any changes to the database.
This is fixed here by simply referring it to the more complete overload (which additionally accepts `sibling`).
This also exposes a bigger issue: Most of these `public` methods should be marked as `abstract` since they're not fully implemented, and just intended to provide common support. That breaks the public contract, though, so will need to wait for 5.0.0.Move() overload properly functions1 parent dcdbab2 commit d7a61cd
1 file changed
Lines changed: 1 addition & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
387 | 387 | | |
388 | 388 | | |
389 | 389 | | |
390 | | - | |
391 | | - | |
392 | | - | |
393 | | - | |
394 | | - | |
395 | | - | |
396 | | - | |
397 | | - | |
398 | | - | |
399 | | - | |
400 | | - | |
401 | | - | |
402 | | - | |
403 | | - | |
| 390 | + | |
404 | 391 | | |
405 | 392 | | |
406 | 393 | | |
| |||
0 commit comments