Introduced IsExtendedAttribute support for CreateFakeData()

Previously, while the `StubTopicRepository` introduced a number of common `ContentTypeDescriptor` and `AttributeDescriptor` definitions, it didn't set the `IsExtendedAttribute` definition.

In preparation for adding unit tests for `GetAttributes()`, we're introducing support for this by extending the local helper function `addAttribute()`, and factoring that into the definitions.

This should remain backwards compatible since no existing tests are relying on or referencing these data.

Author: JeremyCaney

OnTopic.TestDoubles/StubTopicRepository.cs

@@ -183,10 +183,10 @@ private Topic CreateFakeData() {
       var configuration = TopicFactory.Create("Configuration", "Container", rootTopic);
       var contentTypes = TopicFactory.Create("ContentTypes", "ContentTypeDescriptor", configuration);
 
-      addAttribute(contentTypes, "Key", "TextAttribute", true);
-      addAttribute(contentTypes, "ContentType", "TextAttribute", true);
-      addAttribute(contentTypes, "Title", "TextAttribute", true);
-      addAttribute(contentTypes, "TopicId", "TopicReferenceAttribute");
+      addAttribute(contentTypes, "Key", "TextAttribute", false, true);
+      addAttribute(contentTypes, "ContentType", "TextAttribute", false, true);
+      addAttribute(contentTypes, "Title", "TextAttribute", true, true);
+      addAttribute(contentTypes, "TopicId", "TopicReferenceAttribute", false);
 
       var contentTypeDescriptor = TopicFactory.Create("ContentTypeDescriptor", "ContentTypeDescriptor", contentTypes);
 
@@ -200,8 +200,8 @@ private Topic CreateFakeData() {
 
       var attributeDescriptor = (ContentTypeDescriptor)TopicFactory.Create("AttributeDescriptor", "ContentTypeDescriptor", contentTypes);
 
-      addAttribute(attributeDescriptor, "DefaultValue", "TextAttribute", true);
-      addAttribute(attributeDescriptor, "IsRequired", "BooleanAttribute", true);
+      addAttribute(attributeDescriptor, "DefaultValue", "TextAttribute", false, true);
+      addAttribute(attributeDescriptor, "IsRequired", "TextAttribute", false, true);
 
       TopicFactory.Create("BooleanAttribute", "ContentTypeDescriptor", attributeDescriptor);
       TopicFactory.Create("NestedTopicListAttribute", "ContentTypeDescriptor", attributeDescriptor);
@@ -214,29 +214,36 @@ private Topic CreateFakeData() {
 
       addAttribute(pageContentType, "MetaTitle");
       addAttribute(pageContentType, "MetaDescription");
-      addAttribute(pageContentType, "IsHidden");
-      addAttribute(pageContentType, "TopicReference", "TopicReferenceAttribute");
+      addAttribute(pageContentType, "IsHidden", "TextAttribute", false);
+      addAttribute(pageContentType, "TopicReference", "TopicReferenceAttribute", false);
 
       pageContentType.Relationships.SetTopic("ContentTypes", pageContentType);
       pageContentType.Relationships.SetTopic("ContentTypes", contentTypeDescriptor);
 
       var contactContentType = TopicFactory.Create("Contact", "ContentTypeDescriptor", contentTypes);
 
-      addAttribute(contactContentType, "Name");
-      addAttribute(contactContentType, "AlternateEmail");
-      addAttribute(contactContentType, "BillingContactEmail");
+      addAttribute(contactContentType, "Name", isExtended: false);
+      addAttribute(contactContentType, "AlternateEmail", isExtended: false);
+      addAttribute(contactContentType, "BillingContactEmail", isExtended: false);
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Local addAttribute() helper function
       \-----------------------------------------------------------------------------------------------------------------------*/
-      AttributeDescriptor addAttribute(Topic contentType, string attributeKey, string editorType = "TextAttribute", bool isRequired = false) {
+      AttributeDescriptor addAttribute(
+        Topic contentType,
+        string attributeKey,
+        string editorType       = "TextAttribute",
+        bool isExtended         = true,
+        bool isRequired         = false
+      ) {
         var container = contentType.Children.GetTopic("Attributes");
         if (container == null) {
           container = TopicFactory.Create("Attributes", "List", contentType);
           container.Attributes.SetBoolean("IsHidden", true);
         }
         var attribute = (AttributeDescriptor)TopicFactory.Create(attributeKey, editorType, currentAttributeId++, container);
         attribute.IsRequired = isRequired;
+        attribute.IsExtendedAttribute = isExtended;
         return attribute;
       }