Removed parameter validation for private methods

Given C# 8.0's null reference types, there's no need to validate that non-nullable parameters of `private` methods are, in fact, not `null`. Those scenarios will trigger a warning from the compilere if there's a chance that they might be true. That said, if they are using values that are being sourced from external locations (either parameters or public methods or service calls) then those values should still be validated at their source.

Author: JeremyCaney

OnTopic.Data.Sql/SqlTopicRepository.cs

@@ -57,7 +57,7 @@ public SqlTopicRepository(string connectionString) : base() {
       /*------------------------------------------------------------------------------------------------------------------------
       | Set private fields
       \-----------------------------------------------------------------------------------------------------------------------*/
-      _connectionString = connectionString;
+      _connectionString         = connectionString;
 
     }
 
@@ -66,12 +66,6 @@ public SqlTopicRepository(string connectionString) : base() {
     \-------------------------------------------------------------------------------------------------------------------------*/
     private static void AddTopic(SqlDataReader reader, Dictionary<int, Topic> topics) {
 
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Validate parameters
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      Contract.Requires(reader, nameof(reader));
-      Contract.Requires(topics, nameof(topics));
-
       /*------------------------------------------------------------------------------------------------------------------------
       | Identify attributes
       \-----------------------------------------------------------------------------------------------------------------------*/
@@ -101,12 +95,6 @@ private static void AddTopic(SqlDataReader reader, Dictionary<int, Topic> topics
     \-------------------------------------------------------------------------------------------------------------------------*/
     private static void SetIndexedAttributes(SqlDataReader reader, Dictionary<int, Topic> topics) {
 
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Validate parameters
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      Contract.Requires(reader, nameof(reader));
-      Contract.Requires(topics, nameof(topics));
-
       /*------------------------------------------------------------------------------------------------------------------------
       | Identify attributes
       \-----------------------------------------------------------------------------------------------------------------------*/
@@ -158,12 +146,6 @@ private static void SetIndexedAttributes(SqlDataReader reader, Dictionary<int, T
     /// <param name="topics">The index of topics currently being loaded.</param>
     private static void SetExtendedAttributes(SqlDataReader reader, Dictionary<int, Topic> topics) {
 
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Validate parameters
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      Contract.Requires(topics, "The topics Dictionary must not be null.");
-      Contract.Requires(reader, nameof(reader));
-
       /*------------------------------------------------------------------------------------------------------------------------
       | Identify attributes
       \-----------------------------------------------------------------------------------------------------------------------*/
@@ -240,12 +222,6 @@ private static void SetExtendedAttributes(SqlDataReader reader, Dictionary<int,
     /// <param name="topics">The index of topics currently being loaded.</param>
     private static void SetRelationships(SqlDataReader reader, Dictionary<int, Topic> topics) {
 
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Validate input
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      Contract.Requires(topics, "The topics Dictionary must not be null.");
-      Contract.Requires(reader, "The reader must not be null.");
-
       /*------------------------------------------------------------------------------------------------------------------------
       | Identify attributes
       \-----------------------------------------------------------------------------------------------------------------------*/
@@ -288,11 +264,6 @@ private static void SetRelationships(SqlDataReader reader, Dictionary<int, Topic
     /// <param name="topics">The index of topics currently being loaded.</param>
     private static void SetDerivedTopics(Dictionary<int, Topic> topics) {
 
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Validate input
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      Contract.Requires(topics, "The topics Dictionary must not be null.");
-
       /*------------------------------------------------------------------------------------------------------------------------
       | Loop through topics
       \-----------------------------------------------------------------------------------------------------------------------*/
@@ -322,11 +293,6 @@ private static void SetDerivedTopics(Dictionary<int, Topic> topics) {
     /// <param name="topics">The index of topics currently being loaded.</param>
     private static void SetVersionHistory(SqlDataReader reader, Dictionary<int, Topic> topics) {
 
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Validate input
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      Contract.Requires(topics, "The topics Dictionary must not be null.");
-
       /*------------------------------------------------------------------------------------------------------------------------
       | Identify attributes
       \-----------------------------------------------------------------------------------------------------------------------*/
@@ -1022,14 +988,8 @@ public override void Delete(Topic topic, bool isRecursive = false) {
     ///   An XML-formatted string representing the <see cref="Topic.Relationships"/> XML content, or a blank string if
     ///   <c>skipXml == true</c>.
     /// </returns>
-    /// <requires description="The topic must not be null." exception="T:System.ArgumentNullException">topic != null</requires>
     private static string PersistRelations(Topic topic, SqlConnection connection, bool skipXml) {
 
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Validate input
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      Contract.Requires(topic, "The topic must not be null.");
-
       /*------------------------------------------------------------------------------------------------------------------------
       | Return blank if the topic has no relations.
       \-----------------------------------------------------------------------------------------------------------------------*/
@@ -1111,14 +1071,8 @@ private static string PersistRelations(Topic topic, SqlConnection connection, bo
     /// </summary>
     /// <param name="topic">The topic object for which to create the relationships.</param>
     /// <returns>The XML string.</returns>
-    /// <requires description="The topic must not be null." exception="T:System.ArgumentNullException">topic != null</requires>
     private static string CreateRelationshipsXml(Topic topic) {
 
-      /*------------------------------------------------------------------------------------------------------------------------
-      | Validate input
-      \-----------------------------------------------------------------------------------------------------------------------*/
-      Contract.Requires(topic, "The topic must not be null.");
-
       /*------------------------------------------------------------------------------------------------------------------------
       | Create XML string container
       \-----------------------------------------------------------------------------------------------------------------------*/
@@ -1147,7 +1101,5 @@ private static string CreateRelationshipsXml(Topic topic) {
       return attributesXml.ToString();
     }
 
-
-
   } //Class
 } //Namespace