Remove unnecessary suppressions

Since previous versions, Visual Studio Validation has become smarter about a few cases, and thus some previous suppressions to avoid false positives are no longer necessary. This is notably the case for scenarios where an appropriate exception is being caught (e.g., `ArgumentException`), but previous versions mistook it as catching an overly broad exception. This resolves IDE0079.

Author: JeremyCaney

OnTopic.TestDoubles/DummyTopicMappingService.cs

@@ -10,7 +10,6 @@
 using OnTopic.Mapping.Annotations;
 
 #pragma warning disable CS1998 // Async method lacks 'await' operators and will run synchronously
-#pragma warning disable IDE0060 // Remove unused parameter
 
 namespace OnTopic.TestDoubles {
 
@@ -57,5 +56,4 @@ public DummyTopicMappingService() {
   } //Class
 } //Namespace
 
-#pragma warning restore CS1998 // Async method lacks 'await' operators and will run synchronously
-#pragma warning restore IDE0060 // Remove unused parameter
+#pragma warning restore CS1998 // Async method lacks 'await' operators and will run synchronously

OnTopic/Mapping/TopicMappingService.cs

@@ -665,12 +665,10 @@ void AddToList(object dto) {
           try {
             targetList.Add(dto);
           }
-          #pragma warning disable CA1031 // Do not catch general exception types
           catch (ArgumentException) {
             //Ignore exceptions caused by duplicate keys, in case the IList represents a keyed collection
             //We would defensively check for this, except IList doesn't provide a suitable method to do so
           }
-          #pragma warning restore CA1031 // Do not catch general exception types
         }
       }
 
@@ -710,11 +708,9 @@ ConcurrentDictionary<int, object> cache
       try {
         topicDto = await MapAsync(source, configuration.CrawlRelationships, cache).ConfigureAwait(false);
       }
-      #pragma warning disable CA1031 // Do not catch general exception types
       catch (InvalidOperationException) {
         //Disregard errors caused by unmapped view models; those are functionally equivalent to IsAssignableFrom() mismatches
       }
-      #pragma warning restore CA1031 // Do not catch general exception types
       if (topicDto is not null && configuration.Property.PropertyType.IsAssignableFrom(topicDto.GetType())) {
         configuration.Property.SetValue(target, topicDto);
       }