Relay ItemMetadata, attributePrefix instead of ItemConfiguration

With `ItemConfiguration` now a property on `ItemMetadata` (74cb817), it doesn't make sense to pass `ItemConfiguration` from method-to-method, but instead pass `ItemMetadata` (or `MemberAccessor` if specifically operating off of properties and methods). This effectively flips the order of dependencies, with `ItemConfiguration` being a property of `ItemMetadata` instead of `ItemMetadata` being a property of `Configuration`.

In addition, I now pass the `attributePrefix` from method-to-method as well. This used to be part of the `ItemConfiguration`. Since it was the one (and only) runtime variable included in that, and since `ItemConfiguration` is now cached as part of the `TypeAccessorCache` hierarchy, the `attributePrefix` was removed from `ItemConfiguration`, thus breaking the `[MapToParent()]` functionality (84735fb). By passing it from method-to-method, we take the first step toward fixing this.

As part of this, I also removed the `ItemMetadata` property from the `ItemConfiguration` class since it's no longer needed.

Author: JeremyCaney

OnTopic/Mapping/Internal/ItemConfiguration.cs

@@ -53,7 +53,6 @@ internal ItemConfiguration(ItemMetadata itemMetadata) {
       /*------------------------------------------------------------------------------------------------------------------------
       | Set backing properties
       \-----------------------------------------------------------------------------------------------------------------------*/
-      Metadata                  = itemMetadata;
       CustomAttributes          = itemMetadata.CustomAttributes;
 
       /*------------------------------------------------------------------------------------------------------------------------
@@ -112,14 +111,6 @@ internal ItemConfiguration(ItemMetadata itemMetadata) {
 
     }
 
-    /*==========================================================================================================================
-    | PROPERTY: METADATA
-    \-------------------------------------------------------------------------------------------------------------------------*/
-    /// <summary>
-    ///   The <see cref="ItemMetadata"/> that the current <see cref="ItemConfiguration"/> is associated with.
-    /// </summary>
-    internal ItemMetadata Metadata { get; }
-
     /*==========================================================================================================================
     | PROPERTY: CUSTOM ATTRIBUTES
     \-------------------------------------------------------------------------------------------------------------------------*/

OnTopic/Mapping/Reverse/BindingModelValidator.cs

@@ -8,7 +8,6 @@
 using System.Reflection;
 using OnTopic.Internal.Reflection;
 using OnTopic.Mapping.Annotations;
-using OnTopic.Mapping.Internal;
 using OnTopic.Metadata;
 using OnTopic.Models;
 using OnTopic.Repositories;
@@ -233,7 +232,7 @@ static internal void ValidateProperty(
       | Detect non-mapped relationships
       \-----------------------------------------------------------------------------------------------------------------------*/
       if (attributeDescriptor.ModelType is ModelType.Relationship) {
-        ValidateRelationship(sourceType, configuration, attributeDescriptor, listType);
+        ValidateRelationship(sourceType, propertyAccessor, attributeDescriptor, listType);
       }
 
       /*------------------------------------------------------------------------------------------------------------------------
@@ -282,16 +281,16 @@ attributeDescriptor.ModelType is ModelType.Reference &&
     /// <param name="sourceType">
     ///   The binding model <see cref="Type"/> to validate.
     /// </param>
-    /// <param name="configuration">
-    ///   A <see cref="PropertyConfiguration"/> describing a specific property of the <paramref name="sourceType"/>.
+    /// <param name="propertyAccessor">
+    ///   A <see cref="MemberAccessor"/> describing a specific property of the <paramref name="sourceType"/>.
     /// </param>
     /// <param name="attributeDescriptor">
     ///   The <see cref="AttributeDescriptor"/> object against which to validate the model.
     /// </param>
     /// <param name="listType">The generic <see cref="Type"/> used for the corresponding <see cref="IList{T}"/>.</param>
     static internal void ValidateRelationship(
       [AllowNull]Type                      sourceType,
-      [AllowNull]PropertyConfiguration     configuration,
+      [AllowNull]MemberAccessor            propertyAccessor,
       [AllowNull]AttributeDescriptor       attributeDescriptor,
       [DisallowNull]Type                   listType
     ) {
@@ -300,20 +299,20 @@ [DisallowNull]Type                   listType
       | Validate parameters
       \-----------------------------------------------------------------------------------------------------------------------*/
       Contract.Requires(sourceType, nameof(sourceType));
-      Contract.Requires(configuration, nameof(configuration));
+      Contract.Requires(propertyAccessor, nameof(propertyAccessor));
       Contract.Requires(attributeDescriptor, nameof(attributeDescriptor));
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Define variables
       \-----------------------------------------------------------------------------------------------------------------------*/
-      var property              = configuration.MemberAccessor;
+      var configuration         = propertyAccessor.Configuration;
 
       /*------------------------------------------------------------------------------------------------------------------------
       | Validate list
       \-----------------------------------------------------------------------------------------------------------------------*/
-      if (!typeof(IList).IsAssignableFrom(property.Type)) {
+      if (!typeof(IList).IsAssignableFrom(propertyAccessor.Type)) {
         throw new MappingModelValidationException(
-          $"The '{property.Name}' property on the '{sourceType.Name}' class maps to a relationship attribute " +
+          $"The '{propertyAccessor.Name}' property on the '{sourceType.Name}' class maps to a relationship attribute " +
           $"'{attributeDescriptor.Key}', but does not implement {nameof(IList)}. Relationships must implement " +
           $"{nameof(IList)} or derive from a collection that does."
         );
@@ -324,7 +323,7 @@ [DisallowNull]Type                   listType
       \-----------------------------------------------------------------------------------------------------------------------*/
       if (!new[] { CollectionType.Any, CollectionType.Relationship }.Contains(configuration.CollectionType)) {
         throw new MappingModelValidationException(
-          $"The '{property.Name}' property on the '{sourceType.Name}' class maps to a relationship attribute " +
+          $"The '{propertyAccessor.Name}' property on the '{sourceType.Name}' class maps to a relationship attribute " +
           $"'{attributeDescriptor.Key}', but is configured as a {configuration.CollectionType}. The property should be " +
           $"flagged as either {nameof(CollectionType.Any)} or {nameof(CollectionType.Relationship)}."
         );
@@ -335,7 +334,7 @@ [DisallowNull]Type                   listType
       \-----------------------------------------------------------------------------------------------------------------------*/
       if (!typeof(IAssociatedTopicBindingModel).IsAssignableFrom(listType)) {
         throw new MappingModelValidationException(
-          $"The '{property.Name}' property on the '{sourceType.Name}' class has been determined to be a " +
+          $"The '{propertyAccessor.Name}' property on the '{sourceType.Name}' class has been determined to be a " +
           $"{configuration.CollectionType}, but the generic type '{listType.Name}' does not implement the " +
           $"{nameof(IAssociatedTopicBindingModel)} interface. This is required for binding models. If this collection is not " +
           $"intended to be mapped as a {configuration.CollectionType} then update the definition in the associated " +