Adds base resource

Author: coding-chimp

lib/onesignal.rb

@@ -6,12 +6,12 @@
 require 'onesignal/models/base_model'
 require 'onesignal/models/app'
 require 'onesignal/models/player'
+require 'onesignal/resources/base_resource'
 require 'onesignal/resources/app_resource'
 require 'onesignal/resources/player_resource'
 
 module OneSignal
-  DEVICE_TYPES = [
-    'ios', 'android', 'amazon', 'mpns', 'chrome_app', 'chrome_website', 'wns',
-    'safari', 'firefox'
-  ]
+  DEVICE_TYPES = %w(
+    ios android amazon mpns chrome_app chrome_website wns safari firefox
+  ).freeze
 end

lib/onesignal/resources/app_resource.rb

@@ -1,43 +1,27 @@
-require 'json'
-
 module OneSignal
-  class AppResource
-    def initialize(client)
-      @client = client
-    end
-
+  class AppResource < BaseResource
     def all
-      response = request.get('/apps')
-      apps = JSON.parse(response.body)
+      get('/apps')
 
-      apps.map(&OneSignal::App)
+      response_body.map(&OneSignal::App)
     end
 
     def find(id)
-      response = request.get("/apps/#{id}")
-      app = JSON.parse(response.body)
+      get("/apps/#{id}")
 
-      OneSignal::App.new(app)
+      OneSignal::App.new(response_body)
     end
 
     def create(params)
-      response = request.post('/apps', params)
-      app = JSON.parse(response.body)
+      post('/apps', params)
 
-      OneSignal::App.new(app)
+      OneSignal::App.new(response_body)
     end
 
     def update(id, params)
-      response = request.put("/apps/#{id}", params)
-      app = JSON.parse(response.body)
-
-      OneSignal::App.new(app)
-    end
-
-    private
+      put("/apps/#{id}", params)
 
-    def request
-      @request ||= OneSignal::Request.new(@client)
+      OneSignal::App.new(response_body)
     end
   end
 end

lib/onesignal/resources/base_resource.rb

@@ -0,0 +1,31 @@
+require 'json'
+
+module OneSignal
+  class BaseResource
+    def initialize(client)
+      @client = client
+    end
+
+    private
+
+    def get(path, params = {})
+      @response = request.get(path, params)
+    end
+
+    def put(path, params)
+      @response = request.put(path, params)
+    end
+
+    def post(path, params)
+      @response = request.post(path, params)
+    end
+
+    def request
+      @request ||= OneSignal::Request.new(@client)
+    end
+
+    def response_body
+      JSON.parse(@response.body)
+    end
+  end
+end

lib/onesignal/resources/player_resource.rb

@@ -1,64 +1,53 @@
 module OneSignal
-  class PlayerResource
-    def initialize(client)
-      @client = client
-    end
-
+  class PlayerResource < BaseResource
     def all(params = {})
-      response = request.get('/players', params)
-      players = JSON.parse(response.body)['players']
+      get('/players', params)
+      players = response_body['players']
 
       players.map(&OneSignal::Player)
     end
 
     def find(id)
-      response = request.get("/players/#{id}")
-      player = JSON.parse(response.body)
+      get("/players/#{id}")
 
-      OneSignal::Player.new(player)
+      OneSignal::Player.new(response_body)
     end
 
     def create(params)
-      response = request.post('/players', params)
+      post('/players', params)
 
-      JSON.parse(response.body)['id']
+      response_body['id']
     end
 
     def update(id, params)
-      request.put("/players/#{id}", params)
+      put("/players/#{id}", params)
 
       true
     end
 
     def on_session(id, params)
-      request.post("/players/#{id}/on_session", params)
+      post("/players/#{id}/on_session", params)
 
       true
     end
 
     def on_purchase(id, params)
-      request.post("/players/#{id}/on_purchase", params)
+      post("/players/#{id}/on_purchase", params)
 
       true
     end
 
     def on_focus(id, params)
-      request.post("/players/#{id}/on_focus", params)
+      post("/players/#{id}/on_focus", params)
 
       true
     end
 
     def csv_export(id)
       params = { app_id: id }
-      response = request.post('/players/csv_export', params)
-
-      JSON.parse(response.body)['csv_file_url']
-    end
-
-    private
+      post('/players/csv_export', params)
 
-    def request
-      @request ||= OneSignal::Request.new(@client)
+      response_body['csv_file_url']
     end
   end
 end