Dynamically create model attributes on initialization

Author: coding-chimp

lib/onesignal/models/app.rb

@@ -4,14 +4,6 @@ module OneSignal
   class App < BaseModel
     DATE_REGEX = /\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}.\d{3}Z/
 
-    attr_accessor :apns_certificates, :apns_env, :basic_auth_key, :chrome_key,
-      :chrome_web_default_notification_icon, :chrome_web_gcm_sender_id,
-      :chrome_web_origin, :chrome_web_sub_domain, :created_at, :gcm_key, :id,
-      :messageable_players, :name, :players, :safari_apns_certificate,
-      :safari_icon_128_128, :safari_icon_16_16, :safari_icon_256_256,
-      :safari_icon_32_32, :safari_icon_64_64, :safari_push_id,
-      :safari_site_origin, :site_name, :updated_at
-
     def created_at=(time)
       parse_time('created_at', time)
     end

lib/onesignal/models/base_model.rb

@@ -5,7 +5,10 @@ def self.to_proc
     end
 
     def initialize(attributes = {})
-      attributes.each { |key, value| send("#{key}=", value) }
+      attributes.each do |key, value|
+        create_attr(key)
+        send("#{key}=", value)
+      end
     end
 
     def inspect
@@ -15,5 +18,23 @@ def inspect
 
       "<#{self.class.name} #{values}>"
     end
+
+    private
+
+    def create_attr(name)
+      create_method("#{name}=".to_sym) do |value|
+        instance_variable_set("@#{name}", value)
+      end
+
+      create_method(name.to_sym) do
+        instance_variable_get("@#{name}")
+      end
+    end
+
+    def create_method(name, &block)
+      unless respond_to?(name)
+        self.class.send(:define_method, name, &block)
+      end
+    end
   end
 end

lib/onesignal/models/notification.rb

@@ -1,10 +1,5 @@
 module OneSignal
   class Notification < BaseModel
-    attr_accessor :canceled, :contents, :converted, :data, :errored, :failed,
-      :headings, :id, :include_player_ids, :included_segments, :isAdm,
-      :isAndroid, :isChrome, :isChromeWeb, :isFirefox, :isIos, :isSafari,
-      :isWP, :isWP_WNS, :queued_at, :remaining, :send_after, :successful, :url
-
     def queued_at=(time)
       @queued_at = Time.at(time)
     end

lib/onesignal/models/player.rb

@@ -1,10 +1,5 @@
 module OneSignal
   class Player < BaseModel
-    attr_accessor :ad_id, :amount_spent, :badge_count, :created_at,
-      :device_model, :device_os, :device_type, :game_version, :id, :identifier,
-      :invalid_identifier, :language, :last_active, :playtime, :session_count,
-      :sdk, :tags, :timezone
-
     def created_at=(time)
       @created_at = Time.at(time)
     end

test/models/app_test.rb

@@ -3,36 +3,32 @@
 class AppTest < Minitest::Test
   def test_created_at_setter_parses_string_dates
     time = '2014-04-01T04:20:02.003Z'
-    app = OneSignal::App.new
 
-    app.created_at = time
+    app = OneSignal::App.new(created_at: time)
 
     assert_equal Time.parse(time), app.created_at
   end
 
   def test_created_at_setter_leaves_times_alone
     time = Time.now
-    app = OneSignal::App.new
 
-    app.created_at = time
+    app = OneSignal::App.new(created_at: time)
 
     assert_equal time, app.created_at
   end
 
   def test_updated_at_setter_parses_string_dates
     time = '2014-04-01T04:20:02.003Z'
-    app = OneSignal::App.new
 
-    app.updated_at = time
+    app = OneSignal::App.new(updated_at: time)
 
     assert_equal Time.parse(time), app.updated_at
   end
 
   def test_updated_at_setter_leaves_times_alone
     time = Time.now
-    app = OneSignal::App.new
 
-    app.updated_at = time
+    app = OneSignal::App.new(updated_at: time)
 
     assert_equal time, app.updated_at
   end

test/models/base_model_test.rb

@@ -1,7 +1,6 @@
 require_relative '../test_helper'
 
 class DummyModel < OneSignal::BaseModel
-  attr_accessor :id, :name, :created_at
 end
 
 class BaseModelTest < Minitest::Test

test/models/notification_test.rb

@@ -3,36 +3,32 @@
 class NotificationTest < Minitest::Test
   def test_queued_at_setter_parses_integers
     time = 1415914655
-    notification = OneSignal::Notification.new
 
-    notification.queued_at = time
+    notification = OneSignal::Notification.new(queued_at: time)
 
     assert_equal Time.at(time), notification.queued_at
   end
 
   def test_queued_at_setter_leaves_times_alone
     time = Time.now
-    notification = OneSignal::Notification.new
 
-    notification.queued_at = time
+    notification = OneSignal::Notification.new(queued_at: time)
 
     assert_equal time, notification.queued_at
   end
 
   def test_send_after_setter_parses_integers
     time = 1415914655
-    notification = OneSignal::Notification.new
 
-    notification.send_after = time
+    notification = OneSignal::Notification.new(send_after: time)
 
     assert_equal Time.at(time), notification.send_after
   end
 
   def test_send_after_setter_leaves_times_alone
     time = Time.now
-    notification = OneSignal::Notification.new
 
-    notification.send_after = time
+    notification = OneSignal::Notification.new(send_after: time)
 
     assert_equal time, notification.send_after
   end

test/models/player_test.rb

@@ -3,53 +3,46 @@
 class PlayerTest < Minitest::Test
   def test_created_at_setter_parses_integers
     time = 1415914655
-    player = OneSignal::Player.new
 
-    player.created_at = time
+    player = OneSignal::Player.new(created_at: time)
 
     assert_equal Time.at(time), player.created_at
   end
 
   def test_created_at_setter_leaves_times_alone
     time = Time.now
-    player = OneSignal::Player.new
 
-    player.created_at = time
+    player = OneSignal::Player.new(created_at: time)
 
     assert_equal time, player.created_at
   end
 
   def test_device_type_setter_parses_integers
-    player = OneSignal::Player.new
-
-    player.device_type = 0
+    player = OneSignal::Player.new(device_type: 0)
 
     assert_equal 'ios', player.device_type
   end
 
   def test_device_type_setter_leaves_times_alone
     type = 'ios'
-    player = OneSignal::Player.new
 
-    player.device_type = type
+    player = OneSignal::Player.new(device_type: type)
 
     assert_equal type, player.device_type
   end
 
   def test_last_active_setter_parses_integers
     time = 1415914655
-    player = OneSignal::Player.new
 
-    player.last_active = time
+    player = OneSignal::Player.new(last_active: time)
 
     assert_equal Time.at(time), player.last_active
   end
 
   def test_last_active_setter_leaves_times_alone
     time = Time.now
-    player = OneSignal::Player.new
 
-    player.last_active = time
+    player = OneSignal::Player.new(last_active: time)
 
     assert_equal time, player.last_active
   end