Skip to content
This repository was archived by the owner on Apr 11, 2024. It is now read-only.

Commit 3d599cf

Browse files
authored
feat(lib): update open telemetry to latest RC version (#238)
* update open telemetry to latest RC version * fix functional test error How I can forget including appsettings.json file in functional test and it was working till now!
1 parent fb68ebe commit 3d599cf

3 files changed

Lines changed: 40 additions & 24 deletions

File tree

src/Libraries/OpenTelemetry/Extensions.cs

Lines changed: 29 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
using System;
2+
using System.Collections.Generic;
23
using Microsoft.Extensions.Configuration;
34
using Microsoft.Extensions.DependencyInjection;
5+
using OpenTelemetry;
46
using OpenTelemetry.Context.Propagation;
7+
using OpenTelemetry.Resources;
58
using OpenTelemetry.Trace;
6-
using OpenTelemetry.Trace.Samplers;
79

810
namespace OpenCodeFoundation.OpenTelemetry
911
{
@@ -46,10 +48,10 @@ public static T GetOptions<T>(
4648

4749
private static void ConfigureOpenTelemetry(IServiceCollection services, OpenTelemetryOptions openTelemetryOptions)
4850
{
49-
services.AddOpenTelemetry(configure =>
51+
services.AddOpenTelemetryTracing(configure =>
5052
{
5153
ConfigureSampler(openTelemetryOptions, configure);
52-
ConfigureInstrumentations(openTelemetryOptions, configure);
54+
ConfigureInstrumentation(openTelemetryOptions, configure);
5355
ConfigureExporters(openTelemetryOptions, configure);
5456
});
5557
}
@@ -66,34 +68,42 @@ private static void ConfigureExporters(OpenTelemetryOptions openTelemetryOptions
6668
{
6769
if (openTelemetryOptions.Jaeger.Enabled)
6870
{
69-
configure.UseJaegerExporter(config =>
70-
{
71-
config.ServiceName = openTelemetryOptions.Jaeger.ServiceName;
71+
configure.SetResourceBuilder(ResourceBuilder.CreateDefault()
72+
.AddService(openTelemetryOptions.Jaeger.ServiceName));
7273

74+
configure.AddJaegerExporter(config =>
75+
{
7376
config.AgentHost = openTelemetryOptions.Jaeger.Host;
7477
config.AgentPort = openTelemetryOptions.Jaeger.Port;
7578
});
7679
}
7780
}
7881

79-
private static void ConfigureInstrumentations(OpenTelemetryOptions openTelemetryOptions, TracerProviderBuilder configure)
82+
private static void ConfigureInstrumentation(OpenTelemetryOptions openTelemetryOptions, TracerProviderBuilder configure)
83+
{
84+
Sdk.SetDefaultTextMapPropagator(GetPropagator(openTelemetryOptions));
85+
86+
configure.AddAspNetCoreInstrumentation();
87+
88+
configure.AddHttpClientInstrumentation();
89+
90+
configure.AddSqlClientInstrumentation();
91+
}
92+
93+
private static TextMapPropagator GetPropagator(OpenTelemetryOptions openTelemetryOptions)
8094
{
81-
configure.AddAspNetCoreInstrumentation(config =>
95+
var propagators = new List<TextMapPropagator>()
8296
{
83-
config.TextFormat = GetTextFormat(openTelemetryOptions);
84-
});
97+
new TraceContextPropagator(),
98+
new BaggagePropagator(),
99+
};
85100

86-
configure.AddHttpClientInstrumentation(config =>
101+
if (openTelemetryOptions.Istio)
87102
{
88-
config.TextFormat = GetTextFormat(openTelemetryOptions);
89-
});
103+
propagators.Add(new B3Propagator());
104+
}
90105

91-
configure.AddSqlClientDependencyInstrumentation();
106+
return new CompositeTextMapPropagator(propagators);
92107
}
93-
94-
private static ITextFormat GetTextFormat(OpenTelemetryOptions openTelemetryOptions)
95-
=> openTelemetryOptions.Istio
96-
? new B3Format()
97-
: (ITextFormat)new TraceContextFormat();
98108
}
99109
}

src/Libraries/OpenTelemetry/OpenTelemetry.csproj

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@
1515
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="5.0.0" />
1616

1717
<!-- OpenTelemetry -->
18-
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="0.4.0-beta.2" />
19-
<PackageReference Include="OpenTelemetry.Instrumentation.AspNetCore" Version="0.4.0-beta.2" />
20-
<PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="0.4.0-beta.2" />
21-
<PackageReference Include="OpenTelemetry.Instrumentation.SqlClient" Version="0.4.0-beta.2" />
22-
<PackageReference Include="OpenTelemetry.Exporter.Jaeger" Version="0.4.0-beta.2" />
18+
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.0.0-rc1.1" />
19+
<PackageReference Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.0.0-rc1.1" />
20+
<PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.0.0-rc1.1" />
21+
<PackageReference Include="OpenTelemetry.Instrumentation.SqlClient" Version="1.0.0-rc1.1" />
22+
<PackageReference Include="OpenTelemetry.Exporter.Jaeger" Version="1.0.0-rc1.1" />
2323

2424
<!-- Analyzers -->
2525
<PackageReference Include="StyleCop.Analyzers" Version="1.1.118" PrivateAssets="All" />

src/Services/Enrolling/Enrolling.FunctionalTests/Enrolling.FunctionalTests.csproj

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,10 @@
2323
<ProjectReference Include="..\Enrolling.Infrastructure\Enrolling.Infrastructure.csproj" />
2424
</ItemGroup>
2525

26+
<ItemGroup>
27+
<None Update="appsettings.json">
28+
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
29+
</None>
30+
</ItemGroup>
31+
2632
</Project>

0 commit comments

Comments
 (0)