Skip to content
This repository was archived by the owner on Apr 11, 2024. It is now read-only.

Commit cf8f80a

Browse files
authored
feat(pipeline): better codeql pull request analysis (#389)
In our current `CodeQL` analysis, we are getting warning - ``` 1 issue was detected with this workflow: git checkout HEAD^2 is no longer necessary. Please remove this step as Code Scanning recommends analyzing the merge commit for best results. ``` We are overriding the current `CodeQL` file with the new suggested action file suggested by `GitHub`.
1 parent f6ef50a commit cf8f80a

1 file changed

Lines changed: 32 additions & 20 deletions

File tree

.github/workflows/codeql-analysis.yml

Lines changed: 32 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,51 @@
1-
name: "Code scanning"
1+
# For most projects, this workflow file will not need changing; you simply need
2+
# to commit it to your repository.
3+
#
4+
# You may wish to alter this file to override the set of languages analyzed,
5+
# or to provide custom queries or build logic.
6+
#
7+
# ******** NOTE ********
8+
# We have attempted to detect the languages in your repository. Please check
9+
# the `language` matrix defined below to confirm you have the correct set of
10+
# supported CodeQL languages.
11+
#
12+
name: "CodeQL"
213

314
on:
415
push:
16+
branches: [ master ]
517
pull_request:
18+
# The branches below must be a subset of the branches above
19+
branches: [ master ]
620
schedule:
7-
- cron: '0 20 * * 3'
21+
- cron: '35 21 * * 1'
822

923
jobs:
10-
CodeQL-Build:
11-
24+
analyze:
25+
name: Analyze
1226
runs-on: ubuntu-latest
1327

28+
strategy:
29+
fail-fast: false
30+
matrix:
31+
language: [ 'csharp', 'javascript' ]
32+
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
33+
# Learn more:
34+
# https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed
35+
1436
steps:
1537
- name: Checkout repository
1638
uses: actions/checkout@v2
17-
with:
18-
# We must fetch at least the immediate parents so that if this is
19-
# a pull request then we can checkout the head.
20-
fetch-depth: 2
21-
22-
- uses: actions/setup-dotnet@v1
23-
with:
24-
dotnet-version: '5.0.x'
25-
26-
# If this run was triggered by a pull request event, then checkout
27-
# the head of the pull request instead of the merge commit.
28-
- run: git checkout HEAD^2
29-
if: ${{ github.event_name == 'pull_request' }}
3039

3140
# Initializes the CodeQL tools for scanning.
3241
- name: Initialize CodeQL
3342
uses: github/codeql-action/init@v1
34-
# Override language selection by uncommenting this and choosing your languages
35-
# with:
36-
# languages: go, javascript, csharp, python, cpp, java
43+
with:
44+
languages: ${{ matrix.language }}
45+
# If you wish to specify custom queries, you can do so here or in a config file.
46+
# By default, queries listed here will override any specified in a config file.
47+
# Prefix the list here with "+" to use these queries and those in the config file.
48+
# queries: ./path/to/local/query, your-org/your-repo/queries@main
3749

3850
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
3951
# If this step fails, then you should remove it and run the build manually (see below)

0 commit comments

Comments
 (0)