Skip to content
This repository was archived by the owner on Apr 11, 2024. It is now read-only.

Commit d5835ca

Browse files
ratanparairatanparai
authored
feat(joining): remove joining service (#234)
After initial domain analysis, we figure out that, we do not need this service. Closes #169
1 parent c265a7f commit d5835ca

36 files changed

Lines changed: 0 additions & 1049 deletions

‎.github/workflows/joining.api.yml‎

Lines changed: 0 additions & 27 deletions
This file was deleted.

‎build/azure-devops/joining-api/azure-pipelines.yml‎

Lines changed: 0 additions & 46 deletions
This file was deleted.

‎docker-compose-test.override.yml‎

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -33,29 +33,3 @@ services:
3333
- --logger
3434
- trx;LogFileName=/tests/enrolling-functional-test-results.xml
3535
- --collect:"XPlat Code Coverage"
36-
37-
joining.api.test:
38-
entrypoint:
39-
- dotnet
40-
- test
41-
- --results-directory
42-
- /tests
43-
- --logger
44-
- trx;LogFileName=/tests/joining-unit-test-results.xml
45-
- --collect:"XPlat Code Coverage"
46-
47-
joining.api.functional-test:
48-
environment:
49-
- ASPNETCORE_ENVIRONMENT=Development
50-
- ASPNETCORE_URLS=http://0.0.0.0:80
51-
- ConnectionStrings=Server=sql.data.test;Database=OpenCodeFoundation.JoiningDb;User Id=sa;Password=Pass@word
52-
ports:
53-
- "5103:80"
54-
entrypoint:
55-
- dotnet
56-
- test
57-
- --results-directory
58-
- /tests
59-
- --logger
60-
- trx;LogFileName=/tests/joining-functional-test-results.xml
61-
- --collect:"XPlat Code Coverage"

‎docker-compose-test.yml‎

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -23,23 +23,3 @@ services:
2323
- sql.data.test
2424
volumes:
2525
- ${BUILD_ARTIFACTSTAGINGDIRECTORY:-./tests-results/}:/tests
26-
27-
joining.api.test:
28-
image: ${REGISTRY:-eschool}/joining.api.test:${TAG:-latest}
29-
build:
30-
context: .
31-
dockerfile: src/Services/Joining/Joining.API/Dockerfile
32-
target: unittest
33-
volumes:
34-
- ${BUILD_ARTIFACTSTAGINGDIRECTORY:-./tests-results/}:/tests
35-
36-
joining.api.functional-test:
37-
image: ${REGISTRY:-eschool}/joining.api.functional-test:${TAG:-latest}
38-
build:
39-
context: .
40-
dockerfile: src/Services/Joining/Joining.API/Dockerfile
41-
target: functionaltest
42-
depends_on:
43-
- sql.data.test
44-
volumes:
45-
- ${BUILD_ARTIFACTSTAGINGDIRECTORY:-./tests-results/}:/tests

‎docker-compose.override.yml‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,23 +23,13 @@ services:
2323
- "5102:80"
2424
- "5581:5001"
2525

26-
joining.api:
27-
environment:
28-
- ASPNETCORE_ENVIRONMENT=Development
29-
- ASPNETCORE_URLS=http://0.0.0.0:80
30-
- ConnectionStrings=Server=sql.data;Database=OpenCodeFoundation.JoiningDb;User Id=sa;Password=Pass@word
31-
ports:
32-
- "5103:80"
33-
3426
webstatus:
3527
environment:
3628
- ASPNETCORE_ENVIRONMENT=Production
3729
- ASPNETCORE_URLS=http://0.0.0.0:80
3830
- ConnectionStrings=Server=sql.data;Database=OpenCodeFoundation.WebStatusDb;User Id=sa;Password=Pass@word
3931
- HealthChecksUI__HealthChecks__0__Name=Enrolling HTTP Check
4032
- HealthChecksUI__HealthChecks__0__Uri=http://enrolling.api/hc
41-
- HealthChecksUI__HealthChecks__1__Name=Joining HTTP Check
42-
- HealthChecksUI__HealthChecks__1__Uri=http://joining.api/hc
4333
ports:
4434
- "5107:80"
4535

‎docker-compose.yml‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,6 @@ services:
1515
depends_on:
1616
- sql.data
1717

18-
joining.api:
19-
image: ${REGISTRY:-eschool}/joining.api:${TAG:-latest}
20-
build:
21-
context: .
22-
dockerfile: src/Services/Joining/Joining.API/Dockerfile
23-
depends_on:
24-
- sql.data
25-
2618
webstatus:
2719
image: ${REGISTRY:-eschool}/webstatus:${TAG:-latest}
2820
build:

‎eSchool.sln‎

Lines changed: 0 additions & 81 deletions
Original file line numberDiff line numberDiff line change
@@ -25,21 +25,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Web", "Web", "{AA9E7227-03D
2525
EndProject
2626
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "WebStatus", "src\Web\WebStatus\WebStatus.csproj", "{3B42E8EA-BD33-4324-A771-9A885788D8BA}"
2727
EndProject
28-
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Joining", "Joining", "{8D2EFB6A-917E-4B93-890B-EBDD71476716}"
29-
EndProject
30-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Joining.Domain", "src\Services\Joining\Joining.Domain\Joining.Domain.csproj", "{BFC4D589-8BB1-4BE5-A970-E8CFC952D7D3}"
31-
EndProject
32-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Joining.Infrastructure", "src\Services\Joining\Joining.Infrastructure\Joining.Infrastructure.csproj", "{0B5F8BE7-44EB-47FB-B4F6-E6E6A35A76D5}"
33-
ProjectSection(ProjectDependencies) = postProject
34-
{BFC4D589-8BB1-4BE5-A970-E8CFC952D7D3} = {BFC4D589-8BB1-4BE5-A970-E8CFC952D7D3}
35-
EndProjectSection
36-
EndProject
37-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Joining.FunctionalTests", "src\Services\Joining\Joining.FunctionalTests\Joining.FunctionalTests.csproj", "{46F2E473-A24A-44F7-973B-EB203A59FF00}"
38-
EndProject
39-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Joining.UnitTests", "src\Services\Joining\Joining.UnitTests\Joining.UnitTests.csproj", "{039410B3-0844-4AE2-B0D3-3D2EC8AA8D6E}"
40-
EndProject
41-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Joining.API", "src\Services\Joining\Joining.API\Joining.API.csproj", "{60198F92-1838-4524-BCC5-BA8946305A2C}"
42-
EndProject
4328
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Libraries", "Libraries", "{74511F4E-FF9D-42C4-9531-A75C61270B73}"
4429
EndProject
4530
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "OpenTelemetry", "src\Libraries\OpenTelemetry\OpenTelemetry.csproj", "{7B410F3B-36E0-4853-9B4E-41D0CC2865B5}"
@@ -138,66 +123,6 @@ Global
138123
{3B42E8EA-BD33-4324-A771-9A885788D8BA}.Release|x64.Build.0 = Release|Any CPU
139124
{3B42E8EA-BD33-4324-A771-9A885788D8BA}.Release|x86.ActiveCfg = Release|Any CPU
140125
{3B42E8EA-BD33-4324-A771-9A885788D8BA}.Release|x86.Build.0 = Release|Any CPU
141-
{BFC4D589-8BB1-4BE5-A970-E8CFC952D7D3}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
142-
{BFC4D589-8BB1-4BE5-A970-E8CFC952D7D3}.Debug|Any CPU.Build.0 = Debug|Any CPU
143-
{BFC4D589-8BB1-4BE5-A970-E8CFC952D7D3}.Debug|x64.ActiveCfg = Debug|Any CPU
144-
{BFC4D589-8BB1-4BE5-A970-E8CFC952D7D3}.Debug|x64.Build.0 = Debug|Any CPU
145-
{BFC4D589-8BB1-4BE5-A970-E8CFC952D7D3}.Debug|x86.ActiveCfg = Debug|Any CPU
146-
{BFC4D589-8BB1-4BE5-A970-E8CFC952D7D3}.Debug|x86.Build.0 = Debug|Any CPU
147-
{BFC4D589-8BB1-4BE5-A970-E8CFC952D7D3}.Release|Any CPU.ActiveCfg = Release|Any CPU
148-
{BFC4D589-8BB1-4BE5-A970-E8CFC952D7D3}.Release|Any CPU.Build.0 = Release|Any CPU
149-
{BFC4D589-8BB1-4BE5-A970-E8CFC952D7D3}.Release|x64.ActiveCfg = Release|Any CPU
150-
{BFC4D589-8BB1-4BE5-A970-E8CFC952D7D3}.Release|x64.Build.0 = Release|Any CPU
151-
{BFC4D589-8BB1-4BE5-A970-E8CFC952D7D3}.Release|x86.ActiveCfg = Release|Any CPU
152-
{BFC4D589-8BB1-4BE5-A970-E8CFC952D7D3}.Release|x86.Build.0 = Release|Any CPU
153-
{0B5F8BE7-44EB-47FB-B4F6-E6E6A35A76D5}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
154-
{0B5F8BE7-44EB-47FB-B4F6-E6E6A35A76D5}.Debug|Any CPU.Build.0 = Debug|Any CPU
155-
{0B5F8BE7-44EB-47FB-B4F6-E6E6A35A76D5}.Debug|x64.ActiveCfg = Debug|Any CPU
156-
{0B5F8BE7-44EB-47FB-B4F6-E6E6A35A76D5}.Debug|x64.Build.0 = Debug|Any CPU
157-
{0B5F8BE7-44EB-47FB-B4F6-E6E6A35A76D5}.Debug|x86.ActiveCfg = Debug|Any CPU
158-
{0B5F8BE7-44EB-47FB-B4F6-E6E6A35A76D5}.Debug|x86.Build.0 = Debug|Any CPU
159-
{0B5F8BE7-44EB-47FB-B4F6-E6E6A35A76D5}.Release|Any CPU.ActiveCfg = Release|Any CPU
160-
{0B5F8BE7-44EB-47FB-B4F6-E6E6A35A76D5}.Release|Any CPU.Build.0 = Release|Any CPU
161-
{0B5F8BE7-44EB-47FB-B4F6-E6E6A35A76D5}.Release|x64.ActiveCfg = Release|Any CPU
162-
{0B5F8BE7-44EB-47FB-B4F6-E6E6A35A76D5}.Release|x64.Build.0 = Release|Any CPU
163-
{0B5F8BE7-44EB-47FB-B4F6-E6E6A35A76D5}.Release|x86.ActiveCfg = Release|Any CPU
164-
{0B5F8BE7-44EB-47FB-B4F6-E6E6A35A76D5}.Release|x86.Build.0 = Release|Any CPU
165-
{46F2E473-A24A-44F7-973B-EB203A59FF00}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
166-
{46F2E473-A24A-44F7-973B-EB203A59FF00}.Debug|Any CPU.Build.0 = Debug|Any CPU
167-
{46F2E473-A24A-44F7-973B-EB203A59FF00}.Debug|x64.ActiveCfg = Debug|Any CPU
168-
{46F2E473-A24A-44F7-973B-EB203A59FF00}.Debug|x64.Build.0 = Debug|Any CPU
169-
{46F2E473-A24A-44F7-973B-EB203A59FF00}.Debug|x86.ActiveCfg = Debug|Any CPU
170-
{46F2E473-A24A-44F7-973B-EB203A59FF00}.Debug|x86.Build.0 = Debug|Any CPU
171-
{46F2E473-A24A-44F7-973B-EB203A59FF00}.Release|Any CPU.ActiveCfg = Release|Any CPU
172-
{46F2E473-A24A-44F7-973B-EB203A59FF00}.Release|Any CPU.Build.0 = Release|Any CPU
173-
{46F2E473-A24A-44F7-973B-EB203A59FF00}.Release|x64.ActiveCfg = Release|Any CPU
174-
{46F2E473-A24A-44F7-973B-EB203A59FF00}.Release|x64.Build.0 = Release|Any CPU
175-
{46F2E473-A24A-44F7-973B-EB203A59FF00}.Release|x86.ActiveCfg = Release|Any CPU
176-
{46F2E473-A24A-44F7-973B-EB203A59FF00}.Release|x86.Build.0 = Release|Any CPU
177-
{039410B3-0844-4AE2-B0D3-3D2EC8AA8D6E}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
178-
{039410B3-0844-4AE2-B0D3-3D2EC8AA8D6E}.Debug|Any CPU.Build.0 = Debug|Any CPU
179-
{039410B3-0844-4AE2-B0D3-3D2EC8AA8D6E}.Debug|x64.ActiveCfg = Debug|Any CPU
180-
{039410B3-0844-4AE2-B0D3-3D2EC8AA8D6E}.Debug|x64.Build.0 = Debug|Any CPU
181-
{039410B3-0844-4AE2-B0D3-3D2EC8AA8D6E}.Debug|x86.ActiveCfg = Debug|Any CPU
182-
{039410B3-0844-4AE2-B0D3-3D2EC8AA8D6E}.Debug|x86.Build.0 = Debug|Any CPU
183-
{039410B3-0844-4AE2-B0D3-3D2EC8AA8D6E}.Release|Any CPU.ActiveCfg = Release|Any CPU
184-
{039410B3-0844-4AE2-B0D3-3D2EC8AA8D6E}.Release|Any CPU.Build.0 = Release|Any CPU
185-
{039410B3-0844-4AE2-B0D3-3D2EC8AA8D6E}.Release|x64.ActiveCfg = Release|Any CPU
186-
{039410B3-0844-4AE2-B0D3-3D2EC8AA8D6E}.Release|x64.Build.0 = Release|Any CPU
187-
{039410B3-0844-4AE2-B0D3-3D2EC8AA8D6E}.Release|x86.ActiveCfg = Release|Any CPU
188-
{039410B3-0844-4AE2-B0D3-3D2EC8AA8D6E}.Release|x86.Build.0 = Release|Any CPU
189-
{60198F92-1838-4524-BCC5-BA8946305A2C}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
190-
{60198F92-1838-4524-BCC5-BA8946305A2C}.Debug|Any CPU.Build.0 = Debug|Any CPU
191-
{60198F92-1838-4524-BCC5-BA8946305A2C}.Debug|x64.ActiveCfg = Debug|Any CPU
192-
{60198F92-1838-4524-BCC5-BA8946305A2C}.Debug|x64.Build.0 = Debug|Any CPU
193-
{60198F92-1838-4524-BCC5-BA8946305A2C}.Debug|x86.ActiveCfg = Debug|Any CPU
194-
{60198F92-1838-4524-BCC5-BA8946305A2C}.Debug|x86.Build.0 = Debug|Any CPU
195-
{60198F92-1838-4524-BCC5-BA8946305A2C}.Release|Any CPU.ActiveCfg = Release|Any CPU
196-
{60198F92-1838-4524-BCC5-BA8946305A2C}.Release|Any CPU.Build.0 = Release|Any CPU
197-
{60198F92-1838-4524-BCC5-BA8946305A2C}.Release|x64.ActiveCfg = Release|Any CPU
198-
{60198F92-1838-4524-BCC5-BA8946305A2C}.Release|x64.Build.0 = Release|Any CPU
199-
{60198F92-1838-4524-BCC5-BA8946305A2C}.Release|x86.ActiveCfg = Release|Any CPU
200-
{60198F92-1838-4524-BCC5-BA8946305A2C}.Release|x86.Build.0 = Release|Any CPU
201126
{7B410F3B-36E0-4853-9B4E-41D0CC2865B5}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
202127
{7B410F3B-36E0-4853-9B4E-41D0CC2865B5}.Debug|Any CPU.Build.0 = Debug|Any CPU
203128
{7B410F3B-36E0-4853-9B4E-41D0CC2865B5}.Debug|x64.ActiveCfg = Debug|Any CPU
@@ -224,12 +149,6 @@ Global
224149
{057CF093-72A7-47CC-BCB8-296C2B569905} = {5193B8A7-4464-482A-872C-C59BB56C88ED}
225150
{AA9E7227-03DB-4D04-A7FB-E8FD09D4C719} = {6BFF1AB8-C900-43E5-988F-E07C085BD64A}
226151
{3B42E8EA-BD33-4324-A771-9A885788D8BA} = {AA9E7227-03DB-4D04-A7FB-E8FD09D4C719}
227-
{8D2EFB6A-917E-4B93-890B-EBDD71476716} = {1C120673-72F4-4679-AC4C-68286E9091A5}
228-
{BFC4D589-8BB1-4BE5-A970-E8CFC952D7D3} = {8D2EFB6A-917E-4B93-890B-EBDD71476716}
229-
{0B5F8BE7-44EB-47FB-B4F6-E6E6A35A76D5} = {8D2EFB6A-917E-4B93-890B-EBDD71476716}
230-
{46F2E473-A24A-44F7-973B-EB203A59FF00} = {8D2EFB6A-917E-4B93-890B-EBDD71476716}
231-
{039410B3-0844-4AE2-B0D3-3D2EC8AA8D6E} = {8D2EFB6A-917E-4B93-890B-EBDD71476716}
232-
{60198F92-1838-4524-BCC5-BA8946305A2C} = {8D2EFB6A-917E-4B93-890B-EBDD71476716}
233152
{74511F4E-FF9D-42C4-9531-A75C61270B73} = {6BFF1AB8-C900-43E5-988F-E07C085BD64A}
234153
{7B410F3B-36E0-4853-9B4E-41D0CC2865B5} = {74511F4E-FF9D-42C4-9531-A75C61270B73}
235154
EndGlobalSection

‎src/Services/Enrolling/Enrolling.API/Dockerfile‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,6 @@ COPY "src/Services/Enrolling/Enrolling.Infrastructure/Enrolling.Infrastructure.c
1313
COPY "src/Services/Enrolling/Enrolling.UnitTests/Enrolling.UnitTests.csproj" "src/Services/Enrolling/Enrolling.UnitTests/Enrolling.UnitTests.csproj"
1414
COPY "src/Services/Enrolling/Enrolling.FunctionalTests/Enrolling.FunctionalTests.csproj" "src/Services/Enrolling/Enrolling.FunctionalTests/Enrolling.FunctionalTests.csproj"
1515

16-
COPY "src/Services/Joining/Joining.API/Joining.API.csproj" "src/Services/Joining/Joining.API/Joining.API.csproj"
17-
COPY "src/Services/Joining/Joining.Domain/Joining.Domain.csproj" "src/Services/Joining/Joining.Domain/Joining.Domain.csproj"
18-
COPY "src/Services/Joining/Joining.Infrastructure/Joining.Infrastructure.csproj" "src/Services/Joining/Joining.Infrastructure/Joining.Infrastructure.csproj"
19-
COPY "src/Services/Joining/Joining.UnitTests/Joining.UnitTests.csproj" "src/Services/Joining/Joining.UnitTests/Joining.UnitTests.csproj"
20-
COPY "src/Services/Joining/Joining.FunctionalTests/Joining.FunctionalTests.csproj" "src/Services/Joining/Joining.FunctionalTests/Joining.FunctionalTests.csproj"
21-
2216
COPY "src/Libraries/OpenTelemetry/OpenTelemetry.csproj" "src/Libraries/OpenTelemetry/OpenTelemetry.csproj"
2317

2418
COPY "src/Web/WebStatus/WebStatus.csproj" "src/Web/WebStatus/WebStatus.csproj"

‎src/Services/Joining/Joining.API/Application/Commands/JoinApplicationCommand.cs‎

Lines changed: 0 additions & 15 deletions
This file was deleted.

‎src/Services/Joining/Joining.API/Application/Commands/JoinApplicationCommandHandler.cs‎

Lines changed: 0 additions & 35 deletions
This file was deleted.

0 commit comments

Comments
 (0)