Skip to content

Commit 6efdd09

Browse files
Fix clang-tidy warnings in rx_filter tests
Suppress non-const global variable warnings on test capture state, split multiple variable declarations onto separate lines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 4c824be commit 6efdd09

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

tests/src/test_intrusive_rx_filter.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -980,8 +980,8 @@ static void test_rx_filter_match_multiple(void)
980980
#define HEARTBEAT_SUBJECT_ID 7509U
981981
#define NODESTATUS_DTYPE_ID 341U
982982

983-
static size_t g_cap_count;
984-
static canard_filter_t g_cap_filters[32];
983+
static size_t g_cap_count; // NOLINT(cppcoreguidelines-avoid-non-const-global-variables)
984+
static canard_filter_t g_cap_filters[32]; // NOLINT(cppcoreguidelines-avoid-non-const-global-variables)
985985

986986
static bool capturing_filter_cb(canard_t* const self, const size_t filter_count, const canard_filter_t* const filters)
987987
{
@@ -1117,7 +1117,9 @@ static void test_rx_filter_configure_forced_capacity_2_no_subs(void)
11171117
static void test_rx_filter_configure_forced_with_unrelated_subs(void)
11181118
{
11191119
canard_t self = make_instance(10);
1120-
canard_subscription_t sub1, sub2, sub3;
1120+
canard_subscription_t sub1;
1121+
canard_subscription_t sub2;
1122+
canard_subscription_t sub3;
11211123
TEST_ASSERT_TRUE(canard_subscribe_16b(&self, &sub1, 100U, 64U, 1000000, &dummy_sub_vtable));
11221124
TEST_ASSERT_TRUE(canard_subscribe_16b(&self, &sub2, 200U, 64U, 1000000, &dummy_sub_vtable));
11231125
TEST_ASSERT_TRUE(canard_subscribe_16b(&self, &sub3, 300U, 64U, 1000000, &dummy_sub_vtable));
@@ -1143,7 +1145,8 @@ static void test_rx_filter_configure_forced_overflow(void)
11431145
{
11441146
// capacity=1 with 2 unrelated subs: subs fill+coalesce, then forced filters also coalesce in.
11451147
canard_t self = make_instance(1);
1146-
canard_subscription_t sub1, sub2;
1148+
canard_subscription_t sub1;
1149+
canard_subscription_t sub2;
11471150
TEST_ASSERT_TRUE(canard_subscribe_16b(&self, &sub1, 100U, 64U, 1000000, &dummy_sub_vtable));
11481151
TEST_ASSERT_TRUE(canard_subscribe_16b(&self, &sub2, 200U, 64U, 1000000, &dummy_sub_vtable));
11491152
TEST_ASSERT_TRUE(rx_filter_configure(&self));

0 commit comments

Comments
 (0)