Merge remote-tracking branch 'origin/master' into matthias_QPR-9544

Author: mgroncki

.clang-format

@@ -1,6 +1,6 @@
 ---
 Language:        Cpp
-Standard:        Cpp03
+Standard:        c++14
 
 
 # The following is close to the style we've been using all these years

.clang-tidy

@@ -3,6 +3,8 @@ Checks: >
         -*,
         bugprone-*,
           -bugprone-branch-clone,
+          -bugprone-easily-swappable-parameters,
+          -bugprone-implicit-widening-of-multiplication-result,
           -bugprone-macro-parentheses,
           -bugprone-narrowing-conversions,
         clang-analyzer-*,
@@ -22,6 +24,7 @@ Checks: >
           -cppcoreguidelines-narrowing-conversions,
           -cppcoreguidelines-non-private-member-variables-in-classes,
           -cppcoreguidelines-owning-memory,
+          -cppcoreguidelines-prefer-member-initializer,
           -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
           -cppcoreguidelines-pro-bounds-constant-array-index,
           -cppcoreguidelines-pro-bounds-pointer-arithmetic,
@@ -36,6 +39,7 @@ Checks: >
         modernize-*,
           -modernize-avoid-c-arrays,
           -modernize-make-shared,
+          -modernize-return-braced-init-list,
           -modernize-use-trailing-return-type,
           -modernize-use-using,
         performance-*,
@@ -50,6 +54,7 @@ Checks: >
           -readability-magic-numbers,
           -readability-named-parameter,
           -readability-simplify-boolean-expr,
+          -readability-suspicious-call-argument,
           -readability-use-anyofallof,
 HeaderFilterRegex: '.*'
 FormatStyle: file

.github/workflows/cmake.yml

@@ -8,15 +8,24 @@ jobs:
     - name: Setup
       run: |
         sudo apt update
-        sudo apt install -y libboost-dev
+        sudo apt install -y libboost-dev ccache
+    - name: Cache
+      uses: hendrikmuhs/ccache-action@v1.2
+      with:
+        key: cmake-linux-ci-build-${{ github.ref }}-${{ github.head_ref }}-${{ hashFiles('**/*.hpp', '**/*.cpp') }}
+        restore-keys: |
+          cmake-linux-ci-build-${{ github.ref }}-${{ github.head_ref }}-
+          cmake-linux-ci-build-${{ github.ref }}-
+          cmake-linux-ci-build-refs/heads/master-
+          cmake-linux-ci-build-
     - name: Compile
       env:
         CXXFLAGS: -O2
       run: |
         mkdir build
         cd build
-        cmake -DBOOST_ROOT=/usr ..
-        make -j 2
+        cmake .. -DBOOST_ROOT=/usr -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
+        cmake --build . -j2
     - name: Test
       run: |
         cd build
@@ -28,7 +37,16 @@ jobs:
     - name: Setup
       run: |
         sudo apt update
-        sudo apt install -y libboost-all-dev
+        sudo apt install -y libboost-all-dev ccache
+    - name: Cache
+      uses: hendrikmuhs/ccache-action@v1.2
+      with:
+        key: cmake-linux-ci-opts-${{ github.ref }}-${{ github.head_ref }}-${{ hashFiles('**/*.hpp', '**/*.cpp') }}
+        restore-keys: |
+          cmake-linux-ci-opts-${{ github.ref }}-${{ github.head_ref }}-
+          cmake-linux-ci-opts-${{ github.ref }}-
+          cmake-linux-ci-opts-refs/heads/master-
+          cmake-linux-ci-opts-
     - name: Compile
       env:
         CXXFLAGS: -O2
@@ -85,15 +103,24 @@ jobs:
     - uses: actions/checkout@v3
     - name: Setup
       run: |
-        brew install boost
+        brew install boost ccache
+    - name: Cache
+      uses: hendrikmuhs/ccache-action@v1.2
+      with:
+        key: cmake-macos-ci-${{ github.ref }}-${{ github.head_ref }}-${{ hashFiles('**/*.hpp', '**/*.cpp') }}
+        restore-keys: |
+          cmake-macos-ci-${{ github.ref }}-${{ github.head_ref }}-
+          cmake-macos-ci-${{ github.ref }}-
+          cmake-macos-ci-refs/heads/master-
+          cmake-macos-ci-
     - name: Compile
       env:
         CXXFLAGS: -O2 -stdlib=libc++ -mmacosx-version-min=10.9
       run: |
         mkdir build
         cd build
-        cmake ..
-        make -j 2
+        cmake .. -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
+        cmake --build . -j2
     - name: Test
       run: |
         cd build

.github/workflows/codeql-analysis.yml

@@ -5,7 +5,10 @@
 # or to provide custom queries or build logic.
 name: "CodeQL"
 
-on: workflow_dispatch
+on:
+  schedule:
+    - cron: '0 0 * * 0'
+  workflow_dispatch:
 
 jobs:
   analyze:

.github/workflows/linux-full-tests.yml

@@ -7,11 +7,6 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - name: "gcc 4.8 (Boost 1.48)"
-            shortname: gcc4
-            tag: trusty
-            cc: gcc
-            cxx: g++
           - name: "gcc 5.4 (Boost 1.66)"
             shortname: gcc5
             tag: xenial
@@ -37,14 +32,19 @@ jobs:
             tag: focal
             cc: gcc
             cxx: g++
-          - name: "gcc 10.x"
+          - name: "gcc 10.3 (Boost 1.79)"
             shortname: gcc10
             tag: hirsute
             cc: gcc
             cxx: g++
           - name: "gcc 11.x"
             shortname: gcc11
-            tag: impish
+            tag: jammy
+            cc: gcc
+            cxx: g++
+          - name: "gcc 12.x"
+            shortname: gcc12
+            tag: kinetic
             cc: gcc
             cxx: g++
           - name: "Clang 6 (Boost 1.72)"
@@ -77,12 +77,12 @@ jobs:
             tag: groovy
             cc: clang
             cxx: clang++
-          - name: "Clang 12"
+          - name: "Clang 12 (Boost 1.79)"
             shortname: clang12
             tag: hirsute
             cc: clang
             cxx: clang++
-          - name: "Clang 13"
+          - name: "Clang 13 (Boost 1.79)"
             shortname: clang13
             tag: impish
             cc: clang
@@ -92,12 +92,11 @@ jobs:
             tag: jammy
             cc: clang
             cxx: clang++
-          - name: "C++11 mode"
-            shortname: c++11
-            tag: rolling
-            cc: gcc
-            cxx: g++
-            cxxflags: "-std=c++11 -Wno-cpp"
+          - name: "Clang 15"
+            shortname: clang15
+            tag: kinetic
+            cc: clang
+            cxx: clang++
           - name: "C++14 mode"
             shortname: c++14
             tag: rolling
@@ -134,7 +133,7 @@ jobs:
             cc: gcc
             cxx: g++
             configureflags: --enable-indexed-coupons
-          - name: "C++11 classes enabled"
+          - name: "Standard Library classes enabled"
             shortname: stdclasses
             tag: rolling
             cc: gcc
@@ -174,15 +173,14 @@ jobs:
     steps:
     - uses: actions/checkout@v3
     - name: Cache
-      uses: actions/cache@v3
+      uses: hendrikmuhs/ccache-action@v1.2
       with:
-        path: ~/.ccache
-        key: linux-build-${{ matrix.shortname }}-${{ github.ref }}-${{ github.head_ref }}-${{ hashFiles('**/*.hpp', '**/*.cpp') }}
+        key: linux-ci-build-${{ matrix.shortname }}-${{ github.ref }}-${{ github.head_ref }}-${{ hashFiles('**/*.hpp', '**/*.cpp') }}
         restore-keys: |
-          linux-build-${{ matrix.shortname }}-${{ github.ref }}-${{ github.head_ref }}-
-          linux-build-${{ matrix.shortname }}-${{ github.ref }}-
-          linux-build-${{ matrix.shortname }}-refs/heads/master-
-          linux-build-${{ matrix.shortname }}-
+          linux-ci-build-${{ matrix.shortname }}-${{ github.ref }}-${{ github.head_ref }}-
+          linux-ci-build-${{ matrix.shortname }}-${{ github.ref }}-
+          linux-ci-build-${{ matrix.shortname }}-refs/heads/master-
+          linux-ci-build-${{ matrix.shortname }}-
     - name: Compiler version
       run: |
         ${{ matrix.cc }} --version

.github/workflows/linux-nondefault.yml

@@ -32,14 +32,19 @@ jobs:
             tag: focal
             cc: gcc
             cxx: g++
-          - name: "gcc 10.x"
+          - name: "gcc 10.3 (Boost 1.79)"
             shortname: gcc10
             tag: hirsute
             cc: gcc
             cxx: g++
           - name: "gcc 11.x"
             shortname: gcc11
-            tag: impish
+            tag: jammy
+            cc: gcc
+            cxx: g++
+          - name: "gcc 12.x"
+            shortname: gcc12
+            tag: kinetic
             cc: gcc
             cxx: g++
           - name: "Clang 6 (Boost 1.72)"
@@ -72,12 +77,12 @@ jobs:
             tag: groovy
             cc: clang
             cxx: clang++
-          - name: "Clang 12"
+          - name: "Clang 12 (Boost 1.79)"
             shortname: clang12
             tag: hirsute
             cc: clang
             cxx: clang++
-          - name: "Clang 13"
+          - name: "Clang 13 (Boost 1.79)"
             shortname: clang13
             tag: impish
             cc: clang
@@ -87,12 +92,11 @@ jobs:
             tag: jammy
             cc: clang
             cxx: clang++
-          - name: "C++11 mode"
-            shortname: c++11
-            tag: rolling
-            cc: gcc
-            cxx: g++
-            cxxflags: "-std=c++11"
+          - name: "Clang 15"
+            shortname: clang15
+            tag: kinetic
+            cc: clang
+            cxx: clang++
           - name: "C++14 mode"
             shortname: c++14
             tag: rolling
@@ -117,7 +121,7 @@ jobs:
             cc: gcc
             cxx: g++
             configureflags: --enable-unity-build
-          - name: "C++11 classes enabled"
+          - name: "Standard Library classes enabled"
             shortname: stdclasses
             tag: rolling
             cc: gcc
@@ -133,23 +137,13 @@ jobs:
     container: ghcr.io/lballabio/quantlib-devenv:${{ matrix.tag }}
     steps:
     - uses: actions/checkout@v3
-    - name: Cache
-      uses: actions/cache@v3
-      with:
-        path: ~/.ccache
-        key: linux-nondef-build-${{ matrix.shortname }}-${{ github.ref }}-${{ github.head_ref }}-${{ hashFiles('**/*.hpp', '**/*.cpp') }}
-        restore-keys: |
-          linux-nondef-build-${{ matrix.shortname }}-${{ github.ref }}-${{ github.head_ref }}-
-          linux-nondef-build-${{ matrix.shortname }}-${{ github.ref }}-
-          linux-nondef-build-${{ matrix.shortname }}-refs/heads/master-
-          linux-nondef-build-${{ matrix.shortname }}-
     - name: Compiler version
       run: |
         ${{ matrix.cc }} --version
     - name: Build
       run: |
         ./autogen.sh
-        ./configure --disable-static --enable-error-lines --enable-error-functions --enable-tracing --enable-indexed-coupons --enable-extra-safety-checks --enable-sessions --enable-thread-safe-observer-pattern --enable-intraday --enable-null-as-functions ${{ matrix.configureflags }} CC="ccache ${{ matrix.cc }}" CXX="ccache ${{ matrix.cxx }}" CXXFLAGS="-O2 -g0 -Wall -Wno-unknown-pragmas -Werror ${{ matrix.cxxflags }}"
+        ./configure --disable-static --enable-error-lines --enable-error-functions --enable-tracing --enable-indexed-coupons --enable-extra-safety-checks --enable-sessions --enable-thread-safe-observer-pattern --enable-intraday --enable-null-as-functions ${{ matrix.configureflags }} CC="${{ matrix.cc }}" CXX="${{ matrix.cxx }}" CXXFLAGS="-O2 -g0 -Wall -Wno-unknown-pragmas -Werror ${{ matrix.cxxflags }}"
         make -j 2
     - name: Run tests
       run: |