Incorp. feedback

Author: ralfkonrad

.github/workflows/cmake.yml

@@ -45,7 +45,7 @@ jobs:
           cmake-linux-ci-opts-
     - name: Compile
       run: |
-        cmake --preset linux-ci-build-with-nonstandard-options -DQL_COMPILE_WARNING_AS_ERROR=ON -L
+        cmake --preset linux-ci-build-with-nonstandard-options -L
         cmake --build --preset linux-ci-build-with-nonstandard-options --verbose
     - name: Test
       run: |
@@ -144,7 +144,7 @@ jobs:
       shell: cmd
       run: |
         call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Vc\Auxiliary\Build\vcvarsall.bat" amd64 -vcvars_ver=14.3 || exit 1
-        cmake --preset windows-ci-build-with-nonstandard-options -DQL_COMPILE_WARNING_AS_ERROR=ON -L
+        cmake --preset windows-ci-build-with-nonstandard-options -L
         cmake --build --preset windows-ci-build-with-nonstandard-options --verbose
     - name: Test
       run: |

CMakePresets.json

@@ -116,7 +116,8 @@
         "QL_HIGH_RESOLUTION_DATE": "ON",
         "QL_NULL_AS_FUNCTIONS": "ON",
         "QL_USE_INDEXED_COUPON": "ON",
-        "QL_USE_STD_CLASSES": "ON"
+        "QL_USE_STD_CLASSES": "ON",
+        "QL_COMPILE_WARNING_AS_ERROR": "ON"
       }
     },
     {
@@ -137,6 +138,7 @@
         "QL_NULL_AS_FUNCTIONS": "ON",
         "QL_USE_INDEXED_COUPON": "ON",
         "QL_USE_STD_CLASSES": "ON",
+        "QL_COMPILE_WARNING_AS_ERROR": "ON",
         "CMAKE_CXX_COMPILER_LAUNCHER": "sccache"
       },
       "vendor": {

cmake/Platform.cmake

@@ -32,7 +32,7 @@ if (MSVC)
     add_compile_options(/wd4267 /wd4819 /wd26812)
 
     # prevent warnings when using /std:c++17 and above
-    if(CMAKE_CXX_STANDARD GREATER 14)
+    if(CMAKE_CXX_STANDARD GREATER_EQUAL 17)
         # E.g. caused by #include <boost/numeric/ublas/matrix.hpp>
         # In c++17 std::iterator is deprecated. As of boost 1.81 boost::ublas has not provided a fix for this.
         add_compile_definitions(_SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING)