yoy ratio index use same name as underlying cpi index

the ratio index doesnt need own fixings, the historical fixings are computed from underlying cpi index

Author: mgroncki

ql/indexes/inflationindex.cpp

@@ -330,7 +330,7 @@ namespace QuantLib {
     YoYInflationIndex::YoYInflationIndex(const ext::shared_ptr<ZeroInflationIndex>& underlyingIndex,
                                          bool interpolated,
                                          Handle<YoYInflationTermStructure> yoyInflation)
-    : InflationIndex("YYR_" + underlyingIndex->familyName(), underlyingIndex->region(),
+    : InflationIndex(underlyingIndex->familyName(), underlyingIndex->region(),
                      underlyingIndex->revised(), underlyingIndex->frequency(),
                      underlyingIndex->availabilityLag(), underlyingIndex->currency()),
       interpolated_(interpolated), ratio_(true), underlyingIndex_(underlyingIndex),
@@ -433,10 +433,13 @@ namespace QuantLib {
 
     ext::shared_ptr<YoYInflationIndex> YoYInflationIndex::clone(
                            const Handle<YoYInflationTermStructure>& h) const {
-        return ext::make_shared<YoYInflationIndex>(
-                      familyName_, region_, revised_,
-                      interpolated_, ratio_, frequency_,
-                      availabilityLag_, currency_, h);
+        if (ratio_) {
+            return ext::make_shared<YoYInflationIndex>(underlyingIndex_, interpolated_, h);
+        } else {
+            return ext::make_shared<YoYInflationIndex>(familyName_, region_, revised_,
+                                                       interpolated_, frequency_,
+                                                       availabilityLag_, currency_, h);
+        }
     }
 
 

ql/indexes/inflationindex.hpp

@@ -263,8 +263,10 @@ namespace QuantLib {
             year-on-year values; if `ratio` is true, they must be the
             past fixings of the underlying index.
 
-            Deprecated in QL version 1.31 but needed in ORE
+            \deprecated Use one of the other constructors instead.
+                        Deprecated in version 1.31.
         */
+        QL_DEPRECATED
         YoYInflationIndex(
             const std::string& familyName,
             const Region& region,

test-suite/inflation.cpp

@@ -792,7 +792,7 @@ void InflationTest::testRatioYYIndex() {
     auto ukrpi = ext::make_shared<UKRPI>();
 
     YoYInflationIndex yyeuhicpr(euhicp, true);
-    if (yyeuhicpr.name() != "EU YYR_HICP"
+    if (yyeuhicpr.name() != "EU HICP"
         || yyeuhicpr.frequency() != Monthly
         || yyeuhicpr.revised()
         || !yyeuhicpr.interpolated()
@@ -808,7 +808,7 @@ void InflationTest::testRatioYYIndex() {
     }
 
     YoYInflationIndex yyukrpir(ukrpi, false);
-    if (yyukrpir.name() != "UK YYR_RPI"
+    if (yyukrpir.name() != "UK RPI"
         || yyukrpir.frequency() != Monthly
         || yyukrpir.revised()
         || yyukrpir.interpolated()