Wait a longer time between tests. Remove WebUI in setup instructions instead of config file

Author: alexanderbock

README.md

@@ -26,7 +26,7 @@ Example: `python main.py --dir C:/Development/OpenSpace --test default/earth,ros
 
 Additionally, a `config.json` must be provided if tests are to be submitted to the regression server. The `config.sample.json` provides a stub that can be used as the starting point for configuring the JSON file.
 
-If no `config.json` is found, all tests are run locally and are not submitted to the regression server. Instead all resulting images are stored in a `tests` folder whose subfolders mimick the folder structure found in the `tests/visual` folder, resulting in images that can be manually inspected.
+If no `config.json` is found, all tests are run locally and are not submitted to the regression server. Instead all resulting images are stored in a `tests` folder whose subfolders mimick the folder structure found in the `visualtests` folder, resulting in images that can be manually inspected.
 
 If a `config.json` is provided, it requires the specification of the URL at which the regression server is located, the hardware string under which the test images are submitted, and a runner id that has to be provided by the administrator of the regression test server. If all these values are correct, test images are directly submitted to the regression server and be can used to compare against a reference image.
 

runner/main.py

@@ -184,7 +184,7 @@ def setup_argparse():
         submit_image(result, hardware, timestamp, file, runner_id, submit_url)
       else:
         store_image(result, file)
-    time.sleep(0.5)
+    time.sleep(2.5)
 else:
   tests = args.test.split(",")
   print(f"Running tests: {tests}")
@@ -205,7 +205,7 @@ def setup_argparse():
         submit_image(result, hardware, timestamp, file, runner_id, submit_url)
       else:
         store_image(result, file)
-    time.sleep(0.5)
+    time.sleep(2.5)
 
 global_end = time.perf_counter()
 print(f"Total time for all tests: {global_end - global_start}")

runner/testsuite/openspace.py

@@ -48,9 +48,6 @@ def write_configuration_overwrite(base_path, data_path):
     f.write("ModuleConfigurations.GlobeBrowsing.MRFCacheEnabled = true\n")
     f.write(f"ModuleConfigurations.GlobeBrowsing.MRFCacheLocation = [[{mrf_location}]]\n")
 
-    # Disable the UI as it contains different time-dependent content
-    f.write(f"ModuleConfigurations.CefWebGui.Enabled = false\n")
-
     # Remove the version checking URL as it would otherwise count as a "user"
     f.write("VersionCheckUrl = [[]]\n")
 
@@ -72,10 +69,12 @@ async def setup_test_run(openspace):
   await openspace.time.setPause(True)
 
   # Unless explicitly added, we don't want display elements that show variable content
+  #  User Interface: Making the screenshots nicer to look at
   #  Dashboard: Framerate
   #  ScreenLog: Log message retention
   #  Version: Contains the commit hash
-  #  Camera: Not technically needed, but results in a cleaner time
+  #  Camera: Not technically needed, but results in a cleaner screenshot
+  await openspace.setPropertyValueSingle("Modules.CefWebGui.Enabled", False)
   await openspace.setPropertyValueSingle("Dashboard.IsEnabled", False)
   await openspace.setPropertyValueSingle("RenderEngine.ShowLog", False)
   await openspace.setPropertyValueSingle("RenderEngine.ShowVersion", False)